diff --git a/appinfo/routes.php b/appinfo/routes.php index 1a217059..f2a09e0a 100644 --- a/appinfo/routes.php +++ b/appinfo/routes.php @@ -72,7 +72,7 @@ return [ ], [ 'name' => 'Admin#memberLevel', - 'url' => '/admin/{emulated}/circles/{circleId}/members/{memberId}/level', + 'url' => '/admin/{emulated}/circles/{circleId}/members/{memberId}/level', 'verb' => 'PUT' ], @@ -113,4 +113,3 @@ return [ ['name' => 'Remote#member', 'url' => '/member/{type}/{userId}/', 'verb' => 'GET'] ] ]; - diff --git a/lib/Activity/Filter.php b/lib/Activity/Filter.php index 0535515d..33c3df28 100644 --- a/lib/Activity/Filter.php +++ b/lib/Activity/Filter.php @@ -73,4 +73,3 @@ class Filter implements IFilter { return [Application::APP_ID]; } } - diff --git a/lib/Activity/Provider.php b/lib/Activity/Provider.php index b2ea4627..215a03a9 100644 --- a/lib/Activity/Provider.php +++ b/lib/Activity/Provider.php @@ -41,7 +41,6 @@ use OCP\Activity\IEvent; use OCP\Activity\IManager; use OCP\Activity\IProvider; - /** * Class Provider * @@ -88,7 +87,6 @@ class Provider implements IProvider { * {@inheritdoc} */ public function parse($lang, IEvent $event, IEvent $previousEvent = null) { - try { $params = $event->getSubjectParameters(); $this->initActivityParser($event, $params); @@ -99,7 +97,6 @@ class Provider implements IProvider { $this->parseAsNonMember($event, $circle, $params); $this->parseAsMember($event, $circle, $params); $this->parseAsModerator($event, $circle, $params); - } catch (FakeException $e) { /** clean exit */ } @@ -259,7 +256,6 @@ class Provider implements IProvider { * @throws FakeException */ private function parseLinkAsModerator(IEvent $event, DeprecatedCircle $circle, $params) { - if (!key_exists('link', $params)) { return; } @@ -278,6 +274,4 @@ class Provider implements IProvider { $this->parserLink->parseLinkDown($event, $circle, $remote); $this->parserLink->parseLinkRemove($event, $circle, $remote); } - - } diff --git a/lib/Activity/ProviderParser.php b/lib/Activity/ProviderParser.php index df75b100..a0029082 100644 --- a/lib/Activity/ProviderParser.php +++ b/lib/Activity/ProviderParser.php @@ -206,11 +206,11 @@ class ProviderParser { IEvent $event, DeprecatedCircle $circle, DeprecatedMember $member, $ownEvent, $othersEvent ) { $data = [ - 'author' => $this->generateViewerParameter($circle), - 'circle' => $this->generateCircleParameter($circle), - 'member' => $this->generateUserParameter($member), + 'author' => $this->generateViewerParameter($circle), + 'circle' => $this->generateCircleParameter($circle), + 'member' => $this->generateUserParameter($member), 'external' => $this->generateExternalMemberParameter($member), - 'group' => $this->generateGroupParameter($member), + 'group' => $this->generateGroupParameter($member), ]; if ($this->isViewerTheAuthor($circle, $this->activityManager->getCurrentUserId())) { @@ -299,9 +299,9 @@ class ProviderParser { */ protected function generateExternalMemberParameter(DeprecatedMember $member) { return [ - 'type' => $member->getTypeName(), - 'id' => $member->getUserId(), - 'name' => $member->getCachedName() . ' (' . $member->getTypeString() . ')', + 'type' => $member->getTypeName(), + 'id' => $member->getUserId(), + 'name' => $member->getCachedName() . ' (' . $member->getTypeString() . ')', '_parsed' => $member->getCachedName() ]; } @@ -314,11 +314,11 @@ class ProviderParser { */ protected function generateCircleParameter(DeprecatedCircle $circle) { return [ - 'type' => 'circle', - 'id' => $circle->getId(), - 'name' => $circle->getName(), + 'type' => 'circle', + 'id' => $circle->getId(), + 'name' => $circle->getName(), '_parsed' => $circle->getName(), - 'link' => Circles::generateAbsoluteLink($circle->getUniqueId()) + 'link' => Circles::generateAbsoluteLink($circle->getUniqueId()) ]; } @@ -329,15 +329,14 @@ class ProviderParser { * @return array */ protected function generateRemoteCircleParameter($link) { - if ($link === null) { return null; } return [ - 'type' => 'circle', - 'id' => $link->getUniqueId(), - 'name' => $link->getToken() . '@' . $link->getAddress(), + 'type' => 'circle', + 'id' => $link->getUniqueId(), + 'name' => $link->getToken() . '@' . $link->getAddress(), '_parsed' => $link->getToken() . '@' . $link->getAddress() ]; } @@ -355,9 +354,9 @@ class ProviderParser { } return [ - 'type' => 'user', - 'id' => $member->getUserId(), - 'name' => $display, + 'type' => 'user', + 'id' => $member->getUserId(), + 'name' => $display, '_parsed' => $display ]; } @@ -370,11 +369,10 @@ class ProviderParser { */ protected function generateGroupParameter($group) { return [ - 'type' => 'user-group', - 'id' => $group->getUserId(), - 'name' => $group->getUserId(), + 'type' => 'user-group', + 'id' => $group->getUserId(), + 'name' => $group->getUserId(), '_parsed' => $group->getUserId() ]; } - } diff --git a/lib/Activity/ProviderSubjectCircle.php b/lib/Activity/ProviderSubjectCircle.php index 0e2dc652..5bad392d 100644 --- a/lib/Activity/ProviderSubjectCircle.php +++ b/lib/Activity/ProviderSubjectCircle.php @@ -27,11 +27,8 @@ namespace OCA\Circles\Activity; - use OCA\Circles\Exceptions\FakeException; use OCA\Circles\Model\DeprecatedCircle; -use OCA\Circles\Model\FederatedLink; -use OCA\Circles\Model\DeprecatedMember; use OCP\Activity\IEvent; class ProviderSubjectCircle extends ProviderParser { @@ -77,6 +74,4 @@ class ProviderSubjectCircle extends ProviderParser { throw new FakeException(); } - - } diff --git a/lib/Activity/ProviderSubjectGroup.php b/lib/Activity/ProviderSubjectGroup.php index 45b8a54c..8d43c12a 100644 --- a/lib/Activity/ProviderSubjectGroup.php +++ b/lib/Activity/ProviderSubjectGroup.php @@ -27,10 +27,8 @@ namespace OCA\Circles\Activity; - use OCA\Circles\Exceptions\FakeException; use OCA\Circles\Model\DeprecatedCircle; -use OCA\Circles\Model\FederatedLink; use OCA\Circles\Model\DeprecatedMember; use OCP\Activity\IEvent; @@ -102,6 +100,4 @@ class ProviderSubjectGroup extends ProviderParser { throw new FakeException(); } - - } diff --git a/lib/Activity/ProviderSubjectLink.php b/lib/Activity/ProviderSubjectLink.php index 9c47de8e..381d249a 100644 --- a/lib/Activity/ProviderSubjectLink.php +++ b/lib/Activity/ProviderSubjectLink.php @@ -27,11 +27,9 @@ namespace OCA\Circles\Activity; - use OCA\Circles\Exceptions\FakeException; use OCA\Circles\Model\DeprecatedCircle; use OCA\Circles\Model\FederatedLink; -use OCA\Circles\Model\DeprecatedMember; use OCP\Activity\IEvent; class ProviderSubjectLink extends ProviderParser { @@ -274,5 +272,4 @@ class ProviderSubjectLink extends ProviderParser { throw new FakeException(); } - } diff --git a/lib/Activity/ProviderSubjectMember.php b/lib/Activity/ProviderSubjectMember.php index cb323840..58f6ba31 100644 --- a/lib/Activity/ProviderSubjectMember.php +++ b/lib/Activity/ProviderSubjectMember.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Activity; - use OCA\Circles\Exceptions\FakeException; use OCA\Circles\Model\DeprecatedCircle; use OCA\Circles\Model\DeprecatedMember; @@ -168,7 +167,6 @@ class ProviderSubjectMember extends ProviderParser { * @throws FakeException */ public function parseSubjectMemberLeft(IEvent $event, DeprecatedCircle $circle, DeprecatedMember $member) { - if ($event->getSubject() !== 'member_left') { return; } @@ -232,7 +230,6 @@ class ProviderSubjectMember extends ProviderParser { * @throws FakeException */ public function parseSubjectMemberRemove(IEvent $event, DeprecatedCircle $circle, DeprecatedMember $member) { - if ($event->getSubject() !== 'member_remove') { return; } diff --git a/lib/Activity/SettingAsMember.php b/lib/Activity/SettingAsMember.php index cd900b4d..a3103ed4 100644 --- a/lib/Activity/SettingAsMember.php +++ b/lib/Activity/SettingAsMember.php @@ -2,7 +2,6 @@ namespace OCA\Circles\Activity; - use OCP\Activity\ISetting; use OCP\IL10N; @@ -84,4 +83,3 @@ class SettingAsMember implements ISetting { return false; } } - diff --git a/lib/Activity/SettingAsModerator.php b/lib/Activity/SettingAsModerator.php index 5a554fcf..d9f55e10 100644 --- a/lib/Activity/SettingAsModerator.php +++ b/lib/Activity/SettingAsModerator.php @@ -2,7 +2,6 @@ namespace OCA\Circles\Activity; - use OCP\Activity\ISetting; use OCP\IL10N; @@ -76,4 +75,3 @@ class SettingAsModerator implements ISetting { return true; } } - diff --git a/lib/Activity/SettingAsNonMember.php b/lib/Activity/SettingAsNonMember.php index a5920a79..d0bf0834 100644 --- a/lib/Activity/SettingAsNonMember.php +++ b/lib/Activity/SettingAsNonMember.php @@ -2,11 +2,9 @@ namespace OCA\Circles\Activity; - use OCP\Activity\ISetting; use OCP\IL10N; - /** * Class SettingAsNonMember * @@ -91,4 +89,3 @@ class SettingAsNonMember implements ISetting { return false; } } - diff --git a/lib/Api/v1/Circles.php b/lib/Api/v1/Circles.php index 650471a2..d29f23cf 100644 --- a/lib/Api/v1/Circles.php +++ b/lib/Api/v1/Circles.php @@ -29,7 +29,6 @@ namespace OCA\Circles\Api\v1; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Exceptions\FederatedUserException; @@ -44,26 +43,25 @@ use OCA\Circles\Service\CircleService; use OCA\Circles\Service\FederatedUserService; class Circles { - - const API_VERSION = [0, 10, 0]; + public const API_VERSION = [0, 10, 0]; // Expose circle and member constants via API - const CIRCLES_PERSONAL = 1; - const CIRCLES_SECRET = 2; - const CIRCLES_CLOSED = 4; - const CIRCLES_PUBLIC = 8; - const CIRCLES_ALL = 15; + public const CIRCLES_PERSONAL = 1; + public const CIRCLES_SECRET = 2; + public const CIRCLES_CLOSED = 4; + public const CIRCLES_PUBLIC = 8; + public const CIRCLES_ALL = 15; - const TYPE_USER = Member::TYPE_USER; - const TYPE_GROUP = Member::TYPE_GROUP; - const TYPE_MAIL = Member::TYPE_MAIL; - const TYPE_CONTACT = Member::TYPE_CONTACT; + public const TYPE_USER = Member::TYPE_USER; + public const TYPE_GROUP = Member::TYPE_GROUP; + public const TYPE_MAIL = Member::TYPE_MAIL; + public const TYPE_CONTACT = Member::TYPE_CONTACT; - const LEVEL_NONE = Member::LEVEL_NONE; - const LEVEL_MEMBER = Member::LEVEL_MEMBER; - const LEVEL_MODERATOR = Member::LEVEL_MODERATOR; - const LEVEL_ADMIN = Member::LEVEL_ADMIN; - const LEVEL_OWNER = Member::LEVEL_OWNER; + public const LEVEL_NONE = Member::LEVEL_NONE; + public const LEVEL_MEMBER = Member::LEVEL_MEMBER; + public const LEVEL_MODERATOR = Member::LEVEL_MODERATOR; + public const LEVEL_ADMIN = Member::LEVEL_ADMIN; + public const LEVEL_OWNER = Member::LEVEL_OWNER; /** @@ -152,7 +150,7 @@ class Circles { null, new SimpleDataStore( [ - 'mustBeMember' => true, + 'mustBeMember' => true, 'includePersonalCircles' => $personalCircle ] ) @@ -244,6 +242,4 @@ class Circles { // return $c->query(CirclesService::class) // ->getFilesForCircles($circleUniqueIds); } - } - diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php index 58aac0e8..a3545e99 100644 --- a/lib/AppInfo/Application.php +++ b/lib/AppInfo/Application.php @@ -34,7 +34,6 @@ declare(strict_types=1); namespace OCA\Circles\AppInfo; - use Closure; use OC; use OCA\Circles\Events\AddingCircleMemberEvent; @@ -92,17 +91,15 @@ require_once __DIR__ . '/../../vendor/autoload.php'; * @package OCA\Circles\AppInfo */ class Application extends App implements IBootstrap { + public const APP_ID = 'circles'; + public const APP_NAME = 'Circles'; + public const APP_TOKEN = 'dvG7laa0_UU'; + public const APP_SUBJECT = 'http://nextcloud.com/'; + public const APP_REL = 'https://apps.nextcloud.com/apps/circles'; + public const APP_API = 1; - const APP_ID = 'circles'; - const APP_NAME = 'Circles'; - const APP_TOKEN = 'dvG7laa0_UU'; - - const APP_SUBJECT = 'http://nextcloud.com/'; - const APP_REL = 'https://apps.nextcloud.com/apps/circles'; - const APP_API = 1; - - const CLIENT_TIMEOUT = 3; + public const CLIENT_TIMEOUT = 3; /** @var ConfigService */ @@ -114,7 +111,7 @@ class Application extends App implements IBootstrap { * * @param array $params */ - public function __construct(array $params = array()) { + public function __construct(array $params = []) { parent::__construct(self::APP_ID, $params); } @@ -149,13 +146,13 @@ class Application extends App implements IBootstrap { // It seems that AccountManager use deprecated dispatcher, let's use a deprecated listener $dispatcher = OC::$server->getEventDispatcher(); $dispatcher->addListener( - 'OC\AccountManager::userUpdated', function(GenericEvent $event) { - /** @var IUser $user */ - $user = $event->getSubject(); - /** @var DeprecatedListener $deprecatedListener */ - $deprecatedListener = OC::$server->get(DeprecatedListener::class); - $deprecatedListener->userAccountUpdated($user); - } + 'OC\AccountManager::userUpdated', function (GenericEvent $event) { + /** @var IUser $user */ + $user = $event->getSubject(); + /** @var DeprecatedListener $deprecatedListener */ + $deprecatedListener = OC::$server->get(DeprecatedListener::class); + $deprecatedListener->userAccountUpdated($user); + } ); $context->registerWellKnownHandler(WebfingerHandler::class); @@ -270,6 +267,4 @@ class Application extends App implements IBootstrap { // } // ); } - } - diff --git a/lib/AppInfo/Capabilities.php b/lib/AppInfo/Capabilities.php index 511a27f4..e90b661f 100644 --- a/lib/AppInfo/Capabilities.php +++ b/lib/AppInfo/Capabilities.php @@ -32,7 +32,6 @@ declare(strict_types=1); namespace OCA\Circles\AppInfo; - use OCA\Circles\Model\Circle; use OCA\Circles\Model\Member; use OCA\Circles\Service\ConfigService; @@ -41,7 +40,6 @@ use OCP\App\IAppManager; use OCP\Capabilities\ICapability; use OCP\IL10N; - /** * Class Capabilities * @@ -92,11 +90,11 @@ class Capabilities implements ICapability { public function getCapabilities(bool $complete = false): array { return [ Application::APP_ID => [ - 'version' => $this->appManager->getAppVersion(Application::APP_ID), - 'status' => $this->getCapabilitiesStatus($complete), + 'version' => $this->appManager->getAppVersion(Application::APP_ID), + 'status' => $this->getCapabilitiesStatus($complete), 'settings' => $this->configService->getSettings(), - 'circle' => $this->getCapabilitiesCircle(), - 'member' => $this->getCapabilitiesMember() + 'circle' => $this->getCapabilitiesCircle(), + 'member' => $this->getCapabilitiesMember() ], ]; } @@ -114,7 +112,7 @@ class Capabilities implements ICapability { if ($complete) { $status['interfaces'] = [ - 'all' => $this->interfaceService->getInterfaces(true), + 'all' => $this->interfaceService->getInterfaces(true), 'internal' => $this->interfaceService->getInternalInterfaces(true) ]; } @@ -129,7 +127,7 @@ class Capabilities implements ICapability { private function getCapabilitiesCircle(): array { return [ 'constants' => $this->getCapabilitiesCircleConstants(), - 'config' => $this->getCapabilitiesCircleConfig() + 'config' => $this->getCapabilitiesCircleConfig() ]; } @@ -140,7 +138,7 @@ class Capabilities implements ICapability { private function getCapabilitiesMember(): array { return [ 'constants' => $this->getCapabilitiesMemberConstants(), - 'type' => Member::$TYPE + 'type' => Member::$TYPE ]; } @@ -150,38 +148,38 @@ class Capabilities implements ICapability { */ private function getCapabilitiesCircleConstants(): array { return [ - 'flags' => [ - Circle::CFG_SINGLE => $this->l10n->t('Single'), - Circle::CFG_PERSONAL => $this->l10n->t('Personal'), - Circle::CFG_SYSTEM => $this->l10n->t('System'), - Circle::CFG_VISIBLE => $this->l10n->t('Visible'), - Circle::CFG_OPEN => $this->l10n->t('Open'), - Circle::CFG_INVITE => $this->l10n->t('Invite'), - Circle::CFG_REQUEST => $this->l10n->t('Join Request'), - Circle::CFG_FRIEND => $this->l10n->t('Friends'), - Circle::CFG_PROTECTED => $this->l10n->t('Password Protected'), - Circle::CFG_NO_OWNER => $this->l10n->t('No Owner'), - Circle::CFG_HIDDEN => $this->l10n->t('Hidden'), - Circle::CFG_BACKEND => $this->l10n->t('Backend'), - Circle::CFG_LOCAL => $this->l10n->t('Local'), - Circle::CFG_ROOT => $this->l10n->t('Root'), + 'flags' => [ + Circle::CFG_SINGLE => $this->l10n->t('Single'), + Circle::CFG_PERSONAL => $this->l10n->t('Personal'), + Circle::CFG_SYSTEM => $this->l10n->t('System'), + Circle::CFG_VISIBLE => $this->l10n->t('Visible'), + Circle::CFG_OPEN => $this->l10n->t('Open'), + Circle::CFG_INVITE => $this->l10n->t('Invite'), + Circle::CFG_REQUEST => $this->l10n->t('Join Request'), + Circle::CFG_FRIEND => $this->l10n->t('Friends'), + Circle::CFG_PROTECTED => $this->l10n->t('Password Protected'), + Circle::CFG_NO_OWNER => $this->l10n->t('No Owner'), + Circle::CFG_HIDDEN => $this->l10n->t('Hidden'), + Circle::CFG_BACKEND => $this->l10n->t('Backend'), + Circle::CFG_LOCAL => $this->l10n->t('Local'), + Circle::CFG_ROOT => $this->l10n->t('Root'), Circle::CFG_CIRCLE_INVITE => $this->l10n->t('Circle Invite'), - Circle::CFG_FEDERATED => $this->l10n->t('Federated'), - Circle::CFG_MOUNTPOINT => $this->l10n->t('Mount point') + Circle::CFG_FEDERATED => $this->l10n->t('Federated'), + Circle::CFG_MOUNTPOINT => $this->l10n->t('Mount point') ], 'source' => [ - 'core' => [ - Member::TYPE_USER => $this->l10n->t('Nextcloud User'), - Member::TYPE_GROUP => $this->l10n->t('Nextcloud Group'), - Member::TYPE_MAIL => $this->l10n->t('Email Address'), + 'core' => [ + Member::TYPE_USER => $this->l10n->t('Nextcloud User'), + Member::TYPE_GROUP => $this->l10n->t('Nextcloud Group'), + Member::TYPE_MAIL => $this->l10n->t('Email Address'), Member::TYPE_CONTACT => $this->l10n->t('Contact'), - Member::TYPE_CIRCLE => $this->l10n->t('Circle'), - Member::TYPE_APP => $this->l10n->t('Nextcloud App') + Member::TYPE_CIRCLE => $this->l10n->t('Circle'), + Member::TYPE_APP => $this->l10n->t('Nextcloud App') ], 'extra' => [ Member::APP_CIRCLES => 'Circles App', - Member::APP_OCC => 'Admin Command Line' + Member::APP_OCC => 'Admin Command Line' ] ] ]; @@ -193,7 +191,7 @@ class Capabilities implements ICapability { */ private function getCapabilitiesCircleConfig(): array { return [ - 'coreFlags' => Circle::$DEF_CFG_CORE_FILTER, + 'coreFlags' => Circle::$DEF_CFG_CORE_FILTER, 'systemFlags' => Circle::$DEF_CFG_SYSTEM_FILTER ]; } @@ -205,13 +203,11 @@ class Capabilities implements ICapability { private function getCapabilitiesMemberConstants(): array { return [ 'level' => [ - Member::LEVEL_MEMBER => $this->l10n->t('Member'), + Member::LEVEL_MEMBER => $this->l10n->t('Member'), Member::LEVEL_MODERATOR => $this->l10n->t('Moderator'), - Member::LEVEL_ADMIN => $this->l10n->t('Admin'), - Member::LEVEL_OWNER => $this->l10n->t('Owner') + Member::LEVEL_ADMIN => $this->l10n->t('Admin'), + Member::LEVEL_OWNER => $this->l10n->t('Owner') ] ]; } - } - diff --git a/lib/Circles/FileSharingBroadcaster.php b/lib/Circles/FileSharingBroadcaster.php index 35048062..89cc376a 100644 --- a/lib/Circles/FileSharingBroadcaster.php +++ b/lib/Circles/FileSharingBroadcaster.php @@ -58,7 +58,6 @@ use OCP\Share\Exceptions\IllegalIDChangeException; use OCP\Share\IShare; use OCP\Util; - /** * Class FileSharingBroadcaster * @deprecated @@ -146,7 +145,6 @@ class FileSharingBroadcaster implements IBroadcaster { $this->federatedEnabled = true; } catch (QueryException $e) { } - } @@ -283,7 +281,7 @@ class FileSharingBroadcaster implements IBroadcaster { $allShares = $this->fileSharesRequest->getSharesForCircle($member->getCircleId()); $knownShares = array_map( - function(SharesToken $shareToken) { + function (SharesToken $shareToken) { return $shareToken->getShareId(); }, $this->tokensRequest->getTokensFromMember($member) @@ -382,10 +380,10 @@ class FileSharingBroadcaster implements IBroadcaster { } catch (\Exception $e) { $this->logger->logException( $e, [ - 'message' => 'Failed to notify remote server of circles-federated share', - 'level' => ILogger::ERROR, - 'app' => 'circles', - ] + 'message' => 'Failed to notify remote server of circles-federated share', + 'level' => ILogger::ERROR, + 'app' => 'circles', + ] ); } @@ -505,12 +503,12 @@ class FileSharingBroadcaster implements IBroadcaster { $emailTemplate = $this->mailer->createEMailTemplate( 'sharebymail.RecipientPasswordNotification', [ - 'filename' => $filename, - 'password' => $password, - 'initiator' => $initiatorDisplayName, - 'initiatorEmail' => $initiatorEmailAddress, - 'shareWith' => $shareWith, - ] + 'filename' => $filename, + 'password' => $password, + 'initiator' => $initiatorDisplayName, + 'initiatorEmail' => $initiatorEmailAddress, + 'shareWith' => $shareWith, + ] ); $emailTemplate->setSubject( @@ -561,11 +559,11 @@ class FileSharingBroadcaster implements IBroadcaster { ) { $emailTemplate = $this->mailer->createEMailTemplate( 'circles.ShareNotification', [ - 'fileName' => $fileName, - 'fileLink' => $link, - 'author' => $author, - 'circleName' => $circleName, - ] + 'fileName' => $fileName, + 'fileLink' => $link, + 'author' => $author, + 'circleName' => $circleName, + ] ); $emailTemplate->addHeader(); @@ -653,9 +651,9 @@ class FileSharingBroadcaster implements IBroadcaster { $emailTemplate = $this->mailer->createEMailTemplate( 'sharebymail.RecipientPasswordNotification', [ - 'password' => $password, - 'author' => $author - ] + 'password' => $password, + 'author' => $author + ] ); $emailTemplate->setSubject( @@ -711,8 +709,8 @@ class FileSharingBroadcaster implements IBroadcaster { $filename = basename($share['file_target']); return [ - 'author' => $author, - 'link' => $link, + 'author' => $author, + 'link' => $link, 'filename' => $filename ]; } @@ -813,5 +811,4 @@ class FileSharingBroadcaster implements IBroadcaster { return $contact['EMAIL']; } - } diff --git a/lib/CirclesManager.php b/lib/CirclesManager.php index e69ccd83..130defaa 100644 --- a/lib/CirclesManager.php +++ b/lib/CirclesManager.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Exceptions\FederatedEventException; @@ -58,7 +57,6 @@ use OCA\Circles\Service\FederatedUserService; use OCA\Circles\Service\MemberService; use OCP\IUserSession; - /** * Class CirclesManager * @@ -326,7 +324,4 @@ class CirclesManager { * @return Member */ // public function getMemberById(string $memberId): Member { - - } - diff --git a/lib/CirclesQueryHelper.php b/lib/CirclesQueryHelper.php index cc329d10..97b5e590 100644 --- a/lib/CirclesQueryHelper.php +++ b/lib/CirclesQueryHelper.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles; - use OCA\Circles\Db\CoreQueryBuilder; use OCA\Circles\Db\CoreRequestBuilder; use OCA\Circles\Exceptions\CircleNotFoundException; @@ -42,7 +41,6 @@ use OCA\Circles\Service\FederatedUserService; use OCP\DB\QueryBuilder\ICompositeExpression; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * Class CirclesQueryHelper * @@ -109,7 +107,7 @@ class CirclesQueryHelper { $this->queryBuilder->setOptions( [CoreQueryBuilder::HELPER], [ - 'getData' => $fullDetails, + 'getData' => $fullDetails, 'mustBeMember' => true ] ); @@ -142,7 +140,7 @@ class CirclesQueryHelper { $this->queryBuilder->setOptions( [CoreQueryBuilder::HELPER], [ - 'getData' => $fullDetails, + 'getData' => $fullDetails, 'mustBeMember' => true ] ); @@ -193,6 +191,4 @@ class CirclesQueryHelper { return $circle; } - } - diff --git a/lib/Collaboration/v2/CollaboratorSearchPlugin.php b/lib/Collaboration/v2/CollaboratorSearchPlugin.php index f2d14564..e38d2529 100644 --- a/lib/Collaboration/v2/CollaboratorSearchPlugin.php +++ b/lib/Collaboration/v2/CollaboratorSearchPlugin.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Collaboration\v2; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use Exception; use OC\Share20\Share; @@ -42,7 +41,6 @@ use OCP\Collaboration\Collaborators\ISearchPlugin; use OCP\Collaboration\Collaborators\ISearchResult; use OCP\Collaboration\Collaborators\SearchResultType; - /** * Class CollaboratorSearchPlugin * @@ -91,7 +89,7 @@ class CollaboratorSearchPlugin implements ISearchPlugin { $filterCircle, null, new SimpleDataStore( [ - 'limit' => $limit, + 'limit' => $limit, 'offset' => $offset ] ) @@ -123,15 +121,13 @@ class CollaboratorSearchPlugin implements ISearchPlugin { */ private function addResultEntry(Circle $circle): array { return [ - 'label' => $circle->getDisplayName(), + 'label' => $circle->getDisplayName(), 'shareWithDescription' => $circle->getOwner()->getDisplayName(), - 'value' => [ + 'value' => [ 'shareType' => Share::TYPE_CIRCLE, 'shareWith' => $circle->getSingleId(), - 'circle' => $circle + 'circle' => $circle ], ]; } - } - diff --git a/lib/Command/CirclesCheck.php b/lib/Command/CirclesCheck.php index db007916..8a04dd4a 100644 --- a/lib/Command/CirclesCheck.php +++ b/lib/Command/CirclesCheck.php @@ -1,4 +1,6 @@ -writeln( '- Address ' . $loopback . ' is now used as loopback' ); - } /** @@ -464,8 +462,6 @@ class CirclesCheck extends Base { $output->writeln( '. The address you need to define here is the local address of your Nextcloud, reachable by all other instances of our GlobalScale.' ); - - } @@ -499,7 +495,6 @@ class CirclesCheck extends Base { while (true) { - $question = new Question( 'Please write down a new frontal address to test: ', '' ); @@ -740,6 +735,4 @@ class CirclesCheck extends Base { return [$scheme, $cloudId]; } - } - diff --git a/lib/Command/CirclesConfig.php b/lib/Command/CirclesConfig.php index f32a7cfb..053b54fa 100644 --- a/lib/Command/CirclesConfig.php +++ b/lib/Command/CirclesConfig.php @@ -31,9 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; -use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; -use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; -use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException; use OC\Core\Command\Base; use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Exceptions\FederatedEventException; @@ -62,7 +59,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesConfig * @@ -223,14 +219,12 @@ class CirclesConfig extends Base { array_walk( $listing, - function(string &$v): void { - list(, $long) = explode('|', $v); + function (string &$v): void { + [, $long] = explode('|', $v); $v = strtoupper(str_replace(' ', '', $long)); } ); return $listing; } - } - diff --git a/lib/Command/CirclesCreate.php b/lib/Command/CirclesCreate.php index 9f1e617e..bcba99c9 100644 --- a/lib/Command/CirclesCreate.php +++ b/lib/Command/CirclesCreate.php @@ -1,4 +1,6 @@ -federatedUserService = $federatedUserService; $this->circleService = $circleService; - } @@ -133,6 +133,4 @@ class CirclesCreate extends Base { return 0; } - } - diff --git a/lib/Command/CirclesDestroy.php b/lib/Command/CirclesDestroy.php index d5e3de25..2e65ccd9 100644 --- a/lib/Command/CirclesDestroy.php +++ b/lib/Command/CirclesDestroy.php @@ -54,7 +54,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesDestroy * @@ -144,6 +143,4 @@ class CirclesDestroy extends Base { return 0; } - } - diff --git a/lib/Command/CirclesDetails.php b/lib/Command/CirclesDetails.php index 65fc89a5..a1fe097e 100644 --- a/lib/Command/CirclesDetails.php +++ b/lib/Command/CirclesDetails.php @@ -59,7 +59,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesDetails * @@ -118,7 +117,6 @@ class CirclesDetails extends Base { ->addOption('initiator', '', InputOption::VALUE_REQUIRED, 'set an initiator to the request', '') ->addOption('initiator-type', '', InputOption::VALUE_REQUIRED, 'set initiator type', '0') ->addOption('status-code', '', InputOption::VALUE_NONE, 'display status code on exception'); - } @@ -154,7 +152,7 @@ class CirclesDetails extends Base { $circleId, $instance, [ - 'initiator' => $input->getOption('initiator'), + 'initiator' => $input->getOption('initiator'), 'initiatorType' => Member::parseTypeString($input->getOption('initiator-type')) ] ); @@ -188,6 +186,4 @@ class CirclesDetails extends Base { return 0; } - } - diff --git a/lib/Command/CirclesEdit.php b/lib/Command/CirclesEdit.php index eead3de6..8bcfa38e 100644 --- a/lib/Command/CirclesEdit.php +++ b/lib/Command/CirclesEdit.php @@ -57,7 +57,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesEdit * @@ -105,7 +104,6 @@ class CirclesEdit extends Base { ->addOption('initiator', '', InputOption::VALUE_REQUIRED, 'set an initiator to the request', '') ->addOption('initiator-type', '', InputOption::VALUE_REQUIRED, 'set initiator type', '0') ->addOption('status-code', '', InputOption::VALUE_NONE, 'display status code on exception'); - } @@ -170,6 +168,4 @@ class CirclesEdit extends Base { return 0; } - } - diff --git a/lib/Command/CirclesJoin.php b/lib/Command/CirclesJoin.php index 76b1c936..5e2d2a4e 100644 --- a/lib/Command/CirclesJoin.php +++ b/lib/Command/CirclesJoin.php @@ -57,7 +57,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesJoin * @@ -155,6 +154,4 @@ class CirclesJoin extends Base { return 0; } - } - diff --git a/lib/Command/CirclesLeave.php b/lib/Command/CirclesLeave.php index 23ab5d18..8853f727 100644 --- a/lib/Command/CirclesLeave.php +++ b/lib/Command/CirclesLeave.php @@ -45,7 +45,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesLeave * @@ -135,6 +134,4 @@ class CirclesLeave extends Base { return 0; } - } - diff --git a/lib/Command/CirclesList.php b/lib/Command/CirclesList.php index 8724a971..88ce0a50 100644 --- a/lib/Command/CirclesList.php +++ b/lib/Command/CirclesList.php @@ -65,15 +65,12 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesList * * @package OCA\Circles\Command */ class CirclesList extends Base { - - use TArrayTools; use TStringTools; @@ -233,6 +230,4 @@ class CirclesList extends Base { ); } } - } - diff --git a/lib/Command/CirclesMaintenance.php b/lib/Command/CirclesMaintenance.php index 603628bc..d9e97fcc 100644 --- a/lib/Command/CirclesMaintenance.php +++ b/lib/Command/CirclesMaintenance.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; - use OC\Core\Command\Base; use OCA\Circles\Db\CoreRequestBuilder; use OCA\Circles\Exceptions\MaintenanceException; @@ -43,7 +42,6 @@ use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Console\Question\ConfirmationQuestion; use Symfony\Component\Console\Question\Question; - /** * Class CirclesMaintenance * @@ -169,8 +167,4 @@ class CirclesMaintenance extends Base { return 0; } - } - - - diff --git a/lib/Command/CirclesMemberships.php b/lib/Command/CirclesMemberships.php index 39e72915..743ad1bd 100644 --- a/lib/Command/CirclesMemberships.php +++ b/lib/Command/CirclesMemberships.php @@ -73,15 +73,12 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesMemberships * * @package OCA\Circles\Command */ class CirclesMemberships extends Base { - - use TArrayTools; use TNC22ConsoleTree; @@ -245,7 +242,7 @@ class CirclesMemberships extends Base { $this->drawTree( $tree, [$this, 'displayLeaf'], [ - 'height' => 3, + 'height' => 3, 'node-spacing' => 0, 'item-spacing' => 1, ] @@ -276,8 +273,8 @@ class CirclesMemberships extends Base { $item = new NC22TreeNode( $tree, new SimpleDataStore( [ - 'member' => $member, - 'cycling' => in_array($member->getCircleId(), $knownIds) + 'member' => $member, + 'cycling' => in_array($member->getCircleId(), $knownIds) ] ) ); @@ -400,6 +397,4 @@ class CirclesMemberships extends Base { $output->writeln($count . ' memberships updated'); } - } - diff --git a/lib/Command/CirclesRemote.php b/lib/Command/CirclesRemote.php index 54f15b72..05572c2c 100644 --- a/lib/Command/CirclesRemote.php +++ b/lib/Command/CirclesRemote.php @@ -57,15 +57,12 @@ use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Console\Question\ConfirmationQuestion; - /** * Class CirclesRemote * * @package OCA\Circles\Command */ class CirclesRemote extends Base { - - use TNC22WellKnown; use TStringTools; @@ -249,7 +246,7 @@ class CirclesRemote extends Base { } $payload = [ - 'test' => 42, + 'test' => 42, 'token' => $this->uuid() ]; $signedRequest = $this->outgoingTest($testUrl, $payload); @@ -325,14 +322,12 @@ class CirclesRemote extends Base { ); $this->remoteStreamService->update($remoteSignatory, RemoteStreamService::UPDATE_HREF); } - } catch (RemoteUidException $e) { $this->updateRemote($remoteSignatory); } catch (RemoteNotFoundException $e) { $this->saveRemote($remoteSignatory); } } - } @@ -435,7 +430,7 @@ class CirclesRemote extends Base { private function verifyGSInstances(): void { $instances = $this->globalScaleService->getGlobalScaleInstances(); $known = array_map( - function(RemoteInstance $instance): string { + function (RemoteInstance $instance): string { return $instance->getInstance(); }, $this->remoteRequest->getFromType(RemoteInstance::TYPE_GLOBALSCALE) ); @@ -531,6 +526,4 @@ class CirclesRemote extends Base { throw new Exception('Unknown interface: ' . implode(', ', InterfaceService::$LIST_IFACE)); } - } - diff --git a/lib/Command/CirclesReport.php b/lib/Command/CirclesReport.php index e7630470..9c962a33 100644 --- a/lib/Command/CirclesReport.php +++ b/lib/Command/CirclesReport.php @@ -57,15 +57,12 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesReport * * @package OCA\Circles\Command */ class CirclesReport extends Base implements IInteractiveShellClient { - - use TNC22Deserialize; use TArrayTools; @@ -435,7 +432,4 @@ class CirclesReport extends Base implements IInteractiveShellClient { public function onNewCommand(NC22InteractiveShellSession $session, $command): void { echo $session->getPath(); } - - } - diff --git a/lib/Command/CirclesSync.php b/lib/Command/CirclesSync.php index 03c2bf1b..ff04b1c2 100644 --- a/lib/Command/CirclesSync.php +++ b/lib/Command/CirclesSync.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; - use OC\Core\Command\Base; use OCA\Circles\Exceptions\ContactAddressBookNotFoundException; use OCA\Circles\Exceptions\ContactFormatException; @@ -49,7 +48,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class CirclesSync * @@ -178,6 +176,4 @@ class CirclesSync extends Base { return $sync; } - } - diff --git a/lib/Command/CirclesTest.php b/lib/Command/CirclesTest.php index 6eb992f6..f350a468 100644 --- a/lib/Command/CirclesTest.php +++ b/lib/Command/CirclesTest.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\ItemNotFoundException; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; @@ -40,7 +39,6 @@ use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; use OC\Core\Command\Base; use OCA\Circles\AppInfo\Application; -use OCA\Circles\CirclesManager; use OCA\Circles\Db\CoreRequestBuilder; use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Model\Circle; @@ -53,21 +51,18 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Process\Process; - /** * Class CirclesTest * * @package OCA\Circles\Command */ class CirclesTest extends Base { - - use TArrayTools; use TStringTools; use TNC22Deserialize; - static $INSTANCES = [ + public static $INSTANCES = [ 'global-scale-1', 'global-scale-2', 'global-scale-3', @@ -77,7 +72,7 @@ class CirclesTest extends Base { ]; - static $TEST_CIRCLES = [ + public static $TEST_CIRCLES = [ 'test_001' ]; @@ -296,7 +291,6 @@ class CirclesTest extends Base { } $this->r(); } - } } @@ -575,7 +569,8 @@ class CirclesTest extends Base { /** @var Circle $createdCircle */ $createdCircle = $this->deserialize($dataCreatedCircle001, Circle::class); $this->circles[$localInstanceId][$createdCircle->getName()] = $createdCircle; - $this->r(true, $createdCircle->getSingleId());; + $this->r(true, $createdCircle->getSingleId()); + ; $this->p('Comparing data returned at creation'); if ($createdCircle->getSingleId() === '' || $createdCircle->getOwner()->getId() === '') { @@ -647,7 +642,8 @@ class CirclesTest extends Base { $member = $this->getInstanceUsers($instanceId)[2]; $addedMember = $this->processMemberAdd($instanceId, $circleName, $member, 'user'); - $this->r(true, $addedMember->getId());; + $this->r(true, $addedMember->getId()); + ; // check test2 } @@ -673,7 +669,8 @@ class CirclesTest extends Base { ); /** @var Member $addedMember */ $addedMember = $this->deserialize($dataAddedMember, Member::class); - $this->r(true, $addedMember->getId());; + $this->r(true, $addedMember->getId()); + ; // check test6 } @@ -696,7 +693,8 @@ class CirclesTest extends Base { ); /** @var Member $addedMember */ $addedMember = $this->deserialize($dataAddedMember, Member::class); - $this->r(true, $addedMember->getId());; + $this->r(true, $addedMember->getId()); + ; } private function levelLocalMemberToModerator() { @@ -779,7 +777,6 @@ class CirclesTest extends Base { bool $versa = false, array $params = [] ) { - if (empty($params)) { $params = [ 'CIRCLEID' => $circle->getSingleId() @@ -1147,6 +1144,4 @@ class CirclesTest extends Base { return $addedMember; } - } - diff --git a/lib/Command/FixUniqueId.php b/lib/Command/FixUniqueId.php index 722d76a8..2ea79a6f 100644 --- a/lib/Command/FixUniqueId.php +++ b/lib/Command/FixUniqueId.php @@ -36,7 +36,6 @@ use OCP\IDBConnection; use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Output\OutputInterface; - class FixUniqueId extends Base { /** @var IDBConnection */ @@ -58,7 +57,6 @@ class FixUniqueId extends Base { } protected function execute(InputInterface $input, OutputInterface $output) { - try { $this->swapToShortenUniqueId(); @@ -70,7 +68,6 @@ class FixUniqueId extends Base { private function swapToShortenUniqueId() { - $qb = $this->connection->getQueryBuilder(); /** @noinspection PhpMethodParametersCountMismatchInspection */ @@ -109,7 +106,6 @@ class FixUniqueId extends Base { private function swapToShortenUniqueIdInTable($circleId, $shortenUniqueId, $table) { - $qb = $this->connection->getQueryBuilder(); $qb->update($table) ->where( @@ -140,9 +136,4 @@ class FixUniqueId extends Base { $qb->set('share_with', $qb->createNamedParameter($shortenUniqueId)); $qb->execute(); } - - } - - - diff --git a/lib/Command/Groups.php b/lib/Command/Groups.php index 27a9f9fc..0457c9bf 100644 --- a/lib/Command/Groups.php +++ b/lib/Command/Groups.php @@ -71,12 +71,10 @@ class Groups extends Base { protected function execute(InputInterface $input, OutputInterface $output) { - try { $this->listLinkedGroups($input, $output); $this->addLinkedGroups($input, $output); $this->delLinkedGroups($input, $output); - } catch (FakeException $e) { $output->writeln('done'); } catch (Exception $e) { @@ -112,7 +110,7 @@ class Groups extends Base { return; } - list($circleId, $group) = $this->getCircleIdAndGroupFromArguments($input); + [$circleId, $group] = $this->getCircleIdAndGroupFromArguments($input); throw new FakeException(); } @@ -129,7 +127,7 @@ class Groups extends Base { return; } - list($circleId, $group) = $this->getCircleIdAndGroupFromArguments($input); + [$circleId, $group] = $this->getCircleIdAndGroupFromArguments($input); throw new FakeException(); } @@ -148,6 +146,4 @@ class Groups extends Base { return [$input->getArgument('circle_id'), $input->getArgument('group')]; } - } - diff --git a/lib/Command/MembersAdd.php b/lib/Command/MembersAdd.php index 9a360798..b1e0faae 100644 --- a/lib/Command/MembersAdd.php +++ b/lib/Command/MembersAdd.php @@ -51,7 +51,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MembersAdd * @@ -186,7 +185,7 @@ class MembersAdd extends Base { continue; } - list(, $host) = explode('@', $user['federationId']); + [, $host] = explode('@', $user['federationId']); if (strtolower($user['userid']['value']) === strtolower($search)) { $userId = $user['userid']['value']; $instance = $host; @@ -203,6 +202,4 @@ class MembersAdd extends Base { return $userId; } - } - diff --git a/lib/Command/MembersDetails.php b/lib/Command/MembersDetails.php index 15ce4cfd..23a3451a 100644 --- a/lib/Command/MembersDetails.php +++ b/lib/Command/MembersDetails.php @@ -56,7 +56,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MembersDetails * @@ -142,6 +141,4 @@ class MembersDetails extends Base { return 0; } - } - diff --git a/lib/Command/MembersLevel.php b/lib/Command/MembersLevel.php index 4d17d98b..4a002e39 100644 --- a/lib/Command/MembersLevel.php +++ b/lib/Command/MembersLevel.php @@ -31,10 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; - -use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; -use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; -use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException; use OC\Core\Command\Base; use OCA\Circles\Db\MemberRequest; use OCA\Circles\Exceptions\CircleNotFoundException; @@ -63,7 +59,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MembersLevel * @@ -173,6 +168,4 @@ class MembersLevel extends Base { return 0; } - } - diff --git a/lib/Command/MembersList.php b/lib/Command/MembersList.php index f43b6223..31768e9c 100644 --- a/lib/Command/MembersList.php +++ b/lib/Command/MembersList.php @@ -71,15 +71,12 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MembersList * * @package OCA\Circles\Command */ class MembersList extends Base { - - use TNC22ConsoleTree; use TStringTools; @@ -212,7 +209,7 @@ class MembersList extends Base { $this->drawTree( $tree, [$this, 'displayLeaf'], [ - 'height' => 3, + 'height' => 3, 'node-spacing' => 1, 'item-spacing' => 0, ] @@ -364,9 +361,9 @@ class MembersList extends Base { $node = new NC22TreeNode( $tree, new SimpleDataStore( [ - 'circle' => $circle, - 'member' => $member, - 'cycling' => in_array($member->getSingleId(), $knownIds), + 'circle' => $circle, + 'member' => $member, + 'cycling' => in_array($member->getSingleId(), $knownIds), ] ) ); @@ -384,8 +381,8 @@ class MembersList extends Base { new NC22TreeNode( $tree, new SimpleDataStore( [ - 'member' => $member, - 'cycling' => in_array($member->getSingleId(), $knownIds) + 'member' => $member, + 'cycling' => in_array($member->getSingleId(), $knownIds) ] ) ); @@ -451,7 +448,6 @@ class MembersList extends Base { $type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG)); $line .= ($type === '') ? '' : ' Config: ' . $type; } - } else { if ($lineNumber === 1 && !is_null($circle)) { $line .= '' . $circle->getSingleId() . ''; @@ -462,12 +458,9 @@ class MembersList extends Base { } return $line; - } catch (InvalidItemException | ItemNotFoundException | UnknownTypeException $e) { } return ''; } - } - diff --git a/lib/Command/MembersRemove.php b/lib/Command/MembersRemove.php index 7959e7c5..03fe277f 100644 --- a/lib/Command/MembersRemove.php +++ b/lib/Command/MembersRemove.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; -use Exception; use OC\Core\Command\Base; use OCA\Circles\Db\MemberRequest; use OCA\Circles\Exceptions\CircleNotFoundException; @@ -42,7 +41,6 @@ use OCA\Circles\Exceptions\FederatedUserNotFoundException; use OCA\Circles\Exceptions\InitiatorNotConfirmedException; use OCA\Circles\Exceptions\InitiatorNotFoundException; use OCA\Circles\Exceptions\InvalidIdException; -use OCA\Circles\Exceptions\MemberDoesNotExistException; use OCA\Circles\Exceptions\MemberNotFoundException; use OCA\Circles\Exceptions\OwnerNotFoundException; use OCA\Circles\Exceptions\RemoteInstanceException; @@ -60,7 +58,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MembersRemove * @@ -149,6 +146,4 @@ class MembersRemove extends Base { return 0; } - } - diff --git a/lib/Command/MembersSearch.php b/lib/Command/MembersSearch.php index a9739445..2c58505b 100644 --- a/lib/Command/MembersSearch.php +++ b/lib/Command/MembersSearch.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Command; - use OC\Core\Command\Base; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; @@ -44,7 +43,6 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MembersSearch * @@ -123,6 +121,4 @@ class MembersSearch extends Base { ); } } - } - diff --git a/lib/Command/SharesFiles.php b/lib/Command/SharesFiles.php index da3cdff4..f7ffdc61 100644 --- a/lib/Command/SharesFiles.php +++ b/lib/Command/SharesFiles.php @@ -51,15 +51,12 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\ConsoleOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class SharesFilesList * * @package OCA\Circles\Command */ class SharesFiles extends Base { - - use TArrayTools; @@ -239,11 +236,11 @@ class SharesFiles extends Base { if (!$filterRecipient) { $row = array_merge( $row, [ - $sharedTo . ' (' . $recipient->getSingleId() . ', ' - . Circle::$DEF_SOURCE[$recipient->getBasedOn()->getSource()] . ')', - (($share->getChildId() > 0) ? $share->getChildFileTarget( - ) : $share->getFileTarget()), - ] + $sharedTo . ' (' . $recipient->getSingleId() . ', ' + . Circle::$DEF_SOURCE[$recipient->getBasedOn()->getSource()] . ')', + (($share->getChildId() > 0) ? $share->getChildFileTarget( + ) : $share->getFileTarget()), + ] ); } @@ -275,7 +272,6 @@ class SharesFiles extends Base { bool $all, ?bool &$filterRecipient = false ): array { - if ($fileId > 0) { return $this->shareWrapperService->getSharesByFileId($this->fileId, true); } @@ -319,6 +315,4 @@ class SharesFiles extends Base { 'Specify a FileId or an option: --with (USER), --by (USER), --to (CIRCLE)' ); } - } - diff --git a/lib/Command/SyncContact.php b/lib/Command/SyncContact.php index 6cb29f3a..90be29cb 100644 --- a/lib/Command/SyncContact.php +++ b/lib/Command/SyncContact.php @@ -38,7 +38,6 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; - /** * Class SyncContact * @@ -161,6 +160,4 @@ class SyncContact extends Base { private function displayStatus(OutputInterface $output) { $output->writeln('not yet available'); } - } - diff --git a/lib/Controller/AdminController.php b/lib/Controller/AdminController.php index 95f377f6..30aa1208 100644 --- a/lib/Controller/AdminController.php +++ b/lib/Controller/AdminController.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Controller; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use Exception; @@ -57,15 +56,12 @@ use OCP\AppFramework\OCSController; use OCP\IRequest; use OCP\IUserSession; - /** * Class AdminController * * @package OCA\Circles\Controller */ class AdminController extends OcsController { - - use TNC22Deserialize; use TNC22Logger; @@ -152,11 +148,11 @@ class AdminController extends OcsController { } catch (Exception $e) { $this->e( $e, [ - 'emulated' => $emulated, - 'name' => $name, - 'members' => $personal, - 'local' => $local - ] + 'emulated' => $emulated, + 'name' => $name, + 'members' => $personal, + 'local' => $local + ] ); throw new OcsException($e->getMessage(), $e->getCode()); } @@ -213,11 +209,11 @@ class AdminController extends OcsController { } catch (Exception $e) { $this->e( $e, [ - 'emulated' => $emulated, - 'circleId' => $circleId, - 'userId' => $userId, - 'type' => $type - ] + 'emulated' => $emulated, + 'circleId' => $circleId, + 'userId' => $userId, + 'type' => $type + ] ); throw new OCSException($e->getMessage(), $e->getCode()); } @@ -253,7 +249,7 @@ class AdminController extends OcsController { 'emulated' => $emulated, 'circleId' => $circleId, 'memberId' => $memberId, - 'level' => $level + 'level' => $level ] ); throw new OcsException($e->getMessage(), $e->getCode()); @@ -532,6 +528,4 @@ class AdminController extends OcsController { $this->federatedUserService->setCurrentPatron($user->getUID()); $this->federatedUserService->setLocalCurrentUserId($emulated); } - } - diff --git a/lib/Controller/EventWrapperController.php b/lib/Controller/EventWrapperController.php index 2638e562..fb061636 100644 --- a/lib/Controller/EventWrapperController.php +++ b/lib/Controller/EventWrapperController.php @@ -1,4 +1,6 @@ -fail(['data' => $data, 'error' => $e->getMessage()]); // } // } - } - diff --git a/lib/Controller/LocalController.php b/lib/Controller/LocalController.php index 1bba8d82..ff4873aa 100644 --- a/lib/Controller/LocalController.php +++ b/lib/Controller/LocalController.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Controller; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use Exception; @@ -55,15 +54,12 @@ use OCP\AppFramework\OCSController; use OCP\IRequest; use OCP\IUserSession; - /** * Class LocalController * * @package OCA\Circles\Controller */ class LocalController extends OcsController { - - use TNC22Deserialize; use TNC22Logger; @@ -278,7 +274,6 @@ class LocalController extends OcsController { $this->e($e, ['circleId' => $circleId, 'members' => $members]); throw new OCSException($e->getMessage(), $e->getCode()); } - } @@ -576,6 +571,4 @@ class LocalController extends OcsController { $user = $this->userSession->getUser(); $this->federatedUserService->setLocalCurrentUser($user); } - } - diff --git a/lib/Controller/RemoteController.php b/lib/Controller/RemoteController.php index 9bc40110..ee863907 100644 --- a/lib/Controller/RemoteController.php +++ b/lib/Controller/RemoteController.php @@ -67,15 +67,12 @@ use OCP\AppFramework\Http; use OCP\AppFramework\Http\DataResponse; use OCP\IRequest; - /** * Class RemoteController * * @package OCA\Circles\Controller */ class RemoteController extends Controller { - - use TNC22Controller; use TNC22LocalSignatory; use TNC22Deserialize; @@ -339,9 +336,9 @@ class RemoteController extends Controller { // FILTER CIRCLE BASED ON THE CONFIG/FEDERATED_8192 !! if ($type === Member::$TYPE[Member::TYPE_SINGLE]) { $federatedUser = $this->federatedUserService->getFederatedUser($userId, Member::TYPE_SINGLE); - } else if ($type === Member::$TYPE[Member::TYPE_CIRCLE]) { + } elseif ($type === Member::$TYPE[Member::TYPE_CIRCLE]) { $federatedUser = $this->federatedUserService->getFederatedUser($userId, Member::TYPE_CIRCLE); - } else if ($type === Member::$TYPE[Member::TYPE_USER]) { + } elseif ($type === Member::$TYPE[Member::TYPE_USER]) { $federatedUser = $this->federatedUserService->getLocalFederatedUser($userId); } else { throw new FederatedUserNotFoundException('Entity not found'); @@ -471,11 +468,9 @@ class RemoteController extends Controller { return new DataResponse( [ 'message' => $e->getMessage(), - 'code' => $e->getCode() + 'code' => $e->getCode() ], ($e->getCode() > 0) ? $e->getCode() : $httpErrorCode ); } - } - diff --git a/lib/Cron/ContactsExistingShares.php b/lib/Cron/ContactsExistingShares.php index 81422a57..7362cf17 100644 --- a/lib/Cron/ContactsExistingShares.php +++ b/lib/Cron/ContactsExistingShares.php @@ -1,4 +1,6 @@ -synchronize($circles); } - } - diff --git a/lib/Cron/Maintenance.php b/lib/Cron/Maintenance.php index 3744f93c..98588df4 100644 --- a/lib/Cron/Maintenance.php +++ b/lib/Cron/Maintenance.php @@ -1,4 +1,6 @@ - 60, // every minute 2 => 300, // every 5 minutes @@ -141,6 +141,4 @@ class Maintenance extends TimedJob { return ($timeLastRun + self::$DELAY[$level] < $now); } - } - diff --git a/lib/Db/AccountsRequest.php b/lib/Db/AccountsRequest.php index 1e362e46..8044af5f 100644 --- a/lib/Db/AccountsRequest.php +++ b/lib/Db/AccountsRequest.php @@ -27,13 +27,10 @@ namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Exceptions\MemberDoesNotExistException; class AccountsRequest extends AccountsRequestBuilder { - - use TStringTools; @@ -76,5 +73,4 @@ class AccountsRequest extends AccountsRequestBuilder { return $accounts; } - } diff --git a/lib/Db/AccountsRequestBuilder.php b/lib/Db/AccountsRequestBuilder.php index 049dc45d..e6b5d386 100644 --- a/lib/Db/AccountsRequestBuilder.php +++ b/lib/Db/AccountsRequestBuilder.php @@ -28,19 +28,15 @@ namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * Class AccountsRequestBuilder * * @package OCA\Circles\Db */ class AccountsRequestBuilder extends DeprecatedRequestBuilder { - - use TArrayTools; @@ -111,10 +107,8 @@ class AccountsRequestBuilder extends DeprecatedRequestBuilder { } return [ - 'userId' => $entry['uid'], + 'userId' => $entry['uid'], 'displayName' => $this->get('displayname.value', $data) ]; } - } - diff --git a/lib/Db/CircleProviderRequest.php b/lib/Db/CircleProviderRequest.php index 1e64d598..209d321d 100644 --- a/lib/Db/CircleProviderRequest.php +++ b/lib/Db/CircleProviderRequest.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\GSStatusException; /** @@ -49,7 +48,6 @@ class CircleProviderRequest extends CircleProviderRequestBuilder { * @throws GSStatusException */ public function getFilesForCircles($userId, $circleUniqueIds, $limit, $offset) { - $qb = $this->getCompleteSelectSql(); $this->linkToFileCache($qb, $userId); $this->limitToPage($qb, $limit, $offset); @@ -102,5 +100,4 @@ class CircleProviderRequest extends CircleProviderRequestBuilder { $data['file_target'] = $data['parent_target']; } } - } diff --git a/lib/Db/CircleProviderRequestBuilder.php b/lib/Db/CircleProviderRequestBuilder.php index bb5505fe..b401151f 100644 --- a/lib/Db/CircleProviderRequestBuilder.php +++ b/lib/Db/CircleProviderRequestBuilder.php @@ -30,7 +30,6 @@ namespace OCA\Circles\Db; - use Doctrine\DBAL\Query\QueryBuilder; use OC; use OCA\Circles\Model\DeprecatedMember; @@ -57,7 +56,6 @@ class CircleProviderRequestBuilder extends DeprecatedRequestBuilder { * @return IQueryBuilder */ protected function findShareParentSql($fileId, $circleId) { - $qb = $this->getBaseSelectSql(); $this->limitToShareParent($qb); $this->limitToCircles($qb, [$circleId]); @@ -74,9 +72,8 @@ class CircleProviderRequestBuilder extends DeprecatedRequestBuilder { * @param array $circleUniqueIds */ protected function limitToCircles(IQueryBuilder $qb, $circleUniqueIds) { - if (!is_array($circleUniqueIds)) { - $circleUniqueIds = array($circleUniqueIds); + $circleUniqueIds = [$circleUniqueIds]; } $expr = $qb->expr(); @@ -162,9 +159,8 @@ class CircleProviderRequestBuilder extends DeprecatedRequestBuilder { * @param $files */ protected function limitToFiles(IQueryBuilder $qb, $files) { - if (!is_array($files)) { - $files = array($files); + $files = [$files]; } $expr = $qb->expr(); @@ -327,7 +323,6 @@ class CircleProviderRequestBuilder extends DeprecatedRequestBuilder { private function exprLinkToMemberAsGroupMember( IQueryBuilder $qb, string $userId, string $aliasM, string $aliasC ) { - $expr = $qb->expr(); $qb->leftJoin( $aliasM, self::NC_TABLE_GROUP_USER, 'ncgu', @@ -386,7 +381,6 @@ class CircleProviderRequestBuilder extends DeprecatedRequestBuilder { $qb->selectAlias('s2.id', 'parent_id'); $qb->selectAlias('s2.file_target', 'parent_target'); $qb->selectAlias('s2.permissions', 'parent_perms'); - } diff --git a/lib/Db/CircleRequest.php b/lib/Db/CircleRequest.php index 2b5bce4c..3b908f53 100644 --- a/lib/Db/CircleRequest.php +++ b/lib/Db/CircleRequest.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Exceptions\FederatedUserNotFoundException; @@ -45,7 +44,6 @@ use OCA\Circles\Model\Federated\RemoteInstance; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; - /** * Class CircleRequest * @@ -174,8 +172,8 @@ class CircleRequest extends CircleRequestBuilder { $qb->setOptions( [CoreQueryBuilder::CIRCLE], [ - 'getData' => true, - 'mustBeMember' => $params->gBool('mustBeMember'), + 'getData' => true, + 'mustBeMember' => $params->gBool('mustBeMember'), 'initiatorDirectMember' => true ] ); @@ -243,8 +241,8 @@ class CircleRequest extends CircleRequestBuilder { $qb->setOptions( [CoreQueryBuilder::CIRCLE], [ - 'getData' => true, - 'canBeVisitor' => true, + 'getData' => true, + 'canBeVisitor' => true, 'initiatorDirectMember' => true ] ); @@ -404,6 +402,4 @@ class CircleRequest extends CircleRequestBuilder { $qb->execute(); } - } - diff --git a/lib/Db/CircleRequestBuilder.php b/lib/Db/CircleRequestBuilder.php index cff58cb3..d0cb5f58 100644 --- a/lib/Db/CircleRequestBuilder.php +++ b/lib/Db/CircleRequestBuilder.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Model\Circle; - /** * Class CircleRequestBuilder * @@ -122,5 +120,4 @@ class CircleRequestBuilder extends CoreRequestBuilder { /** @var Circle[] $result */ return $qb->asItems(Circle::class); } - } diff --git a/lib/Db/CoreQueryBuilder.php b/lib/Db/CoreQueryBuilder.php index b9ae6d7d..68596e88 100644 --- a/lib/Db/CoreQueryBuilder.php +++ b/lib/Db/CoreQueryBuilder.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\NC22ExtendedQueryBuilder; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use Doctrine\DBAL\Query\QueryBuilder; @@ -47,90 +46,87 @@ use OCA\Circles\Service\ConfigService; use OCP\DB\QueryBuilder\ICompositeExpression; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * Class CoreQueryBuilder * * @package OCA\Circles\Db */ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { - - use TArrayTools; - const SINGLE = 'single'; - const CIRCLE = 'circle'; - const MEMBER = 'member'; - const MEMBER_COUNT = 'membercount'; - const OWNER = 'owner'; - const FEDERATED_EVENT = 'federatedevent'; - const REMOTE = 'remote'; - const BASED_ON = 'basedon'; - const INITIATOR = 'initiator'; - const DIRECT_INITIATOR = 'initiatordirect'; - const MEMBERSHIPS = 'memberships'; - const CONFIG = 'config'; - const UPSTREAM_MEMBERSHIPS = 'upstreammemberships'; - const INHERITANCE_FROM = 'inheritancefrom'; - const INHERITED_BY = 'inheritedby'; - const INVITED_BY = 'invitedby'; - const MOUNT = 'mount'; - const MOUNTPOINT = 'mountpoint'; - const SHARE = 'share'; - const FILE_CACHE = 'filecache'; - const STORAGES = 'storages'; - const TOKEN = 'token'; - const OPTIONS = 'options'; - const HELPER = 'circleshelper'; + public const SINGLE = 'single'; + public const CIRCLE = 'circle'; + public const MEMBER = 'member'; + public const MEMBER_COUNT = 'membercount'; + public const OWNER = 'owner'; + public const FEDERATED_EVENT = 'federatedevent'; + public const REMOTE = 'remote'; + public const BASED_ON = 'basedon'; + public const INITIATOR = 'initiator'; + public const DIRECT_INITIATOR = 'initiatordirect'; + public const MEMBERSHIPS = 'memberships'; + public const CONFIG = 'config'; + public const UPSTREAM_MEMBERSHIPS = 'upstreammemberships'; + public const INHERITANCE_FROM = 'inheritancefrom'; + public const INHERITED_BY = 'inheritedby'; + public const INVITED_BY = 'invitedby'; + public const MOUNT = 'mount'; + public const MOUNTPOINT = 'mountpoint'; + public const SHARE = 'share'; + public const FILE_CACHE = 'filecache'; + public const STORAGES = 'storages'; + public const TOKEN = 'token'; + public const OPTIONS = 'options'; + public const HELPER = 'circleshelper'; public static $SQL_PATH = [ - self::SINGLE => [ + self::SINGLE => [ self::MEMBER ], - self::CIRCLE => [ - self::OPTIONS => [ + self::CIRCLE => [ + self::OPTIONS => [ ], self::MEMBER, self::MEMBER_COUNT, - self::OWNER => [ + self::OWNER => [ self::BASED_ON ], - self::MEMBERSHIPS => [ + self::MEMBERSHIPS => [ self::CONFIG ], self::DIRECT_INITIATOR => [ self::BASED_ON ], - self::INITIATOR => [ + self::INITIATOR => [ self::BASED_ON, self::INHERITED_BY => [ self::MEMBERSHIPS ] ], - self::REMOTE => [ + self::REMOTE => [ self::MEMBER, self::CIRCLE => [ self::OWNER ] ] ], - self::MEMBER => [ + self::MEMBER => [ self::MEMBERSHIPS => [ self::CONFIG ], self::INHERITANCE_FROM, - self::CIRCLE => [ - self::OPTIONS => [ + self::CIRCLE => [ + self::OPTIONS => [ 'getData' => true ], self::OWNER, self::MEMBERSHIPS => [ self::CONFIG ], - self::INITIATOR => [ - self::OPTIONS => [ + self::INITIATOR => [ + self::OPTIONS => [ 'mustBeMember' => true, 'canBeVisitor' => false ], @@ -138,13 +134,13 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { self::INHERITED_BY => [ self::MEMBERSHIPS ], - self::INVITED_BY => [ + self::INVITED_BY => [ self::OWNER, self::BASED_ON ] ] ], - self::BASED_ON => [ + self::BASED_ON => [ self::OWNER, self::MEMBERSHIPS, self::INITIATOR => [ @@ -154,13 +150,13 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { ] ] ], - self::REMOTE => [ + self::REMOTE => [ self::MEMBER, self::CIRCLE => [ self::OWNER ] ], - self::INVITED_BY => [ + self::INVITED_BY => [ self::OWNER, self::BASED_ON ] @@ -168,10 +164,10 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { self::MEMBERSHIPS => [ self::CONFIG ], - self::SHARE => [ + self::SHARE => [ self::SHARE, self::TOKEN, - self::FILE_CACHE => [ + self::FILE_CACHE => [ self::STORAGES ], self::UPSTREAM_MEMBERSHIPS => [ @@ -181,31 +177,31 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { ], self::SHARE, ], - self::MEMBERSHIPS => [ + self::MEMBERSHIPS => [ self::CONFIG ], self::INHERITANCE_FROM, - self::INHERITED_BY => [ + self::INHERITED_BY => [ self::BASED_ON ], - self::CIRCLE => [ + self::CIRCLE => [ self::OWNER ], - self::INITIATOR => [ + self::INITIATOR => [ self::BASED_ON, self::INHERITED_BY => [ self::MEMBERSHIPS ] ] ], - self::REMOTE => [ + self::REMOTE => [ self::MEMBER ], - self::MOUNT => [ - self::MEMBER => [ + self::MOUNT => [ + self::MEMBER => [ self::REMOTE ], - self::INITIATOR => [ + self::INITIATOR => [ self::INHERITED_BY => [ self::MEMBERSHIPS ] @@ -215,20 +211,20 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { self::CONFIG ] ], - self::HELPER => [ + self::HELPER => [ self::MEMBERSHIPS => [ self::CONFIG ], - self::INITIATOR => [ + self::INITIATOR => [ self::INHERITED_BY => [ self::MEMBERSHIPS ] ], - self::CIRCLE => [ + self::CIRCLE => [ self::OPTIONS => [ ], self::MEMBER, - self::OWNER => [ + self::OWNER => [ self::BASED_ON ] ] @@ -437,7 +433,6 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { bool $filterSensitiveData = true, string $aliasCircle = '' ): void { - if ($aliasCircle === '') { $aliasCircle = $alias; } @@ -1215,11 +1210,11 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { $default = []; if ($this->getBool('canBeVisitor', $options, false)) { $default = [ - 'user_id' => $initiator->getUserId(), - 'single_id' => $initiator->getSingleId(), - 'user_type' => $initiator->getUserType(), + 'user_id' => $initiator->getUserId(), + 'single_id' => $initiator->getSingleId(), + 'user_type' => $initiator->getUserType(), 'cached_name' => $initiator->getDisplayName(), - 'instance' => $initiator->getInstance() + 'instance' => $initiator->getInstance() ]; } $aliasInheritedByMembership = $this->generateAlias($aliasInheritedBy, self::MEMBERSHIPS); @@ -1649,6 +1644,4 @@ class CoreQueryBuilder extends NC22ExtendedQueryBuilder { return $orX; } - } - diff --git a/lib/Db/CoreRequestBuilder.php b/lib/Db/CoreRequestBuilder.php index 173e77cc..41a5cea7 100644 --- a/lib/Db/CoreRequestBuilder.php +++ b/lib/Db/CoreRequestBuilder.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use Exception; use OC\DB\Connection; use OC\DB\SchemaWrapper; @@ -40,40 +39,37 @@ use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\TimezoneService; use OCP\Share\IShare; - /** * Class CoreQueryBuilder * * @package OCA\Circles\Db */ class CoreRequestBuilder { + public const TABLE_SHARE = 'share'; + public const TABLE_FILE_CACHE = 'filecache'; + public const TABLE_STORAGES = 'storages'; - - const TABLE_SHARE = 'share'; - const TABLE_FILE_CACHE = 'filecache'; - const TABLE_STORAGES = 'storages'; - - const TABLE_CIRCLE = 'circles_circle'; - const TABLE_MEMBER = 'circles_member'; - const TABLE_MEMBERSHIP = 'circles_membership'; - const TABLE_REMOTE = 'circles_remote'; - const TABLE_EVENT = 'circles_event'; - const TABLE_MOUNT = 'circles_mount'; - const TABLE_MOUNTPOINT = 'circles_mountpoint'; + public const TABLE_CIRCLE = 'circles_circle'; + public const TABLE_MEMBER = 'circles_member'; + public const TABLE_MEMBERSHIP = 'circles_membership'; + public const TABLE_REMOTE = 'circles_remote'; + public const TABLE_EVENT = 'circles_event'; + public const TABLE_MOUNT = 'circles_mount'; + public const TABLE_MOUNTPOINT = 'circles_mountpoint'; // wip - const TABLE_SHARE_LOCK = 'circles_share_lock'; - const TABLE_TOKEN = 'circles_token'; + public const TABLE_SHARE_LOCK = 'circles_share_lock'; + public const TABLE_TOKEN = 'circles_token'; - const TABLE_GSSHARES = 'circle_gsshares'; // rename ? - const TABLE_GSSHARES_MOUNTPOINT = 'circle_gsshares_mp'; // rename ? + public const TABLE_GSSHARES = 'circle_gsshares'; // rename ? + public const TABLE_GSSHARES_MOUNTPOINT = 'circle_gsshares_mp'; // rename ? - const NC_TABLE_ACCOUNTS = 'accounts'; - const NC_TABLE_GROUP_USER = 'group_user'; + public const NC_TABLE_ACCOUNTS = 'accounts'; + public const NC_TABLE_GROUP_USER = 'group_user'; /** @var array */ - static $tables = [ - self::TABLE_CIRCLE => [ + public static $tables = [ + self::TABLE_CIRCLE => [ 'unique_id', 'name', 'display_name', @@ -86,7 +82,7 @@ class CoreRequestBuilder { 'contact_groupname', 'creation' ], - self::TABLE_MEMBER => [ + self::TABLE_MEMBER => [ 'circle_id', 'member_id', 'single_id', @@ -102,7 +98,7 @@ class CoreRequestBuilder { 'contact_meta', 'joined' ], - self::TABLE_MEMBERSHIP => [ + self::TABLE_MEMBERSHIP => [ 'single_id', 'circle_id', 'level', @@ -111,7 +107,7 @@ class CoreRequestBuilder { 'inheritance_path', 'inheritance_depth' ], - self::TABLE_REMOTE => [ + self::TABLE_REMOTE => [ 'id', 'type', 'interface', @@ -121,7 +117,7 @@ class CoreRequestBuilder { 'item', 'creation' ], - self::TABLE_EVENT => [ + self::TABLE_EVENT => [ 'token', 'event', 'result', @@ -132,7 +128,7 @@ class CoreRequestBuilder { 'status', 'creation' ], - self::TABLE_MOUNT => [ + self::TABLE_MOUNT => [ 'id', 'mount_id', 'circle_id', @@ -142,9 +138,9 @@ class CoreRequestBuilder { 'mountpoint', 'mountpoint_hash' ], - self::TABLE_MOUNTPOINT => [], - self::TABLE_SHARE_LOCK => [], - self::TABLE_TOKEN => [ + self::TABLE_MOUNTPOINT => [], + self::TABLE_SHARE_LOCK => [], + self::TABLE_TOKEN => [ 'id', 'share_id', 'circle_id', @@ -154,13 +150,13 @@ class CoreRequestBuilder { 'password', 'accepted' ], - self::TABLE_GSSHARES => [], + self::TABLE_GSSHARES => [], self::TABLE_GSSHARES_MOUNTPOINT => [] ]; - static $outsideTables = [ - self::TABLE_SHARE => [ + public static $outsideTables = [ + self::TABLE_SHARE => [ 'id', 'share_type', 'share_with', @@ -197,7 +193,7 @@ class CoreRequestBuilder { 'etag', 'checksum' ], - self::TABLE_STORAGES => [ + self::TABLE_STORAGES => [ 'id' ] ]; @@ -320,6 +316,4 @@ class CoreRequestBuilder { // $qb->where($this->exprLimitToDBField($qb, 'class', 'OCA\Circles\', true, true)); // $qb->execute(); } - } - diff --git a/lib/Db/DeprecatedCirclesRequest.php b/lib/Db/DeprecatedCirclesRequest.php index e54b3c21..67cee506 100644 --- a/lib/Db/DeprecatedCirclesRequest.php +++ b/lib/Db/DeprecatedCirclesRequest.php @@ -1,4 +1,6 @@ -getCirclesSelectSql(); $this->limitToName($qb, $name); @@ -236,7 +236,6 @@ class DeprecatedCirclesRequest extends DeprecatedCirclesRequestBuilder { * @param DeprecatedCircle $circle */ public function createCircle(DeprecatedCircle $circle) { - $config = DeprecatedCircle::convertTypeToConfig($circle->getType()); $qb = $this->getCirclesInsertSql(); @@ -437,5 +436,4 @@ class DeprecatedCirclesRequest extends DeprecatedCirclesRequestBuilder { return $this->parseCirclesSelectSql($data); } - } diff --git a/lib/Db/DeprecatedCirclesRequestBuilder.php b/lib/Db/DeprecatedCirclesRequestBuilder.php index cd26900e..1636ab79 100644 --- a/lib/Db/DeprecatedCirclesRequestBuilder.php +++ b/lib/Db/DeprecatedCirclesRequestBuilder.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Db; - use Doctrine\DBAL\Query\QueryBuilder; use OCA\Circles\Exceptions\ConfigNoCircleAvailableException; use OCA\Circles\Model\DeprecatedCircle; @@ -275,7 +274,6 @@ class DeprecatedCirclesRequestBuilder extends DeprecatedRequestBuilder { * @param string $ownerId */ public function leftJoinOwner(IQueryBuilder $qb, string $ownerId = '') { - if ($qb->getType() !== QueryBuilder::SELECT) { return; } @@ -385,7 +383,6 @@ class DeprecatedCirclesRequestBuilder extends DeprecatedRequestBuilder { * @return DeprecatedCircle */ protected function parseCirclesSelectSql($data, bool $allSettings = false) { - $circle = new DeprecatedCircle(); $circle->setId($data['id']); $circle->setUniqueId($data['unique_id']); @@ -425,6 +422,4 @@ class DeprecatedCirclesRequestBuilder extends DeprecatedRequestBuilder { return $circle; } - - } diff --git a/lib/Db/DeprecatedMembersRequest.php b/lib/Db/DeprecatedMembersRequest.php index a48e98b9..c452bf46 100644 --- a/lib/Db/DeprecatedMembersRequest.php +++ b/lib/Db/DeprecatedMembersRequest.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Doctrine\DBAL\Exception\UniqueConstraintViolationException; use Exception; @@ -38,8 +37,6 @@ use OCA\Circles\Model\DeprecatedMember; use OCP\IGroup; class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { - - use TStringTools; @@ -159,7 +156,6 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { * @return DeprecatedMember[] */ public function forceGetAllMembers() { - $qb = $this->getMembersSelectSql(); $members = []; @@ -231,7 +227,7 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { if ($force === false) { if (!$viewer->isLevel(DeprecatedMember::LEVEL_MODERATOR)) { array_map( - function(DeprecatedMember $m) { + function (DeprecatedMember $m) { $m->setNote(''); }, $members ); @@ -309,7 +305,7 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { $index = $this->indexOfMember($members, $member->getUserId()); if ($index === -1) { array_push($members, $member); - } else if ($members[$index]->getLevel() < $member->getLevel()) { + } elseif ($members[$index]->getLevel() < $member->getLevel()) { $members[$index] = $member; } } @@ -325,7 +321,6 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { * @return int */ private function indexOfMember(array $members, $userId) { - foreach ($members as $k => $member) { if ($member->getUserId() === $userId) { return intval($k); @@ -348,7 +343,6 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { * @return DeprecatedMember */ public function getFreshNewMember($circleUniqueId, string $name, int $type, string $instance) { - try { $member = $this->forceGetMember($circleUniqueId, $name, $type, $instance); } catch (MemberDoesNotExistException $e) { @@ -473,7 +467,6 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { * @throws MemberAlreadyExistsException */ public function createMember(DeprecatedMember $member) { - if ($member->getMemberId() === '') { $member->setMemberId($this->token(14)); } @@ -785,6 +778,4 @@ class DeprecatedMembersRequest extends DeprecatedMembersRequestBuilder { $qb->execute(); } - - } diff --git a/lib/Db/DeprecatedMembersRequestBuilder.php b/lib/Db/DeprecatedMembersRequestBuilder.php index d52637ad..561e3bd3 100644 --- a/lib/Db/DeprecatedMembersRequestBuilder.php +++ b/lib/Db/DeprecatedMembersRequestBuilder.php @@ -28,7 +28,6 @@ namespace OCA\Circles\Db; - use OCA\Circles\Model\DeprecatedMember; use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\MiscService; @@ -188,5 +187,4 @@ class DeprecatedMembersRequestBuilder extends DeprecatedRequestBuilder { return $member; } - } diff --git a/lib/Db/DeprecatedRequestBuilder.php b/lib/Db/DeprecatedRequestBuilder.php index c85aea04..54a9a178 100644 --- a/lib/Db/DeprecatedRequestBuilder.php +++ b/lib/Db/DeprecatedRequestBuilder.php @@ -8,7 +8,6 @@ namespace OCA\Circles\Db; - use Doctrine\DBAL\Query\QueryBuilder; use OCA\Circles\Exceptions\GSStatusException; use OCA\Circles\Model\DeprecatedMember; @@ -20,23 +19,22 @@ use OCP\IDBConnection; use OCP\IL10N; class DeprecatedRequestBuilder { + public const TABLE_FILE_SHARES = 'share'; + public const SHARE_TYPE = 7; - const TABLE_FILE_SHARES = 'share'; - const SHARE_TYPE = 7; + public const TABLE_CIRCLES = 'circle_circles'; + public const TABLE_MEMBERS = 'circle_members'; + public const TABLE_GROUPS = 'circle_groups'; + public const TABLE_SHARES = 'circle_shares'; + public const TABLE_LINKS = 'circle_links'; + public const TABLE_TOKENS = 'circle_tokens'; + public const TABLE_GSEVENTS = 'circle_gsevents'; + public const TABLE_GSSHARES = 'circle_gsshares'; + public const TABLE_GSSHARES_MOUNTPOINT = 'circle_gsshares_mp'; + public const TABLE_REMOTE = 'circle_remotes'; - const TABLE_CIRCLES = 'circle_circles'; - const TABLE_MEMBERS = 'circle_members'; - const TABLE_GROUPS = 'circle_groups'; - const TABLE_SHARES = 'circle_shares'; - const TABLE_LINKS = 'circle_links'; - const TABLE_TOKENS = 'circle_tokens'; - const TABLE_GSEVENTS = 'circle_gsevents'; - const TABLE_GSSHARES = 'circle_gsshares'; - const TABLE_GSSHARES_MOUNTPOINT = 'circle_gsshares_mp'; - const TABLE_REMOTE = 'circle_remotes'; - - const NC_TABLE_ACCOUNTS = 'accounts'; - const NC_TABLE_GROUP_USER = 'group_user'; + public const NC_TABLE_ACCOUNTS = 'accounts'; + public const NC_TABLE_GROUP_USER = 'group_user'; /** @var array */ private $tables = [ @@ -512,8 +510,4 @@ class DeprecatedRequestBuilder { $this->leftJoinedNCGroupAndUser = true; } - } - - - diff --git a/lib/Db/EventWrapperRequest.php b/lib/Db/EventWrapperRequest.php index ef9cc3f7..c1d92789 100644 --- a/lib/Db/EventWrapperRequest.php +++ b/lib/Db/EventWrapperRequest.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Model\Federated\EventWrapper; - /** * Class EventWrapperRequest * @@ -121,6 +119,4 @@ class EventWrapperRequest extends EventWrapperRequestBuilder { return $this->getItemsFromRequest($qb); } - } - diff --git a/lib/Db/EventWrapperRequestBuilder.php b/lib/Db/EventWrapperRequestBuilder.php index b77a70e3..3f5c5cc9 100644 --- a/lib/Db/EventWrapperRequestBuilder.php +++ b/lib/Db/EventWrapperRequestBuilder.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\EventWrapperNotFoundException; use OCA\Circles\Model\Federated\EventWrapper; - /** * Class GSEventsRequestBuilder * @@ -120,6 +118,4 @@ class EventWrapperRequestBuilder extends CoreRequestBuilder { /** @var EventWrapper[] $result */ return $qb->asItems(EventWrapper::class); } - } - diff --git a/lib/Db/FederatedLinksRequest.php b/lib/Db/FederatedLinksRequest.php index 02a2086d..9bb94ab3 100644 --- a/lib/Db/FederatedLinksRequest.php +++ b/lib/Db/FederatedLinksRequest.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\FederatedLinkDoesNotExistException; use OCA\Circles\Model\FederatedLink; @@ -68,7 +67,6 @@ class FederatedLinksRequest extends FederatedLinksRequestBuilder { * @param FederatedLink $link */ public function update(FederatedLink $link) { - if ($link->getStatus() === FederatedLink::STATUS_LINK_REMOVE) { $this->delete($link); @@ -92,7 +90,6 @@ class FederatedLinksRequest extends FederatedLinksRequestBuilder { * @param FederatedLink $link */ public function delete(FederatedLink $link) { - if ($link === null) { return; } @@ -225,6 +222,4 @@ class FederatedLinksRequest extends FederatedLinksRequestBuilder { return $this->parseLinksSelectSql($data); } - - } diff --git a/lib/Db/FederatedLinksRequestBuilder.php b/lib/Db/FederatedLinksRequestBuilder.php index 40efcce9..276aedf8 100644 --- a/lib/Db/FederatedLinksRequestBuilder.php +++ b/lib/Db/FederatedLinksRequestBuilder.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Db; - use OCA\Circles\Model\FederatedLink; use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\MiscService; @@ -36,7 +35,6 @@ use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\IDBConnection; use OCP\IL10N; - /** * @deprecated * Class FederatedLinksRequestBuilder @@ -134,5 +132,4 @@ class FederatedLinksRequestBuilder extends DeprecatedRequestBuilder { return $link; } - } diff --git a/lib/Db/FileSharesRequest.php b/lib/Db/FileSharesRequest.php index 037647ef..23de882f 100644 --- a/lib/Db/FileSharesRequest.php +++ b/lib/Db/FileSharesRequest.php @@ -27,10 +27,8 @@ namespace OCA\Circles\Db; - use OCA\Circles\Model\DeprecatedMember; - /** * @deprecated * Class SharesRequest @@ -117,6 +115,4 @@ class FileSharesRequest extends FileSharesRequestBuilder { return $shares; } - } - diff --git a/lib/Db/FileSharesRequestBuilder.php b/lib/Db/FileSharesRequestBuilder.php index 61c4c48c..163cdff5 100644 --- a/lib/Db/FileSharesRequestBuilder.php +++ b/lib/Db/FileSharesRequestBuilder.php @@ -27,10 +27,8 @@ namespace OCA\Circles\Db; - use OCP\DB\QueryBuilder\IQueryBuilder; - /** * @deprecated * Class FileSharesRequestBuilder @@ -92,6 +90,4 @@ class FileSharesRequestBuilder extends DeprecatedRequestBuilder { return $qb; } - - } diff --git a/lib/Db/GSSharesRequest.php b/lib/Db/GSSharesRequest.php index 8e707508..c0054e67 100644 --- a/lib/Db/GSSharesRequest.php +++ b/lib/Db/GSSharesRequest.php @@ -27,7 +27,6 @@ namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Model\GlobalScale\GSShare; use OCA\Circles\Model\GlobalScale\GSShareMountpoint; @@ -35,7 +34,6 @@ use OCA\Circles\Model\DeprecatedMember; use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\Share\Exceptions\ShareNotFound; - /** * @deprecated * Class GSSharesRequest @@ -43,8 +41,6 @@ use OCP\Share\Exceptions\ShareNotFound; * @package OCA\Circles\Db */ class GSSharesRequest extends GSSharesRequestBuilder { - - use TStringTools; @@ -219,8 +215,4 @@ class GSSharesRequest extends GSSharesRequestBuilder { return ($nb === 1); } - - - } - diff --git a/lib/Db/GSSharesRequestBuilder.php b/lib/Db/GSSharesRequestBuilder.php index f816bf8e..625832fe 100644 --- a/lib/Db/GSSharesRequestBuilder.php +++ b/lib/Db/GSSharesRequestBuilder.php @@ -28,14 +28,12 @@ namespace OCA\Circles\Db; - use OCA\Circles\Model\GlobalScale\GSShare; use OCA\Circles\Model\GlobalScale\GSShareMountpoint; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * @deprecated - + * * Class GSSharesRequestBuilder * * @package OCA\Circles\Db @@ -180,5 +178,4 @@ class GSSharesRequestBuilder extends DeprecatedRequestBuilder { return $share; } - } diff --git a/lib/Db/MemberRequest.php b/lib/Db/MemberRequest.php index 612d5505..9051ef9c 100644 --- a/lib/Db/MemberRequest.php +++ b/lib/Db/MemberRequest.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\InvalidIdException; use OCA\Circles\Exceptions\MemberNotFoundException; use OCA\Circles\Exceptions\RequestBuilderException; @@ -41,7 +40,6 @@ use OCA\Circles\Model\Federated\RemoteInstance; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; - /** * Class MemberRequest * @@ -328,7 +326,7 @@ class MemberRequest extends MemberRequestBuilder { $qb->andwhere($qb->expr()->nonEmptyString(CoreQueryBuilder::MEMBER . '.instance')); return array_map( - function(Member $member): string { + function (Member $member): string { return $member->getInstance(); }, $this->getItemsFromRequest($qb) ); @@ -406,6 +404,4 @@ class MemberRequest extends MemberRequestBuilder { return $this->getItemsFromRequest($qb); } - } - diff --git a/lib/Db/MemberRequestBuilder.php b/lib/Db/MemberRequestBuilder.php index d3252460..f61d610c 100644 --- a/lib/Db/MemberRequestBuilder.php +++ b/lib/Db/MemberRequestBuilder.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\MemberNotFoundException; use OCA\Circles\Exceptions\RequestBuilderException; @@ -39,7 +38,6 @@ use OCA\Circles\IFederatedUser; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; - /** * Class MemberRequestBuilder * @@ -144,5 +142,4 @@ class MemberRequestBuilder extends CoreRequestBuilder { /** @var Member|FederatedUser[] $result */ return $qb->asItems($object); } - } diff --git a/lib/Db/MembershipRequest.php b/lib/Db/MembershipRequest.php index 1ec14b69..0d1f5ccd 100644 --- a/lib/Db/MembershipRequest.php +++ b/lib/Db/MembershipRequest.php @@ -31,13 +31,11 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\MembershipNotFoundException; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Membership; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * Class MembershipRequest * @@ -176,6 +174,4 @@ class MembershipRequest extends MembershipRequestBuilder { $qb->execute(); } - } - diff --git a/lib/Db/MembershipRequestBuilder.php b/lib/Db/MembershipRequestBuilder.php index 42488c2c..1363d692 100644 --- a/lib/Db/MembershipRequestBuilder.php +++ b/lib/Db/MembershipRequestBuilder.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\MembershipNotFoundException; use OCA\Circles\Model\Membership; - /** * Class MembershipRequestBuilder * @@ -121,5 +119,4 @@ class MembershipRequestBuilder extends CoreRequestBuilder { /** @var Membership[] $result */ return $qb->asItems(Membership::class); } - } diff --git a/lib/Db/MountRequest.php b/lib/Db/MountRequest.php index b34012aa..f0f064a2 100644 --- a/lib/Db/MountRequest.php +++ b/lib/Db/MountRequest.php @@ -31,21 +31,17 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Exceptions\RequestBuilderException; use OCA\Circles\IFederatedUser; use OCA\Circles\Model\Mount; - /** * Class GSSharesRequest * * @package OCA\Circles\Db */ class MountRequest extends MountRequestBuilder { - - use TStringTools; @@ -288,7 +284,4 @@ class MountRequest extends MountRequestBuilder { // return ($nb === 1); // } // - - } - diff --git a/lib/Db/MountRequestBuilder.php b/lib/Db/MountRequestBuilder.php index 31faac45..0625dbb7 100644 --- a/lib/Db/MountRequestBuilder.php +++ b/lib/Db/MountRequestBuilder.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\MountNotFoundException; use OCA\Circles\Model\Mount; - /** * Class MountRequestBuilder * @@ -117,6 +115,4 @@ class MountRequestBuilder extends CoreRequestBuilder { /** @var Mount[] $result */ return $qb->asItems(Mount::class); } - } - diff --git a/lib/Db/RemoteRequest.php b/lib/Db/RemoteRequest.php index 8a2e2683..a6d3fd19 100644 --- a/lib/Db/RemoteRequest.php +++ b/lib/Db/RemoteRequest.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\RemoteNotFoundException; use OCA\Circles\Exceptions\RemoteUidException; use OCA\Circles\Exceptions\RequestBuilderException; @@ -40,7 +39,6 @@ use OCA\Circles\Model\Federated\RemoteInstance; use OCA\Circles\Model\Member; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * Class RemoteRequest * @@ -289,7 +287,4 @@ class RemoteRequest extends RemoteRequestBuilder { $qb->limitToId($remoteInstance->getDbId()); $qb->execute(); } - - } - diff --git a/lib/Db/RemoteRequestBuilder.php b/lib/Db/RemoteRequestBuilder.php index 719742a7..d178ffcf 100644 --- a/lib/Db/RemoteRequestBuilder.php +++ b/lib/Db/RemoteRequestBuilder.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\RemoteNotFoundException; use OCA\Circles\Model\Federated\RemoteInstance; - /** * Class RemoteRequestBuilder * @@ -122,6 +120,4 @@ class RemoteRequestBuilder extends CoreRequestBuilder { /** @var RemoteInstance[] $result */ return $qb->asItems(RemoteInstance::class); } - } - diff --git a/lib/Db/ShareLockRequest.php b/lib/Db/ShareLockRequest.php index 26e3e692..d1301da5 100644 --- a/lib/Db/ShareLockRequest.php +++ b/lib/Db/ShareLockRequest.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\FederatedShareNotFoundException; use OCA\Circles\Exceptions\InvalidIdException; use OCA\Circles\Model\Federated\FederatedShare; - /** * Class ShareRequest * @@ -79,6 +77,4 @@ class ShareLockRequest extends ShareLockRequestBuilder { return $this->getItemFromRequest($qb); } - } - diff --git a/lib/Db/ShareLockRequestBuilder.php b/lib/Db/ShareLockRequestBuilder.php index 22bcb5c4..10d8ecb8 100644 --- a/lib/Db/ShareLockRequestBuilder.php +++ b/lib/Db/ShareLockRequestBuilder.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\FederatedShareNotFoundException; use OCA\Circles\Model\Federated\FederatedShare; @@ -117,6 +116,4 @@ class ShareLockRequestBuilder extends CoreRequestBuilder { /** @var FederatedShare[] $result */ return $qb->asItems(FederatedShare::class); } - - } diff --git a/lib/Db/ShareTokenRequest.php b/lib/Db/ShareTokenRequest.php index ccf3048a..0815ecec 100644 --- a/lib/Db/ShareTokenRequest.php +++ b/lib/Db/ShareTokenRequest.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\ShareTokenNotFoundException; use OCA\Circles\Model\ShareToken; - /** * Class ShareTokenRequest * @@ -106,6 +104,4 @@ class ShareTokenRequest extends ShareTokenRequestBuilder { $qb->execute(); } - } - diff --git a/lib/Db/ShareTokenRequestBuilder.php b/lib/Db/ShareTokenRequestBuilder.php index 38e84b32..076b2e39 100644 --- a/lib/Db/ShareTokenRequestBuilder.php +++ b/lib/Db/ShareTokenRequestBuilder.php @@ -31,12 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OCA\Circles\Exceptions\ShareTokenNotFoundException; use OCA\Circles\Model\ShareToken; - /** * Class ShareTokenRequestBuilder * @@ -121,6 +119,4 @@ class ShareTokenRequestBuilder extends CoreRequestBuilder { /** @var ShareToken[] $result */ return $qb->asItems(ShareToken::class); } - } - diff --git a/lib/Db/ShareWrapperRequest.php b/lib/Db/ShareWrapperRequest.php index 70bf6ec8..209daf9e 100644 --- a/lib/Db/ShareWrapperRequest.php +++ b/lib/Db/ShareWrapperRequest.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use OCA\Circles\Exceptions\RequestBuilderException; use OCA\Circles\Exceptions\ShareWrapperNotFoundException; use OCA\Circles\Model\FederatedUser; @@ -41,7 +40,6 @@ use OCP\Files\NotFoundException; use OCP\Share\Exceptions\IllegalIDChangeException; use OCP\Share\IShare; - /** * Class ShareWrapperRequest * @@ -452,6 +450,4 @@ class ShareWrapperRequest extends ShareWrapperRequestBuilder { $qb->execute(); } - } - diff --git a/lib/Db/ShareWrapperRequestBuilder.php b/lib/Db/ShareWrapperRequestBuilder.php index f508baa5..ce0a4e84 100644 --- a/lib/Db/ShareWrapperRequestBuilder.php +++ b/lib/Db/ShareWrapperRequestBuilder.php @@ -31,13 +31,11 @@ declare(strict_types=1); namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Exceptions\RowNotFoundException; use OC\Share20\Share; use OCA\Circles\Exceptions\ShareWrapperNotFoundException; use OCA\Circles\Model\ShareWrapper; - /** * Class ShareWrapperRequestBuilder * @@ -124,6 +122,4 @@ class ShareWrapperRequestBuilder extends CoreRequestBuilder { /** @var ShareWrapper[] $result */ return $qb->asItems(ShareWrapper::class); } - } - diff --git a/lib/Db/TokensRequest.php b/lib/Db/TokensRequest.php index a5a537a8..12bac56e 100644 --- a/lib/Db/TokensRequest.php +++ b/lib/Db/TokensRequest.php @@ -27,13 +27,11 @@ namespace OCA\Circles\Db; - use Doctrine\DBAL\Exception\UniqueConstraintViolationException; use OCA\Circles\Exceptions\TokenDoesNotExistException; use OCA\Circles\Model\DeprecatedMember; use OCA\Circles\Model\SharesToken; - /** * @deprecated * Class TokensRequest @@ -179,6 +177,4 @@ class TokensRequest extends TokensRequestBuilder { $qb->execute(); } - } - diff --git a/lib/Db/TokensRequestBuilder.php b/lib/Db/TokensRequestBuilder.php index 65e2e595..2c08f2d6 100644 --- a/lib/Db/TokensRequestBuilder.php +++ b/lib/Db/TokensRequestBuilder.php @@ -28,12 +28,10 @@ namespace OCA\Circles\Db; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use OCA\Circles\Model\SharesToken; use OCP\DB\QueryBuilder\IQueryBuilder; - /** * @deprecated * Class TokensRequestBuilder @@ -41,8 +39,6 @@ use OCP\DB\QueryBuilder\IQueryBuilder; * @package OCA\Circles\Db */ class TokensRequestBuilder extends DeprecatedRequestBuilder { - - use TArrayTools; @@ -112,5 +108,4 @@ class TokensRequestBuilder extends DeprecatedRequestBuilder { return $sharesToken; } - } diff --git a/lib/Events/AddingCircleMemberEvent.php b/lib/Events/AddingCircleMemberEvent.php index 1aeb05a9..1266d66b 100644 --- a/lib/Events/AddingCircleMemberEvent.php +++ b/lib/Events/AddingCircleMemberEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class AddingCircleMemberEvent * @@ -85,6 +83,4 @@ class AddingCircleMemberEvent extends CircleMemberGenericEvent { public function getType(): int { return $this->type; } - } - diff --git a/lib/Events/CircleCreatedEvent.php b/lib/Events/CircleCreatedEvent.php index 06efe0ce..a2c498f0 100644 --- a/lib/Events/CircleCreatedEvent.php +++ b/lib/Events/CircleCreatedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleCreatedEvent * @@ -61,6 +59,4 @@ class CircleCreatedEvent extends CircleResultGenericEvent { public function __construct(FederatedEvent $federatedEvent, array $results) { parent::__construct($federatedEvent, $results); } - } - diff --git a/lib/Events/CircleDestroyedEvent.php b/lib/Events/CircleDestroyedEvent.php index cdb6a2b8..caa3874c 100644 --- a/lib/Events/CircleDestroyedEvent.php +++ b/lib/Events/CircleDestroyedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleDestroyedEvent * @@ -60,6 +58,4 @@ class CircleDestroyedEvent extends CircleResultGenericEvent { public function __construct(FederatedEvent $federatedEvent, array $results) { parent::__construct($federatedEvent, $results); } - } - diff --git a/lib/Events/CircleEditedEvent.php b/lib/Events/CircleEditedEvent.php index bec51ec0..f5f0fe15 100644 --- a/lib/Events/CircleEditedEvent.php +++ b/lib/Events/CircleEditedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleEditedEvent * @@ -60,6 +58,4 @@ class CircleEditedEvent extends CircleResultGenericEvent { public function __construct(FederatedEvent $federatedEvent, array $results) { parent::__construct($federatedEvent, $results); } - } - diff --git a/lib/Events/CircleGenericEvent.php b/lib/Events/CircleGenericEvent.php index a239f3d8..c84efe71 100644 --- a/lib/Events/CircleGenericEvent.php +++ b/lib/Events/CircleGenericEvent.php @@ -31,29 +31,25 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Circle; use OCA\Circles\Model\Federated\FederatedEvent; use OCP\EventDispatcher\Event; - /** * Class CircleMemberAddedEvent * * @package OCA\Circles\Events */ class CircleGenericEvent extends Event { - - - const INVITED = 1; - const JOINED = 2; + public const INVITED = 1; + public const JOINED = 2; /** @deprecated */ - const MULTIPLE = 3; - const REMOVED = 4; - const LEFT = 5; - const LEVEL = 6; - const NAME = 7; - const REQUESTED = 8; + public const MULTIPLE = 3; + public const REMOVED = 4; + public const LEFT = 5; + public const LEVEL = 6; + public const NAME = 7; + public const REQUESTED = 8; /** @var FederatedEvent */ @@ -89,6 +85,4 @@ class CircleGenericEvent extends Event { public function getCircle(): Circle { return $this->circle; } - } - diff --git a/lib/Events/CircleMemberAddedEvent.php b/lib/Events/CircleMemberAddedEvent.php index 3fca9a1c..f85b975e 100644 --- a/lib/Events/CircleMemberAddedEvent.php +++ b/lib/Events/CircleMemberAddedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleMemberAddedEvent * @@ -82,6 +80,4 @@ class CircleMemberAddedEvent extends CircleResultGenericEvent { public function getType(): int { return $this->type; } - } - diff --git a/lib/Events/CircleMemberEditedEvent.php b/lib/Events/CircleMemberEditedEvent.php index 8cfc0671..d8fbeb1b 100644 --- a/lib/Events/CircleMemberEditedEvent.php +++ b/lib/Events/CircleMemberEditedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleMemberEditedEvent * @@ -125,6 +123,4 @@ class CircleMemberEditedEvent extends CircleResultGenericEvent { public function getNewDisplayName(): string { return $this->newDisplayName; } - } - diff --git a/lib/Events/CircleMemberGenericEvent.php b/lib/Events/CircleMemberGenericEvent.php index 97784605..b6cbb70f 100644 --- a/lib/Events/CircleMemberGenericEvent.php +++ b/lib/Events/CircleMemberGenericEvent.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Member; - /** * Class CircleMemberAddedEvent * @@ -66,6 +64,4 @@ class CircleMemberGenericEvent extends CircleGenericEvent { public function getMember(): Member { return $this->member; } - } - diff --git a/lib/Events/CircleMemberRemovedEvent.php b/lib/Events/CircleMemberRemovedEvent.php index 1744ea40..9fc74567 100644 --- a/lib/Events/CircleMemberRemovedEvent.php +++ b/lib/Events/CircleMemberRemovedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleMemberRemovedEvent * @@ -82,6 +80,4 @@ class CircleMemberRemovedEvent extends CircleResultGenericEvent { public function getType(): int { return $this->type; } - } - diff --git a/lib/Events/CircleMemberRequestedEvent.php b/lib/Events/CircleMemberRequestedEvent.php index f70b47cf..cf1ef56c 100644 --- a/lib/Events/CircleMemberRequestedEvent.php +++ b/lib/Events/CircleMemberRequestedEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleMemberRequestedEvent * @@ -82,6 +80,4 @@ class CircleMemberRequestedEvent extends CircleResultGenericEvent { public function getType(): int { return $this->type; } - } - diff --git a/lib/Events/CircleResultGenericEvent.php b/lib/Events/CircleResultGenericEvent.php index 7a9be296..59ff21ae 100644 --- a/lib/Events/CircleResultGenericEvent.php +++ b/lib/Events/CircleResultGenericEvent.php @@ -31,14 +31,12 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use OCA\Circles\Model\Circle; use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Member; use OCP\EventDispatcher\Event; - /** * Class CircleResultGenericEvent * @@ -116,6 +114,4 @@ class CircleResultGenericEvent extends Event { public function getMember(): ?Member { return $this->member; } - } - diff --git a/lib/Events/CreatingCircleEvent.php b/lib/Events/CreatingCircleEvent.php index 7d2a1003..86dd9d6f 100644 --- a/lib/Events/CreatingCircleEvent.php +++ b/lib/Events/CreatingCircleEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CreatingCircleEvent * @@ -63,6 +61,4 @@ class CreatingCircleEvent extends CircleGenericEvent { public function __construct(FederatedEvent $federatedEvent) { parent::__construct($federatedEvent); } - } - diff --git a/lib/Events/DestroyingCircleEvent.php b/lib/Events/DestroyingCircleEvent.php index d096dda2..37d3088a 100644 --- a/lib/Events/DestroyingCircleEvent.php +++ b/lib/Events/DestroyingCircleEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class DestroyingCircleEvent * @@ -63,6 +61,4 @@ class DestroyingCircleEvent extends CircleGenericEvent { public function __construct(FederatedEvent $federatedEvent) { parent::__construct($federatedEvent); } - } - diff --git a/lib/Events/EditingCircleEvent.php b/lib/Events/EditingCircleEvent.php index 2280c0cd..9281bdb0 100644 --- a/lib/Events/EditingCircleEvent.php +++ b/lib/Events/EditingCircleEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class EditingCircleEvent * @@ -62,6 +60,4 @@ class EditingCircleEvent extends CircleGenericEvent { public function __construct(FederatedEvent $federatedEvent) { parent::__construct($federatedEvent); } - } - diff --git a/lib/Events/EditingCircleMemberEvent.php b/lib/Events/EditingCircleMemberEvent.php index 5deb30d8..551fb9d4 100644 --- a/lib/Events/EditingCircleMemberEvent.php +++ b/lib/Events/EditingCircleMemberEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class EditingCircleMemberEvent * @@ -130,7 +128,4 @@ class EditingCircleMemberEvent extends CircleMemberGenericEvent { public function getDisplayName(): string { return $this->displayName; } - - } - diff --git a/lib/Events/MembershipsCreatedEvent.php b/lib/Events/MembershipsCreatedEvent.php index 213ba16b..0150a96e 100644 --- a/lib/Events/MembershipsCreatedEvent.php +++ b/lib/Events/MembershipsCreatedEvent.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Membership; use OCP\EventDispatcher\Event; - /** * Class MembershipsCreatedEvent * @@ -66,6 +64,4 @@ class MembershipsCreatedEvent extends Event { public function getMemberships(): array { return $this->memberships; } - } - diff --git a/lib/Events/MembershipsEditedEvent.php b/lib/Events/MembershipsEditedEvent.php index 3993058e..36e8eabc 100644 --- a/lib/Events/MembershipsEditedEvent.php +++ b/lib/Events/MembershipsEditedEvent.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Membership; use OCP\EventDispatcher\Event; - /** * Class MembershipsEditedEvent * @@ -66,6 +64,4 @@ class MembershipsEditedEvent extends Event { public function getMemberships(): array { return $this->memberships; } - } - diff --git a/lib/Events/MembershipsRemovedEvent.php b/lib/Events/MembershipsRemovedEvent.php index aed7f539..261f1da5 100644 --- a/lib/Events/MembershipsRemovedEvent.php +++ b/lib/Events/MembershipsRemovedEvent.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Membership; use OCP\EventDispatcher\Event; - /** * Class MembershipsRemovedEvent * @@ -66,6 +64,4 @@ class MembershipsRemovedEvent extends Event { public function getMemberships(): array { return $this->memberships; } - } - diff --git a/lib/Events/RemovingCircleMemberEvent.php b/lib/Events/RemovingCircleMemberEvent.php index e6b273f4..5ae5a0bd 100644 --- a/lib/Events/RemovingCircleMemberEvent.php +++ b/lib/Events/RemovingCircleMemberEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class RemovingCircleMemberEvent * @@ -85,6 +83,4 @@ class RemovingCircleMemberEvent extends CircleMemberGenericEvent { public function getType(): int { return $this->type; } - } - diff --git a/lib/Events/RequestingCircleMemberEvent.php b/lib/Events/RequestingCircleMemberEvent.php index 75233cb1..27ea0852 100644 --- a/lib/Events/RequestingCircleMemberEvent.php +++ b/lib/Events/RequestingCircleMemberEvent.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class RequestingCircleMemberEvent * @@ -84,6 +82,4 @@ class RequestingCircleMemberEvent extends CircleMemberGenericEvent { public function getType(): int { return $this->type; } - } - diff --git a/lib/Events/SharedItemsSyncRequestedEvent.php b/lib/Events/SharedItemsSyncRequestedEvent.php index 6bad951d..4513b267 100644 --- a/lib/Events/SharedItemsSyncRequestedEvent.php +++ b/lib/Events/SharedItemsSyncRequestedEvent.php @@ -31,13 +31,11 @@ declare(strict_types=1); namespace OCA\Circles\Events; - use JsonSerializable; use OCA\Circles\Model\Circle; use OCA\Circles\Model\Federated\FederatedEvent; use OCP\EventDispatcher\Event; - /** * Class CircleMemberAddedEvent * @@ -120,6 +118,4 @@ class SharedItemsSyncRequestedEvent extends Event { $this->sharedItems[$appId][$itemType] = []; } } - } - diff --git a/lib/Exceptions/ApiVersionIncompatibleException.php b/lib/Exceptions/ApiVersionIncompatibleException.php index 269663f1..3daad448 100644 --- a/lib/Exceptions/ApiVersionIncompatibleException.php +++ b/lib/Exceptions/ApiVersionIncompatibleException.php @@ -29,6 +29,4 @@ namespace OCA\Circles\Exceptions; use Exception; class ApiVersionIncompatibleException extends Exception { - } - diff --git a/lib/Exceptions/BroadcasterIsNotCompatibleException.php b/lib/Exceptions/BroadcasterIsNotCompatibleException.php index 32089610..59e60283 100644 --- a/lib/Exceptions/BroadcasterIsNotCompatibleException.php +++ b/lib/Exceptions/BroadcasterIsNotCompatibleException.php @@ -29,6 +29,4 @@ namespace OCA\Circles\Exceptions; use Exception; class BroadcasterIsNotCompatibleException extends Exception { - } - diff --git a/lib/Exceptions/CircleAlreadyExistsException.php b/lib/Exceptions/CircleAlreadyExistsException.php index be1a0b83..c448464a 100644 --- a/lib/Exceptions/CircleAlreadyExistsException.php +++ b/lib/Exceptions/CircleAlreadyExistsException.php @@ -27,7 +27,4 @@ namespace OCA\Circles\Exceptions; class CircleAlreadyExistsException extends \Exception { - } - - diff --git a/lib/Exceptions/CircleDoesNotExistException.php b/lib/Exceptions/CircleDoesNotExistException.php index e3bf1dfb..8a796ce5 100644 --- a/lib/Exceptions/CircleDoesNotExistException.php +++ b/lib/Exceptions/CircleDoesNotExistException.php @@ -26,7 +26,6 @@ namespace OCA\Circles\Exceptions; - /** * Class CircleDoesNotExistException * @@ -34,6 +33,4 @@ namespace OCA\Circles\Exceptions; * @package OCA\Circles\Exceptions */ class CircleDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/CircleNameFirstCharException.php b/lib/Exceptions/CircleNameFirstCharException.php index bc0be33f..b187f0fc 100644 --- a/lib/Exceptions/CircleNameFirstCharException.php +++ b/lib/Exceptions/CircleNameFirstCharException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class CircleNameFirstCharException extends \Exception { - } - - diff --git a/lib/Exceptions/CircleNameTooShortException.php b/lib/Exceptions/CircleNameTooShortException.php index 0187afcc..6dbafff4 100644 --- a/lib/Exceptions/CircleNameTooShortException.php +++ b/lib/Exceptions/CircleNameTooShortException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class CircleNameTooShortException extends FederatedItemBadRequestException { - } - - diff --git a/lib/Exceptions/CircleNotFoundException.php b/lib/Exceptions/CircleNotFoundException.php index 326cfa9a..d2a236b0 100644 --- a/lib/Exceptions/CircleNotFoundException.php +++ b/lib/Exceptions/CircleNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class CircleNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/CircleTypeDisabledException.php b/lib/Exceptions/CircleTypeDisabledException.php index cf259832..3f72a413 100644 --- a/lib/Exceptions/CircleTypeDisabledException.php +++ b/lib/Exceptions/CircleTypeDisabledException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class CircleTypeDisabledException extends \Exception { - } - - diff --git a/lib/Exceptions/CircleTypeIsEmptyException.php b/lib/Exceptions/CircleTypeIsEmptyException.php index 7ff58e27..f967a662 100644 --- a/lib/Exceptions/CircleTypeIsEmptyException.php +++ b/lib/Exceptions/CircleTypeIsEmptyException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class CircleTypeIsEmptyException extends \Exception { - } - - diff --git a/lib/Exceptions/CircleTypeNotValidException.php b/lib/Exceptions/CircleTypeNotValidException.php index c6a9782f..e03fdc0f 100644 --- a/lib/Exceptions/CircleTypeNotValidException.php +++ b/lib/Exceptions/CircleTypeNotValidException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class CircleTypeNotValidException extends \Exception { - } - diff --git a/lib/Exceptions/CommandMissingArgumentException.php b/lib/Exceptions/CommandMissingArgumentException.php index 5f5a6c75..fd19d2b2 100644 --- a/lib/Exceptions/CommandMissingArgumentException.php +++ b/lib/Exceptions/CommandMissingArgumentException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class CommandMissingArgumentException extends \Exception { - } - - diff --git a/lib/Exceptions/ConfigNoCircleAvailableException.php b/lib/Exceptions/ConfigNoCircleAvailableException.php index bbe434be..f9240101 100644 --- a/lib/Exceptions/ConfigNoCircleAvailableException.php +++ b/lib/Exceptions/ConfigNoCircleAvailableException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class ConfigNoCircleAvailableException extends \Exception { - } - diff --git a/lib/Exceptions/ContactAddressBookNotFoundException.php b/lib/Exceptions/ContactAddressBookNotFoundException.php index d3d4c17b..bd112212 100644 --- a/lib/Exceptions/ContactAddressBookNotFoundException.php +++ b/lib/Exceptions/ContactAddressBookNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class ContactAddressBookNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/ContactFormatException.php b/lib/Exceptions/ContactFormatException.php index 702e6c3e..7198f4fa 100644 --- a/lib/Exceptions/ContactFormatException.php +++ b/lib/Exceptions/ContactFormatException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class ContactFormatException extends FederatedItemBadRequestException { - } - - diff --git a/lib/Exceptions/ContactNotFoundException.php b/lib/Exceptions/ContactNotFoundException.php index 0e8acad5..caeb38e1 100644 --- a/lib/Exceptions/ContactNotFoundException.php +++ b/lib/Exceptions/ContactNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class ContactNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/EmailAccountInvalidFormatException.php b/lib/Exceptions/EmailAccountInvalidFormatException.php index 7c506673..327903a8 100644 --- a/lib/Exceptions/EmailAccountInvalidFormatException.php +++ b/lib/Exceptions/EmailAccountInvalidFormatException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class EmailAccountInvalidFormatException extends \Exception { - } - diff --git a/lib/Exceptions/EventWrapperNotFoundException.php b/lib/Exceptions/EventWrapperNotFoundException.php index 620e37e1..41ee3b01 100644 --- a/lib/Exceptions/EventWrapperNotFoundException.php +++ b/lib/Exceptions/EventWrapperNotFoundException.php @@ -32,6 +32,4 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; class EventWrapperNotFoundException extends \Exception { - } - diff --git a/lib/Exceptions/FakeException.php b/lib/Exceptions/FakeException.php index 50fbfbc5..cffbc09a 100644 --- a/lib/Exceptions/FakeException.php +++ b/lib/Exceptions/FakeException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FakeException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedCircleLinkFormatException.php b/lib/Exceptions/FederatedCircleLinkFormatException.php index f98fb27b..a336814d 100644 --- a/lib/Exceptions/FederatedCircleLinkFormatException.php +++ b/lib/Exceptions/FederatedCircleLinkFormatException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedCircleLinkFormatException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedCircleNotAllowedException.php b/lib/Exceptions/FederatedCircleNotAllowedException.php index 7fc2971a..23ce3685 100644 --- a/lib/Exceptions/FederatedCircleNotAllowedException.php +++ b/lib/Exceptions/FederatedCircleNotAllowedException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedCircleNotAllowedException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedCircleStatusUpdateException.php b/lib/Exceptions/FederatedCircleStatusUpdateException.php index b4f5deee..5cea0328 100644 --- a/lib/Exceptions/FederatedCircleStatusUpdateException.php +++ b/lib/Exceptions/FederatedCircleStatusUpdateException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedCircleStatusUpdateException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedEventDSyncException.php b/lib/Exceptions/FederatedEventDSyncException.php index 3a1b2bf3..9e304447 100644 --- a/lib/Exceptions/FederatedEventDSyncException.php +++ b/lib/Exceptions/FederatedEventDSyncException.php @@ -28,15 +28,10 @@ namespace OCA\Circles\Exceptions; -use Exception; - - /** * Class FederatedEventDSyncException * * @package OCA\Circles\Exceptions */ class FederatedEventDSyncException extends FederatedItemConflictException { - } - diff --git a/lib/Exceptions/FederatedEventException.php b/lib/Exceptions/FederatedEventException.php index eba9eac6..9763f8c4 100644 --- a/lib/Exceptions/FederatedEventException.php +++ b/lib/Exceptions/FederatedEventException.php @@ -37,6 +37,4 @@ namespace OCA\Circles\Exceptions; * @package OCA\Circles\Exceptions */ class FederatedEventException extends FederatedItemServerException { - } - diff --git a/lib/Exceptions/FederatedItemBadRequestException.php b/lib/Exceptions/FederatedItemBadRequestException.php index 1b7d0ab3..7832ccc9 100644 --- a/lib/Exceptions/FederatedItemBadRequestException.php +++ b/lib/Exceptions/FederatedItemBadRequestException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemBadRequestException * * @package OCA\Circles\Exceptions */ class FederatedItemBadRequestException extends FederatedItemException { - - - const STATUS = Http::STATUS_BAD_REQUEST; + public const STATUS = Http::STATUS_BAD_REQUEST; /** @@ -61,6 +57,4 @@ class FederatedItemBadRequestException extends FederatedItemException { parent::__construct($message, ($code > 0) ? $code : self::STATUS, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedItemConflictException.php b/lib/Exceptions/FederatedItemConflictException.php index ed2b0e68..5e2f43be 100644 --- a/lib/Exceptions/FederatedItemConflictException.php +++ b/lib/Exceptions/FederatedItemConflictException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemConflictException * * @package OCA\Circles\Exceptions */ class FederatedItemConflictException extends FederatedItemException { - - - const STATUS = Http::STATUS_CONFLICT; + public const STATUS = Http::STATUS_CONFLICT; /** @@ -61,6 +57,4 @@ class FederatedItemConflictException extends FederatedItemException { parent::__construct($message, ($code > 0) ? $code : self::STATUS, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedItemException.php b/lib/Exceptions/FederatedItemException.php index 88b97a2c..8522fd57 100644 --- a/lib/Exceptions/FederatedItemException.php +++ b/lib/Exceptions/FederatedItemException.php @@ -32,22 +32,18 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use Exception; use JsonSerializable; use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemException * * @package OCA\Circles\Exceptions */ class FederatedItemException extends Exception implements JsonSerializable { - - - static $CHILDREN = [ + public static $CHILDREN = [ FederatedItemBadRequestException::class, FederatedItemConflictException::class, FederatedItemForbiddenException::class, @@ -94,12 +90,10 @@ class FederatedItemException extends Exception implements JsonSerializable { */ public function jsonSerialize(): array { return [ - 'class' => get_class($this), - 'status' => $this->getStatus(), - 'code' => $this->getCode(), + 'class' => get_class($this), + 'status' => $this->getStatus(), + 'code' => $this->getCode(), 'message' => $this->getMessage() ]; } - } - diff --git a/lib/Exceptions/FederatedItemForbiddenException.php b/lib/Exceptions/FederatedItemForbiddenException.php index 224ae6bc..07822c89 100644 --- a/lib/Exceptions/FederatedItemForbiddenException.php +++ b/lib/Exceptions/FederatedItemForbiddenException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemForbiddenException * * @package OCA\Circles\Exceptions */ class FederatedItemForbiddenException extends FederatedItemException { - - - const STATUS = Http::STATUS_FORBIDDEN; + public const STATUS = Http::STATUS_FORBIDDEN; /** @@ -61,6 +57,4 @@ class FederatedItemForbiddenException extends FederatedItemException { parent::__construct($message, ($code > 0) ? $code : self::STATUS, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedItemNotFoundException.php b/lib/Exceptions/FederatedItemNotFoundException.php index 315f80bc..89c991ef 100644 --- a/lib/Exceptions/FederatedItemNotFoundException.php +++ b/lib/Exceptions/FederatedItemNotFoundException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemNotFoundException * * @package OCA\Circles\Exceptions */ class FederatedItemNotFoundException extends FederatedItemException { - - - const STATUS = Http::STATUS_NOT_FOUND; + public const STATUS = Http::STATUS_NOT_FOUND; /** @@ -61,6 +57,4 @@ class FederatedItemNotFoundException extends FederatedItemException { parent::__construct($message, ($code > 0) ? $code : self::STATUS, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedItemRemoteException.php b/lib/Exceptions/FederatedItemRemoteException.php index d200d667..8bcd4bfb 100644 --- a/lib/Exceptions/FederatedItemRemoteException.php +++ b/lib/Exceptions/FederatedItemRemoteException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemRemoteException * * @package OCA\Circles\Exceptions */ class FederatedItemRemoteException extends FederatedItemException { - - - const STATUS = Http::STATUS_REQUEST_TIMEOUT; + public const STATUS = Http::STATUS_REQUEST_TIMEOUT; /** @@ -61,6 +57,4 @@ class FederatedItemRemoteException extends FederatedItemException { parent::__construct($message, ($code > 0) ? $code : self::STATUS, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedItemServerException.php b/lib/Exceptions/FederatedItemServerException.php index 34809a27..b1cd24f6 100644 --- a/lib/Exceptions/FederatedItemServerException.php +++ b/lib/Exceptions/FederatedItemServerException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemServerException * * @package OCA\Circles\Exceptions */ class FederatedItemServerException extends FederatedItemException { - - - const STATUS = Http::STATUS_INTERNAL_SERVER_ERROR; + public const STATUS = Http::STATUS_INTERNAL_SERVER_ERROR; /** @@ -61,6 +57,4 @@ class FederatedItemServerException extends FederatedItemException { parent::__construct($message, ($code > 0) ? $code : self::STATUS, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedItemUnauthorizedException.php b/lib/Exceptions/FederatedItemUnauthorizedException.php index 879bd580..739d7fd1 100644 --- a/lib/Exceptions/FederatedItemUnauthorizedException.php +++ b/lib/Exceptions/FederatedItemUnauthorizedException.php @@ -30,20 +30,16 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use OCP\AppFramework\Http; use Throwable; - /** * Class FederatedItemUnauthorizedException * * @package OCA\Circles\Exceptions */ class FederatedItemUnauthorizedException extends FederatedItemException { - - - const STATUS = Http::STATUS_UNAUTHORIZED; + public const STATUS = Http::STATUS_UNAUTHORIZED; /** @@ -61,6 +57,4 @@ class FederatedItemUnauthorizedException extends FederatedItemException { parent::__construct($message, $code, $previous); $this->setStatus(self::STATUS); } - } - diff --git a/lib/Exceptions/FederatedLinkCircleNotFoundException.php b/lib/Exceptions/FederatedLinkCircleNotFoundException.php index d2e93b9e..0523479a 100644 --- a/lib/Exceptions/FederatedLinkCircleNotFoundException.php +++ b/lib/Exceptions/FederatedLinkCircleNotFoundException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedLinkCircleNotFoundException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedLinkCreationException.php b/lib/Exceptions/FederatedLinkCreationException.php index 68b17e08..e91400bf 100644 --- a/lib/Exceptions/FederatedLinkCreationException.php +++ b/lib/Exceptions/FederatedLinkCreationException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedLinkCreationException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedLinkDoesNotExistException.php b/lib/Exceptions/FederatedLinkDoesNotExistException.php index c85feff3..35324129 100644 --- a/lib/Exceptions/FederatedLinkDoesNotExistException.php +++ b/lib/Exceptions/FederatedLinkDoesNotExistException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedLinkDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedLinkUpdateException.php b/lib/Exceptions/FederatedLinkUpdateException.php index eef48e1f..f2ecfc84 100644 --- a/lib/Exceptions/FederatedLinkUpdateException.php +++ b/lib/Exceptions/FederatedLinkUpdateException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedLinkUpdateException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedRemoteCircleDoesNotExistException.php b/lib/Exceptions/FederatedRemoteCircleDoesNotExistException.php index e756b031..132cc35d 100644 --- a/lib/Exceptions/FederatedRemoteCircleDoesNotExistException.php +++ b/lib/Exceptions/FederatedRemoteCircleDoesNotExistException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedRemoteCircleDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedRemoteDoesNotAllowException.php b/lib/Exceptions/FederatedRemoteDoesNotAllowException.php index f831e811..e65b8642 100644 --- a/lib/Exceptions/FederatedRemoteDoesNotAllowException.php +++ b/lib/Exceptions/FederatedRemoteDoesNotAllowException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedRemoteDoesNotAllowException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedRemoteIsDownException.php b/lib/Exceptions/FederatedRemoteIsDownException.php index f4ed8f23..5e0147ee 100644 --- a/lib/Exceptions/FederatedRemoteIsDownException.php +++ b/lib/Exceptions/FederatedRemoteIsDownException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class FederatedRemoteIsDownException extends \Exception { - } - diff --git a/lib/Exceptions/FederatedShareAlreadyLockedException.php b/lib/Exceptions/FederatedShareAlreadyLockedException.php index 46c6a3b3..993339c8 100644 --- a/lib/Exceptions/FederatedShareAlreadyLockedException.php +++ b/lib/Exceptions/FederatedShareAlreadyLockedException.php @@ -32,9 +32,5 @@ namespace OCA\Circles\Exceptions; use Exception; - class FederatedShareAlreadyLockedException extends Exception { - } - - diff --git a/lib/Exceptions/FederatedShareBelongingException.php b/lib/Exceptions/FederatedShareBelongingException.php index 79e8102a..42f7e0b1 100644 --- a/lib/Exceptions/FederatedShareBelongingException.php +++ b/lib/Exceptions/FederatedShareBelongingException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class FederatedShareBelongingException extends FederatedItemException { - } - - diff --git a/lib/Exceptions/FederatedShareNotFoundException.php b/lib/Exceptions/FederatedShareNotFoundException.php index bb7e9ad6..9113fdfa 100644 --- a/lib/Exceptions/FederatedShareNotFoundException.php +++ b/lib/Exceptions/FederatedShareNotFoundException.php @@ -32,9 +32,5 @@ namespace OCA\Circles\Exceptions; use Exception; - class FederatedShareNotFoundException extends Exception { - } - - diff --git a/lib/Exceptions/FederatedUserException.php b/lib/Exceptions/FederatedUserException.php index db2b3382..0838f480 100644 --- a/lib/Exceptions/FederatedUserException.php +++ b/lib/Exceptions/FederatedUserException.php @@ -31,9 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class FederatedUserException extends FederatedItemServerException { - } - - diff --git a/lib/Exceptions/FederatedUserNotFoundException.php b/lib/Exceptions/FederatedUserNotFoundException.php index 2375db0e..f2455e11 100644 --- a/lib/Exceptions/FederatedUserNotFoundException.php +++ b/lib/Exceptions/FederatedUserNotFoundException.php @@ -31,8 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class FederatedUserNotFoundException extends FederatedItemNotFoundException { - } - diff --git a/lib/Exceptions/FileCacheNotFoundException.php b/lib/Exceptions/FileCacheNotFoundException.php index 0b3b2460..b121a34c 100644 --- a/lib/Exceptions/FileCacheNotFoundException.php +++ b/lib/Exceptions/FileCacheNotFoundException.php @@ -30,13 +30,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberNotFoundException * * @package OCA\Circles\Exceptions */ class FileCacheNotFoundException extends FederatedItemNotFoundException { - } - diff --git a/lib/Exceptions/FrontendException.php b/lib/Exceptions/FrontendException.php index c2cfdabc..5c1a1120 100644 --- a/lib/Exceptions/FrontendException.php +++ b/lib/Exceptions/FrontendException.php @@ -30,14 +30,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class FrontendException * * @package OCA\Circles\Exceptions */ class FrontendException extends FederatedItemBadRequestException { - } - - diff --git a/lib/Exceptions/GSKeyException.php b/lib/Exceptions/GSKeyException.php index da4fa59b..a2819885 100644 --- a/lib/Exceptions/GSKeyException.php +++ b/lib/Exceptions/GSKeyException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class GSKeyException extends \Exception { - } - - diff --git a/lib/Exceptions/GSStatusException.php b/lib/Exceptions/GSStatusException.php index 0e3de475..8d54dcc5 100644 --- a/lib/Exceptions/GSStatusException.php +++ b/lib/Exceptions/GSStatusException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class GSStatusException extends \Exception { - } - - diff --git a/lib/Exceptions/GlobalScaleDSyncException.php b/lib/Exceptions/GlobalScaleDSyncException.php index e485f212..0d804f2d 100644 --- a/lib/Exceptions/GlobalScaleDSyncException.php +++ b/lib/Exceptions/GlobalScaleDSyncException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class GlobalScaleDSyncException extends \Exception { - } - diff --git a/lib/Exceptions/GlobalScaleEventException.php b/lib/Exceptions/GlobalScaleEventException.php index cf721d09..9b6eaf73 100644 --- a/lib/Exceptions/GlobalScaleEventException.php +++ b/lib/Exceptions/GlobalScaleEventException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class GlobalScaleEventException extends \Exception { - } - diff --git a/lib/Exceptions/GroupCannotBeOwnerException.php b/lib/Exceptions/GroupCannotBeOwnerException.php index dfdbe245..e30cf796 100644 --- a/lib/Exceptions/GroupCannotBeOwnerException.php +++ b/lib/Exceptions/GroupCannotBeOwnerException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class GroupCannotBeOwnerException extends \Exception { - } - diff --git a/lib/Exceptions/GroupDoesNotExistException.php b/lib/Exceptions/GroupDoesNotExistException.php index ae8d048f..88de4f1b 100644 --- a/lib/Exceptions/GroupDoesNotExistException.php +++ b/lib/Exceptions/GroupDoesNotExistException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class GroupDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/GroupNotFoundException.php b/lib/Exceptions/GroupNotFoundException.php index 1b84d1e2..a0424c37 100644 --- a/lib/Exceptions/GroupNotFoundException.php +++ b/lib/Exceptions/GroupNotFoundException.php @@ -31,8 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class GroupNotFoundException extends FederatedItemNotFoundException { - } - diff --git a/lib/Exceptions/InitiatorNotConfirmedException.php b/lib/Exceptions/InitiatorNotConfirmedException.php index feeb15c0..63c1d9d7 100644 --- a/lib/Exceptions/InitiatorNotConfirmedException.php +++ b/lib/Exceptions/InitiatorNotConfirmedException.php @@ -30,8 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class InitiatorNotConfirmedException extends FederatedItemForbiddenException { - } - diff --git a/lib/Exceptions/InitiatorNotFoundException.php b/lib/Exceptions/InitiatorNotFoundException.php index 1efacf88..ad9950df 100644 --- a/lib/Exceptions/InitiatorNotFoundException.php +++ b/lib/Exceptions/InitiatorNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class InitiatorNotFoundException extends FederatedItemUnauthorizedException { - } - - diff --git a/lib/Exceptions/InvalidIdException.php b/lib/Exceptions/InvalidIdException.php index e51b945a..ee0c103b 100644 --- a/lib/Exceptions/InvalidIdException.php +++ b/lib/Exceptions/InvalidIdException.php @@ -28,15 +28,10 @@ namespace OCA\Circles\Exceptions; -use Exception; - - /** * Class FederatedEventException * * @package OCA\Circles\Exceptions */ class InvalidIdException extends FederatedItemServerException { - } - diff --git a/lib/Exceptions/InvalidModelException.php b/lib/Exceptions/InvalidModelException.php index 9b447d41..93503917 100644 --- a/lib/Exceptions/InvalidModelException.php +++ b/lib/Exceptions/InvalidModelException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberLevelException * * @package OCA\Circles\Exceptions */ class InvalidModelException extends FederatedItemBadRequestException { - } - diff --git a/lib/Exceptions/JsonException.php b/lib/Exceptions/JsonException.php index 2760a1c7..a8419372 100644 --- a/lib/Exceptions/JsonException.php +++ b/lib/Exceptions/JsonException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class JsonException extends \Exception { - } - - diff --git a/lib/Exceptions/LinkedGroupNotAllowedException.php b/lib/Exceptions/LinkedGroupNotAllowedException.php index d45dce4a..16a11f2c 100644 --- a/lib/Exceptions/LinkedGroupNotAllowedException.php +++ b/lib/Exceptions/LinkedGroupNotAllowedException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class LinkedGroupNotAllowedException extends \Exception { - } - diff --git a/lib/Exceptions/MaintenanceException.php b/lib/Exceptions/MaintenanceException.php index 65a0f947..12b05f94 100644 --- a/lib/Exceptions/MaintenanceException.php +++ b/lib/Exceptions/MaintenanceException.php @@ -30,17 +30,12 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use Exception; - /** * Class MaintenanceException * * @package OCA\Circles\Exceptions */ class MaintenanceException extends Exception { - } - - diff --git a/lib/Exceptions/MemberAlreadyExistsException.php b/lib/Exceptions/MemberAlreadyExistsException.php index 90a94e79..104aad88 100644 --- a/lib/Exceptions/MemberAlreadyExistsException.php +++ b/lib/Exceptions/MemberAlreadyExistsException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberAlreadyExistsException * * @package OCA\Circles\Exceptions */ class MemberAlreadyExistsException extends FederatedItemBadRequestException { - } - diff --git a/lib/Exceptions/MemberCantJoinCircleException.php b/lib/Exceptions/MemberCantJoinCircleException.php index 8af27f72..ccce21ee 100644 --- a/lib/Exceptions/MemberCantJoinCircleException.php +++ b/lib/Exceptions/MemberCantJoinCircleException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberCantJoinCircleException extends \Exception { - } - diff --git a/lib/Exceptions/MemberDoesNotExistException.php b/lib/Exceptions/MemberDoesNotExistException.php index 95ccdf82..ee37449b 100644 --- a/lib/Exceptions/MemberDoesNotExistException.php +++ b/lib/Exceptions/MemberDoesNotExistException.php @@ -26,7 +26,6 @@ namespace OCA\Circles\Exceptions; - /** * Class MemberDoesNotExistException * @@ -34,6 +33,4 @@ namespace OCA\Circles\Exceptions; * @package OCA\Circles\Exceptions */ class MemberDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/MemberHelperException.php b/lib/Exceptions/MemberHelperException.php index 84b85b41..ed144574 100644 --- a/lib/Exceptions/MemberHelperException.php +++ b/lib/Exceptions/MemberHelperException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberLevelException * * @package OCA\Circles\Exceptions */ class MemberHelperException extends FederatedItemBadRequestException { - } - diff --git a/lib/Exceptions/MemberIsBlockedException.php b/lib/Exceptions/MemberIsBlockedException.php index a25cbe1a..db659fac 100644 --- a/lib/Exceptions/MemberIsBlockedException.php +++ b/lib/Exceptions/MemberIsBlockedException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberIsBlockedException extends \Exception { - } - diff --git a/lib/Exceptions/MemberIsNotAdminException.php b/lib/Exceptions/MemberIsNotAdminException.php index 91a05afb..007c4793 100644 --- a/lib/Exceptions/MemberIsNotAdminException.php +++ b/lib/Exceptions/MemberIsNotAdminException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberIsNotAdminException extends \Exception { - } - diff --git a/lib/Exceptions/MemberIsNotModeratorException.php b/lib/Exceptions/MemberIsNotModeratorException.php index d7002c37..01aff974 100644 --- a/lib/Exceptions/MemberIsNotModeratorException.php +++ b/lib/Exceptions/MemberIsNotModeratorException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberIsNotModeratorException extends \Exception { - } - diff --git a/lib/Exceptions/MemberIsNotOwnerException.php b/lib/Exceptions/MemberIsNotOwnerException.php index a87893b5..6115e755 100644 --- a/lib/Exceptions/MemberIsNotOwnerException.php +++ b/lib/Exceptions/MemberIsNotOwnerException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberIsNotOwnerException extends \Exception { - } - diff --git a/lib/Exceptions/MemberIsOwnerException.php b/lib/Exceptions/MemberIsOwnerException.php index 7fb3ec12..0707ed2b 100644 --- a/lib/Exceptions/MemberIsOwnerException.php +++ b/lib/Exceptions/MemberIsOwnerException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberIsOwnerException extends \Exception { - } - diff --git a/lib/Exceptions/MemberLevelException.php b/lib/Exceptions/MemberLevelException.php index 72526a70..7890bb07 100644 --- a/lib/Exceptions/MemberLevelException.php +++ b/lib/Exceptions/MemberLevelException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberLevelException * * @package OCA\Circles\Exceptions */ class MemberLevelException extends FederatedItemBadRequestException { - } - diff --git a/lib/Exceptions/MemberNotFoundException.php b/lib/Exceptions/MemberNotFoundException.php index af2198a4..5ee8ac2b 100644 --- a/lib/Exceptions/MemberNotFoundException.php +++ b/lib/Exceptions/MemberNotFoundException.php @@ -30,14 +30,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberNotFoundException * * @package OCA\Circles\Exceptions */ class MemberNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/MemberTypeCantEditLevelException.php b/lib/Exceptions/MemberTypeCantEditLevelException.php index 27983935..e55e9eb7 100644 --- a/lib/Exceptions/MemberTypeCantEditLevelException.php +++ b/lib/Exceptions/MemberTypeCantEditLevelException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MemberTypeCantEditLevelException extends \Exception { - } - diff --git a/lib/Exceptions/MembersLimitException.php b/lib/Exceptions/MembersLimitException.php index 96fc02ea..a5c1c137 100644 --- a/lib/Exceptions/MembersLimitException.php +++ b/lib/Exceptions/MembersLimitException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class MembersLimitException extends FederatedItemBadRequestException { - } - - diff --git a/lib/Exceptions/MembershipNotFoundException.php b/lib/Exceptions/MembershipNotFoundException.php index a952e3a0..aecdf698 100644 --- a/lib/Exceptions/MembershipNotFoundException.php +++ b/lib/Exceptions/MembershipNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class MembershipNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/MigrationException.php b/lib/Exceptions/MigrationException.php index 71b94752..8fe0ead1 100644 --- a/lib/Exceptions/MigrationException.php +++ b/lib/Exceptions/MigrationException.php @@ -31,16 +31,12 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use Exception; - /** * Class MigrationTo22Exception * * @package OCA\Circles\Exceptions */ class MigrationException extends Exception { - } - diff --git a/lib/Exceptions/MissingKeyInArrayException.php b/lib/Exceptions/MissingKeyInArrayException.php index b90431a6..3ec997be 100644 --- a/lib/Exceptions/MissingKeyInArrayException.php +++ b/lib/Exceptions/MissingKeyInArrayException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class MissingKeyInArrayException extends \Exception { - } - diff --git a/lib/Exceptions/ModelException.php b/lib/Exceptions/ModelException.php index ad64949e..1d11f93e 100644 --- a/lib/Exceptions/ModelException.php +++ b/lib/Exceptions/ModelException.php @@ -26,9 +26,5 @@ namespace OCA\Circles\Exceptions; - class ModelException extends \Exception { - } - - diff --git a/lib/Exceptions/ModeratorIsNotHighEnoughException.php b/lib/Exceptions/ModeratorIsNotHighEnoughException.php index 2be53822..60c41880 100644 --- a/lib/Exceptions/ModeratorIsNotHighEnoughException.php +++ b/lib/Exceptions/ModeratorIsNotHighEnoughException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class ModeratorIsNotHighEnoughException extends \Exception { - } - diff --git a/lib/Exceptions/MountNotFoundException.php b/lib/Exceptions/MountNotFoundException.php index f80493a5..f7521c19 100644 --- a/lib/Exceptions/MountNotFoundException.php +++ b/lib/Exceptions/MountNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class MountNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/MountPointConstructionException.php b/lib/Exceptions/MountPointConstructionException.php index c90c36c9..56cf13bb 100644 --- a/lib/Exceptions/MountPointConstructionException.php +++ b/lib/Exceptions/MountPointConstructionException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class MountPointConstructionException extends FederatedItemServerException { - } - - diff --git a/lib/Exceptions/NotContactAddressException.php b/lib/Exceptions/NotContactAddressException.php index 79a67970..4db00ba3 100644 --- a/lib/Exceptions/NotContactAddressException.php +++ b/lib/Exceptions/NotContactAddressException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class NotContactAddressException extends \Exception { - } - diff --git a/lib/Exceptions/NotLocalMemberException.php b/lib/Exceptions/NotLocalMemberException.php index 6506e0c6..6061b248 100644 --- a/lib/Exceptions/NotLocalMemberException.php +++ b/lib/Exceptions/NotLocalMemberException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class NotLocalMemberException extends \Exception { - } - diff --git a/lib/Exceptions/OwnerNotFoundException.php b/lib/Exceptions/OwnerNotFoundException.php index 7d976998..a5869acb 100644 --- a/lib/Exceptions/OwnerNotFoundException.php +++ b/lib/Exceptions/OwnerNotFoundException.php @@ -31,8 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class OwnerNotFoundException extends FederatedItemServerException { - } - diff --git a/lib/Exceptions/ParseMemberLevelException.php b/lib/Exceptions/ParseMemberLevelException.php index 224bb187..c0cf2b18 100644 --- a/lib/Exceptions/ParseMemberLevelException.php +++ b/lib/Exceptions/ParseMemberLevelException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class MemberLevelException * * @package OCA\Circles\Exceptions */ class ParseMemberLevelException extends FederatedItemBadRequestException { - } - diff --git a/lib/Exceptions/PayloadDeliveryException.php b/lib/Exceptions/PayloadDeliveryException.php index 8dfa5915..a1166e78 100644 --- a/lib/Exceptions/PayloadDeliveryException.php +++ b/lib/Exceptions/PayloadDeliveryException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class PayloadDeliveryException extends \Exception { - } - diff --git a/lib/Exceptions/RemoteAlreadyExistsException.php b/lib/Exceptions/RemoteAlreadyExistsException.php index 64ecbc6e..8b36296a 100644 --- a/lib/Exceptions/RemoteAlreadyExistsException.php +++ b/lib/Exceptions/RemoteAlreadyExistsException.php @@ -32,9 +32,5 @@ namespace OCA\Circles\Exceptions; use Exception; - class RemoteAlreadyExistsException extends Exception { - } - - diff --git a/lib/Exceptions/RemoteInstanceException.php b/lib/Exceptions/RemoteInstanceException.php index 216a2821..b081f63d 100644 --- a/lib/Exceptions/RemoteInstanceException.php +++ b/lib/Exceptions/RemoteInstanceException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class RemoteInstanceException * * @package OCA\Circles\Exceptions */ class RemoteInstanceException extends FederatedItemRemoteException { - } - diff --git a/lib/Exceptions/RemoteNotFoundException.php b/lib/Exceptions/RemoteNotFoundException.php index 98f8258a..85a9c06e 100644 --- a/lib/Exceptions/RemoteNotFoundException.php +++ b/lib/Exceptions/RemoteNotFoundException.php @@ -30,14 +30,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class RemoteNotFoundException * * @package OCA\Circles\Exceptions */ class RemoteNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/RemoteResourceNotFoundException.php b/lib/Exceptions/RemoteResourceNotFoundException.php index a2f949ab..206f728c 100644 --- a/lib/Exceptions/RemoteResourceNotFoundException.php +++ b/lib/Exceptions/RemoteResourceNotFoundException.php @@ -30,8 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class RemoteResourceNotFoundException extends FederatedItemRemoteException { - } - diff --git a/lib/Exceptions/RemoteUidException.php b/lib/Exceptions/RemoteUidException.php index 251a4962..20737f29 100644 --- a/lib/Exceptions/RemoteUidException.php +++ b/lib/Exceptions/RemoteUidException.php @@ -32,8 +32,5 @@ namespace OCA\Circles\Exceptions; use Exception; - class RemoteUidException extends Exception { - } - diff --git a/lib/Exceptions/RequestBuilderException.php b/lib/Exceptions/RequestBuilderException.php index e04fe9bb..acbad7ee 100644 --- a/lib/Exceptions/RequestBuilderException.php +++ b/lib/Exceptions/RequestBuilderException.php @@ -31,16 +31,12 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use Exception; - /** * Class MigrationTo22Exception * * @package OCA\Circles\Exceptions */ class RequestBuilderException extends Exception { - } - diff --git a/lib/Exceptions/ShareTokenAlreadyExistException.php b/lib/Exceptions/ShareTokenAlreadyExistException.php index 70597bfc..f1e531e6 100644 --- a/lib/Exceptions/ShareTokenAlreadyExistException.php +++ b/lib/Exceptions/ShareTokenAlreadyExistException.php @@ -30,16 +30,12 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use Exception; - /** * Class ShareTokenAlreadyExistException * * @package OCA\Circles\Exceptions */ class ShareTokenAlreadyExistException extends Exception { - } - diff --git a/lib/Exceptions/ShareTokenNotFoundException.php b/lib/Exceptions/ShareTokenNotFoundException.php index 969ab1d3..ea30499d 100644 --- a/lib/Exceptions/ShareTokenNotFoundException.php +++ b/lib/Exceptions/ShareTokenNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class ShareTokenNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/ShareWrapperNotFoundException.php b/lib/Exceptions/ShareWrapperNotFoundException.php index d23b7844..b982a3cf 100644 --- a/lib/Exceptions/ShareWrapperNotFoundException.php +++ b/lib/Exceptions/ShareWrapperNotFoundException.php @@ -30,9 +30,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class ShareWrapperNotFoundException extends FederatedItemNotFoundException { - } - - diff --git a/lib/Exceptions/SharingFrameAlreadyDeliveredException.php b/lib/Exceptions/SharingFrameAlreadyDeliveredException.php index 7b305eee..e8128cb5 100644 --- a/lib/Exceptions/SharingFrameAlreadyDeliveredException.php +++ b/lib/Exceptions/SharingFrameAlreadyDeliveredException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class SharingFrameAlreadyDeliveredException extends \Exception { - } - diff --git a/lib/Exceptions/SharingFrameAlreadyExistException.php b/lib/Exceptions/SharingFrameAlreadyExistException.php index 46464050..32a465d8 100644 --- a/lib/Exceptions/SharingFrameAlreadyExistException.php +++ b/lib/Exceptions/SharingFrameAlreadyExistException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class SharingFrameAlreadyExistException extends \Exception { - } - diff --git a/lib/Exceptions/SharingFrameDoesNotExistException.php b/lib/Exceptions/SharingFrameDoesNotExistException.php index 7b556a29..6f1921a8 100644 --- a/lib/Exceptions/SharingFrameDoesNotExistException.php +++ b/lib/Exceptions/SharingFrameDoesNotExistException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class SharingFrameDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/SharingFrameSourceCannotBeAppCirclesException.php b/lib/Exceptions/SharingFrameSourceCannotBeAppCirclesException.php index e2140cde..e97036e7 100644 --- a/lib/Exceptions/SharingFrameSourceCannotBeAppCirclesException.php +++ b/lib/Exceptions/SharingFrameSourceCannotBeAppCirclesException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class SharingFrameSourceCannotBeAppCirclesException extends \Exception { - } - diff --git a/lib/Exceptions/SingleCircleNotFoundException.php b/lib/Exceptions/SingleCircleNotFoundException.php index b1f54cec..079d4591 100644 --- a/lib/Exceptions/SingleCircleNotFoundException.php +++ b/lib/Exceptions/SingleCircleNotFoundException.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - /** * Class SingleCircleNotFoundException * * @package OCA\Circles\Exceptions */ class SingleCircleNotFoundException extends FederatedItemServerException { - } - diff --git a/lib/Exceptions/TokenDoesNotExistException.php b/lib/Exceptions/TokenDoesNotExistException.php index cf1d3ee3..c942229d 100644 --- a/lib/Exceptions/TokenDoesNotExistException.php +++ b/lib/Exceptions/TokenDoesNotExistException.php @@ -27,6 +27,4 @@ namespace OCA\Circles\Exceptions; class TokenDoesNotExistException extends \Exception { - } - diff --git a/lib/Exceptions/UnknownFederatedItemException.php b/lib/Exceptions/UnknownFederatedItemException.php index f6b05054..e2d8545a 100644 --- a/lib/Exceptions/UnknownFederatedItemException.php +++ b/lib/Exceptions/UnknownFederatedItemException.php @@ -32,11 +32,7 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - use Exception; -use JsonSerializable; -use Throwable; - /** * Class UnknownFederatedItemException @@ -44,6 +40,4 @@ use Throwable; * @package OCA\Circles\Exceptions */ class UnknownFederatedItemException extends Exception { - } - diff --git a/lib/Exceptions/UnknownInterfaceException.php b/lib/Exceptions/UnknownInterfaceException.php index de74a3fe..f9173c73 100644 --- a/lib/Exceptions/UnknownInterfaceException.php +++ b/lib/Exceptions/UnknownInterfaceException.php @@ -31,9 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class UnknownInterfaceException extends FederatedItemServerException { - } - - diff --git a/lib/Exceptions/UnknownRemoteException.php b/lib/Exceptions/UnknownRemoteException.php index cf0f9a80..0f2f7fdd 100644 --- a/lib/Exceptions/UnknownRemoteException.php +++ b/lib/Exceptions/UnknownRemoteException.php @@ -31,9 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class UnknownRemoteException extends FederatedItemRemoteException { - } - - diff --git a/lib/Exceptions/UserTypeNotFoundException.php b/lib/Exceptions/UserTypeNotFoundException.php index 4ef13ac6..c28b31d6 100644 --- a/lib/Exceptions/UserTypeNotFoundException.php +++ b/lib/Exceptions/UserTypeNotFoundException.php @@ -31,9 +31,5 @@ declare(strict_types=1); namespace OCA\Circles\Exceptions; - class UserTypeNotFoundException extends FederatedItemBadRequestException { - } - - diff --git a/lib/FederatedItems/CircleConfig.php b/lib/FederatedItems/CircleConfig.php index 510571f2..d44c6a1b 100644 --- a/lib/FederatedItems/CircleConfig.php +++ b/lib/FederatedItems/CircleConfig.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\CircleRequest; use OCA\Circles\Exceptions\FederatedItemBadRequestException; @@ -42,7 +41,6 @@ use OCA\Circles\Model\Circle; use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Helpers\MemberHelper; - /** * Class CircleConfig * @@ -51,8 +49,6 @@ use OCA\Circles\Model\Helpers\MemberHelper; class CircleConfig implements IFederatedItem, IFederatedItemAsyncProcess { - - use TNC22Deserialize; @@ -161,6 +157,4 @@ class CircleConfig implements */ public function result(FederatedEvent $event, array $results): void { } - } - diff --git a/lib/FederatedItems/CircleCreate.php b/lib/FederatedItems/CircleCreate.php index a1a3a68b..eab1d4bc 100644 --- a/lib/FederatedItems/CircleCreate.php +++ b/lib/FederatedItems/CircleCreate.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\CircleRequest; use OCA\Circles\Db\MemberRequest; @@ -49,7 +48,6 @@ use OCA\Circles\Service\CircleService; use OCA\Circles\Service\EventService; use OCA\Circles\Service\MembershipService; - /** * Class CircleCreate * @@ -60,8 +58,6 @@ class CircleCreate implements IFederatedItemHighSeverity, IFederatedItemCircleCheckNotRequired, IFederatedItemMustBeInitializedLocally { - - use TNC22Deserialize; @@ -159,6 +155,4 @@ class CircleCreate implements public function result(FederatedEvent $event, array $results): void { $this->eventService->circleCreated($event, $results); } - } - diff --git a/lib/FederatedItems/CircleDestroy.php b/lib/FederatedItems/CircleDestroy.php index 1a152f41..bc2d7616 100644 --- a/lib/FederatedItems/CircleDestroy.php +++ b/lib/FederatedItems/CircleDestroy.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\CircleRequest; use OCA\Circles\Db\MemberRequest; @@ -45,7 +44,6 @@ use OCA\Circles\Model\Helpers\MemberHelper; use OCA\Circles\Service\EventService; use OCA\Circles\Service\MembershipService; - /** * Class CircleDestroy * @@ -56,8 +54,6 @@ class CircleDestroy implements IFederatedItemHighSeverity, IFederatedItemAsyncProcess, IFederatedItemMemberEmpty { - - use TNC22Deserialize; @@ -130,6 +126,4 @@ class CircleDestroy implements public function result(FederatedEvent $event, array $results): void { $this->eventService->circleDestroyed($event, $results); } - } - diff --git a/lib/FederatedItems/CircleEdit.php b/lib/FederatedItems/CircleEdit.php index 1c296f6d..2a73b37b 100644 --- a/lib/FederatedItems/CircleEdit.php +++ b/lib/FederatedItems/CircleEdit.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\CircleRequest; use OCA\Circles\Exceptions\CircleNameTooShortException; @@ -42,15 +41,12 @@ use OCA\Circles\Model\Helpers\MemberHelper; use OCA\Circles\Service\CircleService; use OCA\Circles\Service\EventService; - /** * Class CircleEdit * * @package OCA\Circles\FederatedItems */ class CircleEdit implements IFederatedItem { - - use TNC22Deserialize; @@ -149,6 +145,4 @@ class CircleEdit implements IFederatedItem { public function result(FederatedEvent $event, array $results): void { $this->eventService->circleEdited($event, $results); } - } - diff --git a/lib/FederatedItems/CircleJoin.php b/lib/FederatedItems/CircleJoin.php index 53cdc4fa..d98d2a9a 100644 --- a/lib/FederatedItems/CircleJoin.php +++ b/lib/FederatedItems/CircleJoin.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -65,7 +64,6 @@ use OCA\Circles\Service\MembershipService; use OCA\Circles\StatusCode; use OCP\IUserManager; - /** * Class CircleJoin * @@ -78,8 +76,6 @@ class CircleJoin implements IFederatedItemHighSeverity, IFederatedItemMemberCheckNotRequired, IFederatedItemMemberOptional { - - use TStringTools; use TNC22Logger; use TNC22Deserialize; @@ -319,6 +315,4 @@ class CircleJoin implements } } } - } - diff --git a/lib/FederatedItems/CircleLeave.php b/lib/FederatedItems/CircleLeave.php index b5ded718..5b40d6df 100644 --- a/lib/FederatedItems/CircleLeave.php +++ b/lib/FederatedItems/CircleLeave.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use OCA\Circles\AppInfo\Application; @@ -55,7 +54,6 @@ use OCA\Circles\Service\EventService; use OCA\Circles\Service\MembershipService; use OCA\Circles\StatusCode; - /** * Class CircleLeave * @@ -67,8 +65,6 @@ class CircleLeave implements IFederatedItemAsyncProcess, IFederatedItemInitiatorMembershipNotRequired, IFederatedItemMemberOptional { - - use TNC22Deserialize; use TNC22Logger; @@ -128,7 +124,7 @@ class CircleLeave implements if (!$event->getParams()->gBool('force')) { $memberHelper = new MemberHelper($member); $memberHelper->cannotBeOwner(); - } else if ($this->configService->isLocalInstance($event->getOrigin())) { + } elseif ($this->configService->isLocalInstance($event->getOrigin())) { if ($member->getLevel() === Member::LEVEL_OWNER) { try { $newOwner = $this->selectNewOwner($circle); @@ -227,7 +223,7 @@ class CircleLeave implements if ($member->getLevel() > $newOwner->getLevel()) { $newOwner = $member; - } else if ($member->getLevel() === $newOwner->getLevel() + } elseif ($member->getLevel() === $newOwner->getLevel() && ($member->getJoined() < $newOwner->getJoined() || ($this->configService->isLocalInstance($member->getInstance()) && !$this->configService->isLocalInstance($newOwner->getInstance())) @@ -242,6 +238,4 @@ class CircleLeave implements return $newOwner; } - } - diff --git a/lib/FederatedItems/CircleSettings.php b/lib/FederatedItems/CircleSettings.php index 7013a4c5..4f58f588 100644 --- a/lib/FederatedItems/CircleSettings.php +++ b/lib/FederatedItems/CircleSettings.php @@ -31,21 +31,17 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\CircleRequest; use OCA\Circles\IFederatedItem; use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class CircleSettings * * @package OCA\Circles\FederatedItems */ class CircleSettings implements IFederatedItem { - - use TNC22Deserialize; @@ -86,6 +82,4 @@ class CircleSettings implements IFederatedItem { */ public function result(FederatedEvent $event, array $results): void { } - } - diff --git a/lib/FederatedItems/Files/FileShare.php b/lib/FederatedItems/Files/FileShare.php index 62a986f1..b9a4d5b0 100644 --- a/lib/FederatedItems/Files/FileShare.php +++ b/lib/FederatedItems/Files/FileShare.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems\Files; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\UnknownTypeException; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; @@ -48,7 +47,6 @@ use OCA\Circles\Model\ShareWrapper; use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\EventService; - /** * Class FileShare * @@ -59,8 +57,6 @@ class FileShare implements IFederatedItemHighSeverity, IFederatedItemAsyncProcess, IFederatedItemMemberEmpty { - - use TStringTools; use TNC22Logger; @@ -196,6 +192,4 @@ class FileShare implements // $this->sendShareToContact($event, $circle, $contact['memberId'], $contact['emails']); // } } - } - diff --git a/lib/FederatedItems/Files/FileUnshare.php b/lib/FederatedItems/Files/FileUnshare.php index 964f7a06..b194d26b 100644 --- a/lib/FederatedItems/Files/FileUnshare.php +++ b/lib/FederatedItems/Files/FileUnshare.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems\Files; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\UnknownTypeException; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; @@ -46,7 +45,6 @@ use OCA\Circles\Model\ShareWrapper; use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\EventService; - /** * Class FileUnshare * @@ -57,8 +55,6 @@ class FileUnshare implements IFederatedItemHighSeverity, IFederatedItemAsyncProcess, IFederatedItemMemberEmpty { - - use TStringTools; use TNC22Logger; @@ -125,6 +121,4 @@ class FileUnshare implements */ public function result(FederatedEvent $event, array $results): void { } - } - diff --git a/lib/FederatedItems/ItemLock.php b/lib/FederatedItems/ItemLock.php index 2fe10ba0..0babe32b 100644 --- a/lib/FederatedItems/ItemLock.php +++ b/lib/FederatedItems/ItemLock.php @@ -31,18 +31,15 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Db\ShareLockRequest; use OCA\Circles\Exceptions\FederatedShareNotFoundException; use OCA\Circles\Exceptions\InvalidIdException; use OCA\Circles\IFederatedItem; -use OCA\Circles\IFederatedItemCircleNotRequired; use OCA\Circles\IFederatedItemDataRequestOnly; use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Federated\FederatedShare; - /** * Class ItemLock * @@ -51,14 +48,12 @@ use OCA\Circles\Model\Federated\FederatedShare; class ItemLock implements IFederatedItem, IFederatedItemDataRequestOnly { - - use TStringTools; - const STATUS_LOCKED = 'locked'; - const STATUS_ALREADY_LOCKED = 'already_locked'; - const STATUS_INSTANCE_LOCKED = 'instance_locked'; + public const STATUS_LOCKED = 'locked'; + public const STATUS_ALREADY_LOCKED = 'already_locked'; + public const STATUS_INSTANCE_LOCKED = 'instance_locked'; /** @var ShareLockRequest */ @@ -132,6 +127,4 @@ class ItemLock implements */ public function result(FederatedEvent $event, array $results): void { } - } - diff --git a/lib/FederatedItems/LoopbackTest.php b/lib/FederatedItems/LoopbackTest.php index 1eca1c17..fce737a5 100644 --- a/lib/FederatedItems/LoopbackTest.php +++ b/lib/FederatedItems/LoopbackTest.php @@ -31,14 +31,12 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use OCA\Circles\IFederatedItem; use OCA\Circles\IFederatedItemAsyncProcess; use OCA\Circles\IFederatedItemLoopbackTest; use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class LoopbackTest * @@ -48,10 +46,8 @@ class LoopbackTest implements IFederatedItem, IFederatedItemAsyncProcess, IFederatedItemLoopbackTest { - - - const VERIFY = 17; - const MANAGE = 42; + public const VERIFY = 17; + public const MANAGE = 42; /** @@ -83,6 +79,4 @@ class LoopbackTest implements */ public function result(FederatedEvent $event, array $results): void { } - } - diff --git a/lib/FederatedItems/MassiveMemberAdd.php b/lib/FederatedItems/MassiveMemberAdd.php index dbe94571..38830e45 100644 --- a/lib/FederatedItems/MassiveMemberAdd.php +++ b/lib/FederatedItems/MassiveMemberAdd.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; @@ -43,7 +42,6 @@ use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Helpers\MemberHelper; use OCA\Circles\Model\Member; - /** * Class MemberAdd * @@ -54,8 +52,6 @@ class MassiveMemberAdd extends SingleMemberAdd implements IFederatedItemAsyncProcess, IFederatedItemHighSeverity, IFederatedItemMemberEmpty { - - use TStringTools; use TNC22Logger; @@ -117,6 +113,4 @@ class MassiveMemberAdd extends SingleMemberAdd implements $this->eventService->memberAdded($event, $results); } } - } - diff --git a/lib/FederatedItems/MemberDisplayName.php b/lib/FederatedItems/MemberDisplayName.php index 62d9446a..22807795 100644 --- a/lib/FederatedItems/MemberDisplayName.php +++ b/lib/FederatedItems/MemberDisplayName.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\MemberRequest; use OCA\Circles\Exceptions\FederatedItemBadRequestException; @@ -46,7 +45,6 @@ use OCA\Circles\Service\EventService; use OCA\Circles\Service\MembershipService; use OCA\Circles\StatusCode; - /** * Class MemberDisplayName * @@ -56,8 +54,6 @@ class MemberDisplayName implements IFederatedItem, IFederatedItemHighSeverity, IFederatedItemMemberEmpty { - - use TNC22Deserialize; @@ -143,6 +139,4 @@ class MemberDisplayName implements public function result(FederatedEvent $event, array $results): void { $this->eventService->memberNameEdited($event, $results); } - } - diff --git a/lib/FederatedItems/MemberLevel.php b/lib/FederatedItems/MemberLevel.php index 512eaa87..22ea6cc0 100644 --- a/lib/FederatedItems/MemberLevel.php +++ b/lib/FederatedItems/MemberLevel.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Deserialize; use OCA\Circles\Db\MemberRequest; use OCA\Circles\Exceptions\FederatedItemBadRequestException; @@ -49,7 +48,6 @@ use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\EventService; use OCA\Circles\Service\MembershipService; - /** * Class MemberLevel * @@ -59,8 +57,6 @@ class MemberLevel implements IFederatedItem, IFederatedItemHighSeverity, IFederatedItemMemberRequired { - - use TNC22Deserialize; @@ -216,6 +212,4 @@ class MemberLevel implements $memberHelper->mustBeMember(); $memberHelper->cannotBeOwner(); } - } - diff --git a/lib/FederatedItems/MemberRemove.php b/lib/FederatedItems/MemberRemove.php index fb5436a8..2c730d8b 100644 --- a/lib/FederatedItems/MemberRemove.php +++ b/lib/FederatedItems/MemberRemove.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use OCA\Circles\Db\MemberRequest; use OCA\Circles\Exceptions\FederatedItemException; use OCA\Circles\Exceptions\RequestBuilderException; @@ -44,7 +43,6 @@ use OCA\Circles\Model\Helpers\MemberHelper; use OCA\Circles\Service\EventService; use OCA\Circles\Service\MembershipService; - /** * Class MemberLevel * @@ -129,6 +127,4 @@ class MemberRemove implements public function result(FederatedEvent $event, array $results): void { $this->eventService->memberRemoved($event, $results); } - } - diff --git a/lib/FederatedItems/SharedItemsSync.php b/lib/FederatedItems/SharedItemsSync.php index 2d568ad1..c69323a5 100644 --- a/lib/FederatedItems/SharedItemsSync.php +++ b/lib/FederatedItems/SharedItemsSync.php @@ -31,14 +31,12 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use OCA\Circles\IFederatedItem; use OCA\Circles\IFederatedItemLimitedToInstanceWithMembership; use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Service\CircleEventService; - /** * Class SharesSync * @@ -50,7 +48,7 @@ class SharedItemsSync implements // TODO: testing that IFederatedItemLimitedToInstanceWithMembership is working (since multi-instance) -// TODO: implements IFederatedItemInstanceMember to the check procedure + // TODO: implements IFederatedItemInstanceMember to the check procedure /** @var CircleEventService */ private $circleEventService; @@ -84,6 +82,4 @@ class SharedItemsSync implements */ public function result(FederatedEvent $event, array $results): void { } - } - diff --git a/lib/FederatedItems/SingleMemberAdd.php b/lib/FederatedItems/SingleMemberAdd.php index dcd6a7f3..f71c42e7 100644 --- a/lib/FederatedItems/SingleMemberAdd.php +++ b/lib/FederatedItems/SingleMemberAdd.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\FederatedItems; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException; @@ -89,7 +88,6 @@ use OCP\IUserManager; use OCP\Mail\IEMailTemplate; use OCP\Util; - /** * Class MemberAdd * @@ -101,8 +99,6 @@ class SingleMemberAdd implements IFederatedItemHighSeverity, IFederatedItemMemberRequired, IFederatedItemMemberCheckNotRequired { - - use TNC22Deserialize; @@ -357,7 +353,6 @@ class SingleMemberAdd implements if ($member->getSingleId() !== '') { $userId = $member->getSingleId() . '@' . $member->getInstance(); $federatedUser = $this->federatedUserService->getFederatedUser($userId, Member::TYPE_SINGLE); - } else { $userId = $member->getUserId() . '@' . $member->getInstance(); $federatedUser = $this->federatedUserService->getFederatedUser( @@ -365,7 +360,6 @@ class SingleMemberAdd implements $member->getUserType() ); } - } catch (MemberNotFoundException $e) { throw new FederatedItemBadRequestException(StatusCode::$MEMBER_ADD[120], 120); } @@ -633,7 +627,6 @@ class SingleMemberAdd implements } try { - $template = $this->generateMailExitingShares($author, $circle->getName()); $this->fillMailExistingShares($template, $links); $this->sendMailExistingShares($template, $author, $recipient); @@ -676,7 +669,7 @@ class SingleMemberAdd implements private function getUnknownShares(DeprecatedMember $member): array { $allShares = $this->fileSharesRequest->getSharesForCircle($member->getCircleId()); $knownShares = array_map( - function(SharesToken $shareToken) { + function (SharesToken $shareToken) { return $shareToken->getShareId(); }, $this->tokensRequest->getTokensFromMember($member) @@ -711,8 +704,8 @@ class SingleMemberAdd implements $filename = basename($share['file_target']); return [ - 'author' => $author, - 'link' => $link, + 'author' => $author, + 'link' => $link, 'filename' => $filename ]; } @@ -804,9 +797,9 @@ class SingleMemberAdd implements $emailTemplate = $this->mailer->createEMailTemplate( 'sharebymail.RecipientPasswordNotification', [ - 'password' => $password, - 'author' => $author - ] + 'password' => $password, + 'author' => $author + ] ); $emailTemplate->setSubject( @@ -842,6 +835,4 @@ class SingleMemberAdd implements $message->useTemplate($emailTemplate); $this->mailer->send($message); } - } - diff --git a/lib/GlobalScale/AGlobalScaleEvent.php b/lib/GlobalScale/AGlobalScaleEvent.php index e7fb8db9..7e10cd37 100644 --- a/lib/GlobalScale/AGlobalScaleEvent.php +++ b/lib/GlobalScale/AGlobalScaleEvent.php @@ -1,4 +1,6 @@ -setInstance(''); } } - } - diff --git a/lib/GlobalScale/CircleCreate.php b/lib/GlobalScale/CircleCreate.php index 0de9d4b3..5d30ebaa 100644 --- a/lib/GlobalScale/CircleCreate.php +++ b/lib/GlobalScale/CircleCreate.php @@ -1,4 +1,6 @@ -mailer->createEMailTemplate( 'sharebymail.RecipientPasswordNotification', [ - 'filename' => $filename, - 'password' => $password, - 'initiator' => $initiatorDisplayName, - 'initiatorEmail' => $initiatorEmailAddress, - 'shareWith' => $shareWith, - ] + 'filename' => $filename, + 'password' => $password, + 'initiator' => $initiatorDisplayName, + 'initiatorEmail' => $initiatorEmailAddress, + 'shareWith' => $shareWith, + ] ); $emailTemplate->setSubject( @@ -398,11 +396,11 @@ class FileShare extends AGlobalScaleEvent { ) { $emailTemplate = $this->mailer->createEMailTemplate( 'circles.ShareNotification', [ - 'fileName' => $fileName, - 'fileLink' => $link, - 'author' => $author, - 'circleName' => $circleName, - ] + 'fileName' => $fileName, + 'fileLink' => $link, + 'author' => $author, + 'circleName' => $circleName, + ] ); $emailTemplate->addHeader(); @@ -431,7 +429,7 @@ class FileShare extends AGlobalScaleEvent { ); return array_map( - function(DeprecatedMember $member) { + function (DeprecatedMember $member) { return $member->getUserId(); }, $members ); @@ -477,6 +475,4 @@ class FileShare extends AGlobalScaleEvent { return $share; } - - } diff --git a/lib/GlobalScale/FileUnshare.php b/lib/GlobalScale/FileUnshare.php index 02aaa460..3bc0c93f 100644 --- a/lib/GlobalScale/FileUnshare.php +++ b/lib/GlobalScale/FileUnshare.php @@ -1,4 +1,6 @@ -syncCircle($circle, $event->getSource()); $this->removeDeprecateMembers($circle, $event->getSource()); } - } @@ -129,7 +128,6 @@ class GlobalSync extends AGlobalScaleEvent { } } } - } @@ -168,6 +166,4 @@ class GlobalSync extends AGlobalScaleEvent { throw new MemberDoesNotExistException(); } - } - diff --git a/lib/GlobalScale/MemberAdd.php b/lib/GlobalScale/MemberAdd.php index df7ba6c4..201cefec 100644 --- a/lib/GlobalScale/MemberAdd.php +++ b/lib/GlobalScale/MemberAdd.php @@ -1,4 +1,6 @@ -setData( new SimpleDataStore( [ - 'password' => $password, + 'password' => $password, 'passwordByMail' => $sendPasswordByMail ] ) @@ -157,7 +157,7 @@ class MemberAdd extends AGlobalScaleEvent { $shares = $this->generateUnknownSharesLinks($circle, $member, $password); $result = [ 'unknownShares' => $shares, - 'cachedName' => $cachedName + 'cachedName' => $cachedName ]; if ($member->getType() === DeprecatedMember::TYPE_CONTACT @@ -277,7 +277,7 @@ class MemberAdd extends AGlobalScaleEvent { private function getUnknownShares(DeprecatedMember $member): array { $allShares = $this->fileSharesRequest->getSharesForCircle($member->getCircleId()); $knownShares = array_map( - function(SharesToken $shareToken) { + function (SharesToken $shareToken) { return $shareToken->getShareId(); }, $this->tokensRequest->getTokensFromMember($member) @@ -312,8 +312,8 @@ class MemberAdd extends AGlobalScaleEvent { $filename = basename($share['file_target']); return [ - 'author' => $author, - 'link' => $link, + 'author' => $author, + 'link' => $link, 'filename' => $filename ]; } @@ -405,9 +405,9 @@ class MemberAdd extends AGlobalScaleEvent { $emailTemplate = $this->mailer->createEMailTemplate( 'sharebymail.RecipientPasswordNotification', [ - 'password' => $password, - 'author' => $author - ] + 'password' => $password, + 'author' => $author + ] ); $emailTemplate->setSubject( @@ -443,5 +443,4 @@ class MemberAdd extends AGlobalScaleEvent { $message->useTemplate($emailTemplate); $this->mailer->send($message); } - } diff --git a/lib/GlobalScale/MemberJoin.php b/lib/GlobalScale/MemberJoin.php index 3c3df19e..81e62c37 100644 --- a/lib/GlobalScale/MemberJoin.php +++ b/lib/GlobalScale/MemberJoin.php @@ -1,4 +1,6 @@ -fileSharesRequest->removeSharesFromMember($member); $this->tokensRequest->removeTokensFromMember($member); } - } - diff --git a/lib/GlobalScale/MemberUpdate.php b/lib/GlobalScale/MemberUpdate.php index 51723912..ff9273ae 100644 --- a/lib/GlobalScale/MemberUpdate.php +++ b/lib/GlobalScale/MemberUpdate.php @@ -1,4 +1,6 @@ -remoteStreamService->getAppSignatory(); $href = $this->interfaceService->getCloudPath('circles.Remote.appService'); $info = [ - 'app' => Application::APP_ID, - 'name' => Application::APP_NAME, - 'token' => Application::APP_TOKEN, + 'app' => Application::APP_ID, + 'name' => Application::APP_NAME, + 'token' => Application::APP_TOKEN, 'version' => $this->configService->getAppValue('installed_version'), - 'api' => Application::APP_API + 'api' => Application::APP_API ]; } catch (UnknownInterfaceException | SignatoryException $e) { return $response; @@ -132,6 +127,4 @@ class WebfingerHandler implements IHandler { return $response->addLink(Application::APP_REL, 'application/json', $href, [], $info); } - } - diff --git a/lib/IBroadcaster.php b/lib/IBroadcaster.php index de8f26da..8d2baf5a 100644 --- a/lib/IBroadcaster.php +++ b/lib/IBroadcaster.php @@ -3,7 +3,6 @@ namespace OCA\Circles; - use OCA\Circles\Model\DeprecatedCircle; use OCA\Circles\Model\DeprecatedMember; use OCA\Circles\Model\SharingFrame; @@ -74,5 +73,4 @@ interface IBroadcaster { * @param DeprecatedMember $member */ public function deleteShareToMember(SharingFrame $frame, DeprecatedMember $member); - } diff --git a/lib/IFederatedItem.php b/lib/IFederatedItem.php index f8d31c78..d611fcc9 100644 --- a/lib/IFederatedItem.php +++ b/lib/IFederatedItem.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles; - use OCA\Circles\Exceptions\FederatedItemException; use OCA\Circles\Model\Federated\FederatedEvent; - /** * Interface IFederatedItem * @@ -60,6 +58,4 @@ interface IFederatedItem { * @param array $results */ public function result(FederatedEvent $event, array $results): void; - } - diff --git a/lib/IFederatedItemAsyncProcess.php b/lib/IFederatedItemAsyncProcess.php index 8a1329e3..b94a6fb2 100644 --- a/lib/IFederatedItemAsyncProcess.php +++ b/lib/IFederatedItemAsyncProcess.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemAsyncProcess * * @package OCA\Circles */ interface IFederatedItemAsyncProcess { - } - diff --git a/lib/IFederatedItemCircleCheckNotRequired.php b/lib/IFederatedItemCircleCheckNotRequired.php index a5e67773..d0a29d9f 100644 --- a/lib/IFederatedItemCircleCheckNotRequired.php +++ b/lib/IFederatedItemCircleCheckNotRequired.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemBypassLocalCircleCheck * * @package OCA\Circles */ interface IFederatedItemCircleCheckNotRequired { - } - diff --git a/lib/IFederatedItemDataRequestOnly.php b/lib/IFederatedItemDataRequestOnly.php index c6475a44..23bab1c0 100644 --- a/lib/IFederatedItemDataRequestOnly.php +++ b/lib/IFederatedItemDataRequestOnly.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemRequestOnly * * @package OCA\Circles */ interface IFederatedItemDataRequestOnly { - } - diff --git a/lib/IFederatedItemHighSeverity.php b/lib/IFederatedItemHighSeverity.php index e646e974..a33b0bcf 100644 --- a/lib/IFederatedItemHighSeverity.php +++ b/lib/IFederatedItemHighSeverity.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemHighSeverity * * @package OCA\Circles */ interface IFederatedItemHighSeverity { - } - diff --git a/lib/IFederatedItemInitiatorCheckNotRequired.php b/lib/IFederatedItemInitiatorCheckNotRequired.php index cf1b01e6..51ea6ca4 100644 --- a/lib/IFederatedItemInitiatorCheckNotRequired.php +++ b/lib/IFederatedItemInitiatorCheckNotRequired.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemBypassInitiatorCheck * * @package OCA\Circles */ interface IFederatedItemInitiatorCheckNotRequired { - } - diff --git a/lib/IFederatedItemInitiatorMembershipNotRequired.php b/lib/IFederatedItemInitiatorMembershipNotRequired.php index 53249a85..b310dcf7 100644 --- a/lib/IFederatedItemInitiatorMembershipNotRequired.php +++ b/lib/IFederatedItemInitiatorMembershipNotRequired.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemInitiatorMembershipNotRequired * * @package OCA\Circles */ interface IFederatedItemInitiatorMembershipNotRequired { - } - diff --git a/lib/IFederatedItemLimitedToInstanceWithMembership.php b/lib/IFederatedItemLimitedToInstanceWithMembership.php index f9b98e63..00333aa5 100644 --- a/lib/IFederatedItemLimitedToInstanceWithMembership.php +++ b/lib/IFederatedItemLimitedToInstanceWithMembership.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemInstanceMember * * @package OCA\Circles */ interface IFederatedItemLimitedToInstanceWithMembership { - } - diff --git a/lib/IFederatedItemLoopbackTest.php b/lib/IFederatedItemLoopbackTest.php index 0a39b787..a14e1081 100644 --- a/lib/IFederatedItemLoopbackTest.php +++ b/lib/IFederatedItemLoopbackTest.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemLoopbackTest * * @package OCA\Circles */ interface IFederatedItemLoopbackTest { - } - diff --git a/lib/IFederatedItemMemberCheckNotRequired.php b/lib/IFederatedItemMemberCheckNotRequired.php index ee4acb66..16add2bd 100644 --- a/lib/IFederatedItemMemberCheckNotRequired.php +++ b/lib/IFederatedItemMemberCheckNotRequired.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemBypassLocalCircleCheck * * @package OCA\Circles */ interface IFederatedItemMemberCheckNotRequired { - } - diff --git a/lib/IFederatedItemMemberEmpty.php b/lib/IFederatedItemMemberEmpty.php index 9c9ef5cc..a3bf8398 100644 --- a/lib/IFederatedItemMemberEmpty.php +++ b/lib/IFederatedItemMemberEmpty.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemMustHaveMember * * @package OCA\Circles */ interface IFederatedItemMemberEmpty { - } - diff --git a/lib/IFederatedItemMemberOptional.php b/lib/IFederatedItemMemberOptional.php index 618042a3..90c5f37a 100644 --- a/lib/IFederatedItemMemberOptional.php +++ b/lib/IFederatedItemMemberOptional.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemMustHaveMember * * @package OCA\Circles */ interface IFederatedItemMemberOptional { - } - diff --git a/lib/IFederatedItemMemberRequired.php b/lib/IFederatedItemMemberRequired.php index 55f214b6..affcc5e8 100644 --- a/lib/IFederatedItemMemberRequired.php +++ b/lib/IFederatedItemMemberRequired.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemMustHaveMember * * @package OCA\Circles */ interface IFederatedItemMemberRequired { - } - diff --git a/lib/IFederatedItemMustBeInitializedLocally.php b/lib/IFederatedItemMustBeInitializedLocally.php index 7d4f2dbd..04f52b2a 100644 --- a/lib/IFederatedItemMustBeInitializedLocally.php +++ b/lib/IFederatedItemMustBeInitializedLocally.php @@ -31,13 +31,10 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemMustBeInitializedLocally * * @package OCA\Circles */ interface IFederatedItemMustBeInitializedLocally { - } - diff --git a/lib/IFederatedItemShareManagement.php b/lib/IFederatedItemShareManagement.php index e23c0067..34b9a6eb 100644 --- a/lib/IFederatedItemShareManagement.php +++ b/lib/IFederatedItemShareManagement.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles; - use OCA\Circles\Model\Federated\FederatedEvent; - /** * Interface IFederatedItemShareManagement * @@ -134,6 +132,4 @@ interface IFederatedItemShareManagement { * @param FederatedEvent $event */ public function shareDelete(FederatedEvent $event): void; - } - diff --git a/lib/IFederatedItemSharedItem.php b/lib/IFederatedItemSharedItem.php index 4dfb47cc..15e7cf1b 100644 --- a/lib/IFederatedItemSharedItem.php +++ b/lib/IFederatedItemSharedItem.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedItemSharedItem * @@ -40,6 +39,4 @@ namespace OCA\Circles; interface IFederatedItemSharedItem { // meaning that the verify() will be run on the instance that locked the item, not on the main instance of the Circle. - } - diff --git a/lib/IFederatedModel.php b/lib/IFederatedModel.php index 9355595a..0e346fe5 100644 --- a/lib/IFederatedModel.php +++ b/lib/IFederatedModel.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Interface IFederatedModel * @@ -48,6 +47,4 @@ interface IFederatedModel { * @return bool */ public function isLocal(): bool; - } - diff --git a/lib/IFederatedSync.php b/lib/IFederatedSync.php index ba1a0ddb..38fe2438 100644 --- a/lib/IFederatedSync.php +++ b/lib/IFederatedSync.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; - /** * Interface IFederatedSync * @@ -53,6 +51,4 @@ interface IFederatedSync { * @param SimpleDataStore $data */ public function import(SimpleDataStore $data): void; - } - diff --git a/lib/IFederatedUser.php b/lib/IFederatedUser.php index 639444f3..2d29c2a4 100644 --- a/lib/IFederatedUser.php +++ b/lib/IFederatedUser.php @@ -31,17 +31,14 @@ declare(strict_types=1); namespace OCA\Circles; - use OCA\Circles\Model\Circle; - /** * Interface IFederatedUser * * @package OCA\Circles */ interface IFederatedUser extends IFederatedModel { - public function getSingleId(): string; public function getUserId(): string; @@ -51,6 +48,4 @@ interface IFederatedUser extends IFederatedModel { public function getDisplayName(): string; public function getBasedOn(): ?Circle; - } - diff --git a/lib/IMemberships.php b/lib/IMemberships.php index 43b28069..452ab5dc 100644 --- a/lib/IMemberships.php +++ b/lib/IMemberships.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles; - use OCA\Circles\Model\Membership; /** @@ -57,6 +56,4 @@ interface IMemberships { * @return Membership[] */ public function getMemberships(): array; - } - diff --git a/lib/ISearch.php b/lib/ISearch.php index bf5165db..3300bbe5 100644 --- a/lib/ISearch.php +++ b/lib/ISearch.php @@ -31,10 +31,8 @@ declare(strict_types=1); namespace OCA\Circles; - use OCA\Circles\Model\FederatedUser; - /** * Interface ISearch * @@ -48,6 +46,4 @@ interface ISearch { * @return FederatedUser[] */ public function search(string $needle): array; - } - diff --git a/lib/Listeners/DeprecatedListener.php b/lib/Listeners/DeprecatedListener.php index dd00a503..3da31f73 100644 --- a/lib/Listeners/DeprecatedListener.php +++ b/lib/Listeners/DeprecatedListener.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use Exception; use OCA\Circles\Db\CircleRequest; @@ -51,7 +50,6 @@ use OCA\Circles\Service\FederatedEventService; use OCA\Circles\Service\FederatedUserService; use OCP\IUser; - /** * Class DeprecatedListener * @@ -126,8 +124,5 @@ class DeprecatedListener { } catch (Exception $e) { } } - } - } - diff --git a/lib/Listeners/Examples/ExampleAddingCircleMember.php b/lib/Listeners/Examples/ExampleAddingCircleMember.php index 2a2df05e..3e8f5195 100644 --- a/lib/Listeners/Examples/ExampleAddingCircleMember.php +++ b/lib/Listeners/Examples/ExampleAddingCircleMember.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Examples; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use OCA\Circles\AppInfo\Application; use OCA\Circles\Events\AddingCircleMemberEvent; @@ -42,15 +41,12 @@ use OCA\Circles\Service\ConfigService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class ExampleAddingCircleMember * * @package OCA\Circles\Listeners\Files */ class ExampleAddingCircleMember implements IEventListener { - - use TNC22Logger; @@ -97,7 +93,7 @@ class ExampleAddingCircleMember implements IEventListener { . Member::$DEF_LEVEL[$member->getLevel()] . '; '; $memberships = array_map( - function(Membership $membership) { + function (Membership $membership) { return $membership->getCircleId(); }, $circle->getMemberships() ); @@ -109,7 +105,7 @@ class ExampleAddingCircleMember implements IEventListener { if ($member->getUserType() === Member::TYPE_CIRCLE) { $basedOn = $member->getBasedOn(); $members = array_map( - function(Member $member) { + function (Member $member) { return $member->getUserId() . ' (' . Member::$TYPE[$member->getUserType()] . ')'; }, $basedOn->getInheritedMembers() ); @@ -120,6 +116,4 @@ class ExampleAddingCircleMember implements IEventListener { $this->log(3, $prefix . $info); } - } - diff --git a/lib/Listeners/Examples/ExampleMembershipsCreated.php b/lib/Listeners/Examples/ExampleMembershipsCreated.php index 950c6bca..441e68aa 100644 --- a/lib/Listeners/Examples/ExampleMembershipsCreated.php +++ b/lib/Listeners/Examples/ExampleMembershipsCreated.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Examples; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; @@ -44,15 +43,12 @@ use OCA\Circles\Service\ConfigService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class ExampleMembershipsCreated * * @package OCA\Circles\Listeners\Files */ class ExampleMembershipsCreated implements IEventListener { - - use TStringTools; use TNC22Logger; @@ -96,7 +92,7 @@ class ExampleMembershipsCreated implements IEventListener { $prefix = '[Example Event] (ExampleMembershipsCreated) '; $memberships = array_map( - function(Membership $membership) { + function (Membership $membership) { $inheritance = ($membership->getInheritanceDepth() > 1) ? 'an inherited member' : 'a direct member'; try { @@ -115,6 +111,4 @@ class ExampleMembershipsCreated implements IEventListener { $this->log(3, $prefix . implode('. ', $memberships)); } - } - diff --git a/lib/Listeners/Examples/ExampleMembershipsRemoved.php b/lib/Listeners/Examples/ExampleMembershipsRemoved.php index 96e2784b..a46901ad 100644 --- a/lib/Listeners/Examples/ExampleMembershipsRemoved.php +++ b/lib/Listeners/Examples/ExampleMembershipsRemoved.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Examples; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; @@ -44,15 +43,12 @@ use OCA\Circles\Service\ConfigService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class ExampleMembershipsRemoved * * @package OCA\Circles\Listeners\Files */ class ExampleMembershipsRemoved implements IEventListener { - - use TStringTools; use TNC22Logger; @@ -96,7 +92,7 @@ class ExampleMembershipsRemoved implements IEventListener { $prefix = '[Example Event] (ExampleMembershipsRemoved) '; $memberships = array_map( - function(Membership $membership) { + function (Membership $membership) { $inheritance = ($membership->getInheritanceDepth() > 1) ? 'an inherited member' : 'a direct member'; try { @@ -115,6 +111,4 @@ class ExampleMembershipsRemoved implements IEventListener { $this->log(3, $prefix . implode('. ', $memberships)); } - } - diff --git a/lib/Listeners/Examples/ExampleRequestingCircleMember.php b/lib/Listeners/Examples/ExampleRequestingCircleMember.php index 96cfcde7..da1053dd 100644 --- a/lib/Listeners/Examples/ExampleRequestingCircleMember.php +++ b/lib/Listeners/Examples/ExampleRequestingCircleMember.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Examples; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use OCA\Circles\AppInfo\Application; use OCA\Circles\Events\CircleGenericEvent; @@ -41,15 +40,12 @@ use OCA\Circles\Service\ConfigService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class ExampleRequestingCircleMember * * @package OCA\Circles\Listeners\Examples */ class ExampleRequestingCircleMember implements IEventListener { - - use TNC22Logger; @@ -97,6 +93,4 @@ class ExampleRequestingCircleMember implements IEventListener { $this->log(3, $prefix . $info); } - } - diff --git a/lib/Listeners/Files/AddingMember.php b/lib/Listeners/Files/AddingMember.php index 92ec83a4..13c0ebf5 100644 --- a/lib/Listeners/Files/AddingMember.php +++ b/lib/Listeners/Files/AddingMember.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Files; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; @@ -47,15 +46,12 @@ use OCA\Circles\Service\ShareWrapperService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class AddingMember * * @package OCA\Circles\Listeners\Files */ class AddingMember implements IEventListener { - - use TStringTools; use TNC22Logger; @@ -140,7 +136,7 @@ class AddingMember implements IEventListener { $result[$member->getId()] = [ 'shares' => $files, - 'mails' => $this->getMailAddressesFromContact($member) + 'mails' => $this->getMailAddressesFromContact($member) ]; } @@ -165,6 +161,4 @@ class AddingMember implements IEventListener { return []; } } - } - diff --git a/lib/Listeners/Files/MemberAdded.php b/lib/Listeners/Files/MemberAdded.php index 385202aa..4e6a9687 100644 --- a/lib/Listeners/Files/MemberAdded.php +++ b/lib/Listeners/Files/MemberAdded.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Files; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; @@ -50,15 +49,12 @@ use OCP\Mail\IEMailTemplate; use OCP\Mail\IMailer; use OCP\Util; - /** * Class MemberAdded * * @package OCA\Circles\Listeners\Files */ class MemberAdded implements IEventListener { - - use TStringTools; use TNC22Logger; @@ -177,7 +173,7 @@ class MemberAdded implements IEventListener { foreach ($shares as $share) { $links[] = [ 'filename' => $share->getFileTarget(), - 'link' => $share->getShareToken()->getLink() + 'link' => $share->getShareToken()->getLink() ]; } @@ -248,6 +244,4 @@ class MemberAdded implements IEventListener { $this->mailer->send($message); } - } - diff --git a/lib/Listeners/Files/MembershipsRemoved.php b/lib/Listeners/Files/MembershipsRemoved.php index e0fea493..0f133143 100644 --- a/lib/Listeners/Files/MembershipsRemoved.php +++ b/lib/Listeners/Files/MembershipsRemoved.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Files; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\CirclesManager; use OCA\Circles\Db\ShareWrapperRequest; @@ -55,15 +54,12 @@ use OCA\Circles\Service\FederatedUserService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class MembershipsRemoved * * @package OCA\Circles\Listeners\Files */ class MembershipsRemoved implements IEventListener { - - use TStringTools; @@ -134,6 +130,4 @@ class MembershipsRemoved implements IEventListener { } } } - } - diff --git a/lib/Listeners/Files/RemovingMember.php b/lib/Listeners/Files/RemovingMember.php index 6e34a0e5..7de96a4b 100644 --- a/lib/Listeners/Files/RemovingMember.php +++ b/lib/Listeners/Files/RemovingMember.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Files; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\AppInfo\Application; @@ -44,15 +43,12 @@ use OCA\Circles\Service\ShareTokenService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class RemovingMember * * @package OCA\Circles\Listeners\Files */ class RemovingMember implements IEventListener { - - use TStringTools; use TNC22Logger; @@ -101,7 +97,7 @@ class RemovingMember implements IEventListener { $singleIds = array_merge( [$circle->getSingleId()], array_map( - function(Membership $membership) { + function (Membership $membership) { return $membership->getCircleId(); }, $circle->getMemberships() ) @@ -126,6 +122,4 @@ class RemovingMember implements IEventListener { } } } - } - diff --git a/lib/Listeners/GroupCreated.php b/lib/Listeners/GroupCreated.php index 5f466630..7096d0e4 100644 --- a/lib/Listeners/GroupCreated.php +++ b/lib/Listeners/GroupCreated.php @@ -37,7 +37,6 @@ use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; use OCP\Group\Events\GroupCreatedEvent; - /** * Class GroupCreated * @@ -74,6 +73,4 @@ class GroupCreated implements IEventListener { } catch (Exception $e) { } } - } - diff --git a/lib/Listeners/GroupDeleted.php b/lib/Listeners/GroupDeleted.php index 0e5153d1..2c2ed8e5 100644 --- a/lib/Listeners/GroupDeleted.php +++ b/lib/Listeners/GroupDeleted.php @@ -37,7 +37,6 @@ use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; use OCP\Group\Events\GroupDeletedEvent; - /** * Class GroupDeleted * @@ -74,6 +73,4 @@ class GroupDeleted implements IEventListener { } catch (Exception $e) { } } - } - diff --git a/lib/Listeners/GroupMemberAdded.php b/lib/Listeners/GroupMemberAdded.php index e71aa80d..cc09a0b2 100644 --- a/lib/Listeners/GroupMemberAdded.php +++ b/lib/Listeners/GroupMemberAdded.php @@ -31,14 +31,12 @@ declare(strict_types=1); namespace OCA\Circles\Listeners; - use Exception; use OCA\Circles\Service\SyncService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; use OCP\Group\Events\UserAddedEvent; - /** * Class GroupMemberAdded * @@ -76,6 +74,4 @@ class GroupMemberAdded implements IEventListener { } catch (Exception $e) { } } - } - diff --git a/lib/Listeners/GroupMemberRemoved.php b/lib/Listeners/GroupMemberRemoved.php index b7a20864..e5d26307 100644 --- a/lib/Listeners/GroupMemberRemoved.php +++ b/lib/Listeners/GroupMemberRemoved.php @@ -37,7 +37,6 @@ use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; use OCP\Group\Events\UserRemovedEvent; - /** * Class GroupMemberRemoved * @@ -75,6 +74,4 @@ class GroupMemberRemoved implements IEventListener { } catch (Exception $e) { } } - } - diff --git a/lib/Listeners/Notifications/RequestingMember.php b/lib/Listeners/Notifications/RequestingMember.php index 01728bcf..b2f78036 100644 --- a/lib/Listeners/Notifications/RequestingMember.php +++ b/lib/Listeners/Notifications/RequestingMember.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Listeners\Notifications; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use OCA\Circles\AppInfo\Application; use OCA\Circles\Events\CircleGenericEvent; @@ -41,15 +40,12 @@ use OCA\Circles\Service\NotificationService; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; - /** * Class RequestingMember * * @package OCA\Circles\Listeners\Notifications */ class RequestingMember implements IEventListener { - - use TNC22Logger; @@ -85,7 +81,4 @@ class RequestingMember implements IEventListener { $this->notificationService->notificationInvited($member); } } - - } - diff --git a/lib/Listeners/UserCreated.php b/lib/Listeners/UserCreated.php index c767d3e4..489a54e1 100644 --- a/lib/Listeners/UserCreated.php +++ b/lib/Listeners/UserCreated.php @@ -37,7 +37,6 @@ use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; use OCP\User\Events\UserCreatedEvent; - /** * Class UserCreated * @@ -75,6 +74,4 @@ class UserCreated implements IEventListener { } catch (Exception $e) { } } - } - diff --git a/lib/Listeners/UserDeleted.php b/lib/Listeners/UserDeleted.php index 8ae6597f..cf563fb1 100644 --- a/lib/Listeners/UserDeleted.php +++ b/lib/Listeners/UserDeleted.php @@ -37,7 +37,6 @@ use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; use OCP\User\Events\UserDeletedEvent; - /** * Class UserDeleted * @@ -74,6 +73,4 @@ class UserDeleted implements IEventListener { } catch (Exception $e) { } } - } - diff --git a/lib/Migration/ImportOwncloudCustomGroups.php b/lib/Migration/ImportOwncloudCustomGroups.php index 76e090cc..b36d7129 100644 --- a/lib/Migration/ImportOwncloudCustomGroups.php +++ b/lib/Migration/ImportOwncloudCustomGroups.php @@ -224,5 +224,4 @@ class ImportOwncloudCustomGroups implements IRepairStep { $alreadyImported = $this->config->getAppValue('circles', 'imported_custom_groups', 'false'); return !$alreadyImported && $this->connection->tableExists('custom_group') && $this->connection->tableExists('custom_group_member'); } - } diff --git a/lib/Migration/Migration.php b/lib/Migration/Migration.php index 489d30ce..7ef0bd2c 100644 --- a/lib/Migration/Migration.php +++ b/lib/Migration/Migration.php @@ -31,25 +31,20 @@ declare(strict_types=1); namespace OCA\Circles\Migration; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use Exception; -use OCA\Circles\AppInfo\Application; use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\MigrationService; use OCA\Circles\Service\OutputService; use OCP\Migration\IOutput; use OCP\Migration\IRepairStep; - /** * Class Migration * * @package OCA\Circles\Migration */ class Migration implements IRepairStep { - - use TNC22Logger; @@ -104,6 +99,4 @@ class Migration implements IRepairStep { $this->e($e); } } - } - diff --git a/lib/Migration/Version0022Date20220526111723.php b/lib/Migration/Version0022Date20220526111723.php index 180a3d42..6979160f 100644 --- a/lib/Migration/Version0022Date20220526111723.php +++ b/lib/Migration/Version0022Date20220526111723.php @@ -37,7 +37,6 @@ use OCP\DB\ISchemaWrapper; use OCP\Migration\IOutput; use OCP\Migration\SimpleMigrationStep; - /** * Class Version0021Date20210105123456 * @@ -87,6 +86,4 @@ class Version0022Date20220526111723 extends SimpleMigrationStep { return $schema; } - } - diff --git a/lib/Migration/Version0022Date20220526113601.php b/lib/Migration/Version0022Date20220526113601.php index 67bcc0ff..0bb15764 100644 --- a/lib/Migration/Version0022Date20220526113601.php +++ b/lib/Migration/Version0022Date20220526113601.php @@ -39,7 +39,6 @@ use OCP\IDBConnection; use OCP\Migration\IOutput; use OCP\Migration\SimpleMigrationStep; - /** * Class Version0022Date20220526113601 * @@ -76,86 +75,86 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 4, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 4, + 'unsigned' => true, + ] ); $table->addColumn( 'unique_id', 'string', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->addColumn( 'name', 'string', [ - 'notnull' => true, - 'length' => 127, - ] + 'notnull' => true, + 'length' => 127, + ] ); $table->addColumn( 'display_name', 'string', [ - 'notnull' => false, - 'default' => '', - 'length' => 127 - ] + 'notnull' => false, + 'default' => '', + 'length' => 127 + ] ); $table->addColumn( 'sanitized_name', 'string', [ - 'notnull' => false, - 'default' => '', - 'length' => 127 - ] + 'notnull' => false, + 'default' => '', + 'length' => 127 + ] ); $table->addColumn( 'instance', 'string', [ - 'notnull' => false, - 'default' => '', - 'length' => 255 - ] + 'notnull' => false, + 'default' => '', + 'length' => 255 + ] ); $table->addColumn( 'config', 'integer', [ - 'notnull' => false, - 'length' => 11, - 'unsigned' => true - ] + 'notnull' => false, + 'length' => 11, + 'unsigned' => true + ] ); $table->addColumn( 'source', 'integer', [ - 'notnull' => false, - 'length' => 5, - 'unsigned' => true - ] + 'notnull' => false, + 'length' => 5, + 'unsigned' => true + ] ); $table->addColumn( 'settings', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'description', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'creation', 'datetime', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); $table->addColumn( 'contact_addressbook', 'integer', [ - 'notnull' => false, - 'unsigned' => true, - 'length' => 7, - ] + 'notnull' => false, + 'unsigned' => true, + 'length' => 7, + ] ); $table->addColumn( 'contact_groupname', 'string', [ - 'notnull' => false, - 'length' => 127, - ] + 'notnull' => false, + 'length' => 127, + ] ); $table->setPrimaryKey(['id']); @@ -175,99 +174,99 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 4, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 4, + 'unsigned' => true, + ] ); $table->addColumn( 'single_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'circle_id', 'string', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->addColumn( 'member_id', Types::STRING, [ - 'notnull' => false, - 'length' => 31, - ] + 'notnull' => false, + 'length' => 31, + ] ); $table->addColumn( 'user_id', 'string', [ - 'notnull' => true, - 'length' => 127, - ] + 'notnull' => true, + 'length' => 127, + ] ); $table->addColumn( 'user_type', 'smallint', [ - 'notnull' => true, - 'length' => 1, - 'default' => 1, - ] + 'notnull' => true, + 'length' => 1, + 'default' => 1, + ] ); $table->addColumn( 'instance', 'string', [ - 'default' => '', - 'length' => 255 - ] + 'default' => '', + 'length' => 255 + ] ); $table->addColumn( 'invited_by', 'string', [ - 'notnull' => false, - 'length' => 31, - ] + 'notnull' => false, + 'length' => 31, + ] ); $table->addColumn( 'level', 'smallint', [ - 'notnull' => true, - 'length' => 1, - ] + 'notnull' => true, + 'length' => 1, + ] ); $table->addColumn( 'status', 'string', [ - 'notnull' => false, - 'length' => 15, - ] + 'notnull' => false, + 'length' => 15, + ] ); $table->addColumn( 'note', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'cached_name', 'string', [ - 'notnull' => false, - 'length' => 255, - 'default' => '' - ] + 'notnull' => false, + 'length' => 255, + 'default' => '' + ] ); $table->addColumn( 'cached_update', 'datetime', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); $table->addColumn( 'contact_id', 'string', [ - 'notnull' => false, - 'length' => 127, - ] + 'notnull' => false, + 'length' => 127, + ] ); $table->addColumn( 'contact_meta', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'joined', 'datetime', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); $table->setPrimaryKey(['id']); @@ -287,53 +286,53 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table = $schema->createTable('circles_remote'); $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 4, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 4, + 'unsigned' => true, + ] ); $table->addColumn( 'type', 'string', [ - 'notnull' => true, - 'length' => 15, - 'default' => 'Unknown' - ] + 'notnull' => true, + 'length' => 15, + 'default' => 'Unknown' + ] ); $table->addColumn( 'interface', 'integer', [ - 'notnull' => true, - 'length' => 1, - 'default' => 0 - ] + 'notnull' => true, + 'length' => 1, + 'default' => 0 + ] ); $table->addColumn( 'uid', 'string', [ - 'notnull' => false, - 'length' => 20, - ] + 'notnull' => false, + 'length' => 20, + ] ); $table->addColumn( 'instance', 'string', [ - 'notnull' => false, - 'length' => 127, - ] + 'notnull' => false, + 'length' => 127, + ] ); $table->addColumn( 'href', 'string', [ - 'notnull' => false, - 'length' => 254, - ] + 'notnull' => false, + 'length' => 254, + ] ); $table->addColumn( 'item', 'text', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); $table->addColumn( 'creation', 'datetime', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); $table->setPrimaryKey(['id']); @@ -350,61 +349,61 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table = $schema->createTable('circles_event'); $table->addColumn( 'token', 'string', [ - 'notnull' => false, - 'length' => 63, - ] + 'notnull' => false, + 'length' => 63, + ] ); $table->addColumn( 'event', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'result', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'instance', 'string', [ - 'length' => 255, - 'notnull' => false - ] + 'length' => 255, + 'notnull' => false + ] ); $table->addColumn( 'interface', 'integer', [ - 'notnull' => true, - 'length' => 1, - 'default' => 0 - ] + 'notnull' => true, + 'length' => 1, + 'default' => 0 + ] ); $table->addColumn( 'severity', 'integer', [ - 'length' => 3, - 'notnull' => false - ] + 'length' => 3, + 'notnull' => false + ] ); $table->addColumn( 'retry', 'integer', [ - 'length' => 3, - 'notnull' => false - ] + 'length' => 3, + 'notnull' => false + ] ); $table->addColumn( 'status', 'integer', [ - 'length' => 3, - 'notnull' => false - ] + 'length' => 3, + 'notnull' => false + ] ); $table->addColumn( 'updated', 'datetime', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); $table->addColumn( 'creation', 'bigint', [ - 'length' => 14, - 'notnull' => false - ] + 'length' => 14, + 'notnull' => false + ] ); $table->addUniqueIndex(['token', 'instance']); @@ -419,46 +418,46 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table->addColumn( 'circle_id', 'string', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->addColumn( 'single_id', 'string', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->addColumn( 'level', 'integer', [ - 'notnull' => true, - 'length' => 1, - 'unsigned' => true - ] + 'notnull' => true, + 'length' => 1, + 'unsigned' => true + ] ); $table->addColumn( 'inheritance_first', 'string', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->addColumn( 'inheritance_last', 'string', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->addColumn( 'inheritance_depth', 'integer', [ - 'notnull' => true, - 'length' => 2, - 'unsigned' => true - ] + 'notnull' => true, + 'length' => 2, + 'unsigned' => true + ] ); $table->addColumn( 'inheritance_path', 'text', [ - 'notnull' => true - ] + 'notnull' => true + ] ); $table->addIndex(['single_id']); @@ -476,53 +475,53 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table = $schema->createTable('circles_token'); $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 11, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 11, + 'unsigned' => true, + ] ); $table->addColumn( 'share_id', 'integer', [ - 'notnull' => false, - 'length' => 11 - ] + 'notnull' => false, + 'length' => 11 + ] ); $table->addColumn( 'circle_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'single_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'member_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'token', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'password', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'accepted', 'integer', [ - 'notnull' => false, - 'length' => 1 - ] + 'notnull' => false, + 'length' => 1 + ] ); $table->setPrimaryKey(['id']); @@ -537,52 +536,52 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table = $schema->createTable('circles_mount'); $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 11, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 11, + 'unsigned' => true, + ] ); $table->addColumn( 'mount_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'circle_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'single_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'token', 'string', [ - 'notnull' => false, - 'length' => 63 - ] + 'notnull' => false, + 'length' => 63 + ] ); $table->addColumn( 'parent', 'integer', [ - 'notnull' => false, - 'length' => 11 - ] + 'notnull' => false, + 'length' => 11 + ] ); $table->addColumn( 'mountpoint', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'mountpoint_hash', 'string', [ - 'notnull' => false, - 'length' => 64 - ] + 'notnull' => false, + 'length' => 64 + ] ); $table->setPrimaryKey(['id']); @@ -597,34 +596,34 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table = $schema->createTable('circles_mountpoint'); $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 11, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 11, + 'unsigned' => true, + ] ); $table->addColumn( 'mount_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'single_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'mountpoint', 'text', [ - 'notnull' => false - ] + 'notnull' => false + ] ); $table->addColumn( 'mountpoint_hash', 'string', [ - 'notnull' => false, - 'length' => 64 - ] + 'notnull' => false, + 'length' => 64 + ] ); $table->setPrimaryKey(['id']); @@ -639,29 +638,29 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { $table = $schema->createTable('circles_share_lock'); $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 4, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 4, + 'unsigned' => true, + ] ); $table->addColumn( 'item_id', 'string', [ - 'notnull' => true, - 'length' => 31 - ] + 'notnull' => true, + 'length' => 31 + ] ); $table->addColumn( 'circle_id', 'string', [ - 'notnull' => true, - 'length' => 31 - ] + 'notnull' => true, + 'length' => 31 + ] ); $table->addColumn( 'instance', 'string', [ - 'notnull' => true, - 'length' => 127, - ] + 'notnull' => true, + 'length' => 127, + ] ); $table->setPrimaryKey(['id']); @@ -670,6 +669,4 @@ class Version0022Date20220526113601 extends SimpleMigrationStep { return $schema; } - } - diff --git a/lib/Migration/Version0022Date20220703115023.php b/lib/Migration/Version0022Date20220703115023.php index de113046..0e5fb129 100644 --- a/lib/Migration/Version0022Date20220703115023.php +++ b/lib/Migration/Version0022Date20220703115023.php @@ -38,7 +38,6 @@ use OCP\IDBConnection; use OCP\Migration\IOutput; use OCP\Migration\SimpleMigrationStep; - /** * Class Version0022Date20220526113601 * @@ -71,16 +70,16 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { if (!$table->hasColumn('updated')) { $table->addColumn( 'updated', 'datetime', [ - 'notnull' => false, - ] + 'notnull' => false, + ] ); } if (!$table->hasColumn('retry')) { $table->addColumn( 'retry', 'integer', [ - 'length' => 3, - 'notnull' => false - ] + 'length' => 3, + 'notnull' => false + ] ); } } @@ -90,10 +89,10 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { if (!$table->hasColumn('invited_by')) { $table->addColumn( 'invited_by', 'string', [ - 'notnull' => false, - 'default' => '', - 'length' => 31, - ] + 'notnull' => false, + 'default' => '', + 'length' => 31, + ] ); } } @@ -104,10 +103,10 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { if (!$table->hasColumn('sanitized_name')) { $table->addColumn( 'sanitized_name', 'string', [ - 'notnull' => false, - 'default' => '', - 'length' => 127 - ] + 'notnull' => false, + 'default' => '', + 'length' => 127 + ] ); $table->addIndex(['sanitized_name']); @@ -119,27 +118,27 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { $table = $schema->getTable('circles_membership'); $table->changeColumn( 'circle_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'single_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'inheritance_first', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'inheritance_last', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); } @@ -148,21 +147,21 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { $table = $schema->getTable('circles_mount'); $table->changeColumn( 'mount_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'circle_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'single_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); } @@ -171,15 +170,15 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { $table = $schema->getTable('circles_mountpoint'); $table->changeColumn( 'mount_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'single_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); } @@ -188,15 +187,15 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { $table = $schema->getTable('circles_share_lock'); $table->changeColumn( 'item_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); $table->changeColumn( 'circle_id', [ - 'notnull' => true, - 'length' => 31, - ] + 'notnull' => true, + 'length' => 31, + ] ); } @@ -209,53 +208,53 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { $table = $schema->createTable('circles_token'); $table->addColumn( 'id', 'integer', [ - 'autoincrement' => true, - 'notnull' => true, - 'length' => 11, - 'unsigned' => true, - ] + 'autoincrement' => true, + 'notnull' => true, + 'length' => 11, + 'unsigned' => true, + ] ); $table->addColumn( 'share_id', 'integer', [ - 'notnull' => false, - 'length' => 11 - ] + 'notnull' => false, + 'length' => 11 + ] ); $table->addColumn( 'circle_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'single_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'member_id', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'token', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'password', 'string', [ - 'notnull' => false, - 'length' => 31 - ] + 'notnull' => false, + 'length' => 31 + ] ); $table->addColumn( 'accepted', 'integer', [ - 'notnull' => false, - 'length' => 1 - ] + 'notnull' => false, + 'length' => 1 + ] ); $table->setPrimaryKey(['id']); @@ -265,6 +264,4 @@ class Version0022Date20220703115023 extends SimpleMigrationStep { return $schema; } - } - diff --git a/lib/Model/BaseCircle.php b/lib/Model/BaseCircle.php index 4f168a52..093b80a2 100644 --- a/lib/Model/BaseCircle.php +++ b/lib/Model/BaseCircle.php @@ -31,23 +31,22 @@ use OCA\Circles\AppInfo\Application; use OCP\IL10N; class BaseCircle { - - const CIRCLES_SETTINGS_DEFAULT = [ + public const CIRCLES_SETTINGS_DEFAULT = [ 'password_enforcement' => 'false', - 'password_single' => '', - 'allow_links' => 'false', - 'allow_links_auto' => 'false', - 'allow_links_files' => 'false' + 'password_single' => '', + 'allow_links' => 'false', + 'allow_links_auto' => 'false', + 'allow_links_files' => 'false' ]; - const CIRCLES_PERSONAL = 1; - const CIRCLES_SECRET = 2; - const CIRCLES_CLOSED = 4; - const CIRCLES_PUBLIC = 8; + public const CIRCLES_PERSONAL = 1; + public const CIRCLES_SECRET = 2; + public const CIRCLES_CLOSED = 4; + public const CIRCLES_PUBLIC = 8; - const CIRCLES_ALL = 15; + public const CIRCLES_ALL = 15; - const SHORT_UNIQUE_ID_LENGTH = 14; + public const SHORT_UNIQUE_ID_LENGTH = 14; /** @var int */ private $id; @@ -356,7 +355,7 @@ class BaseCircle { public function setSettings($settings, bool $all = false) { if (is_array($settings)) { $this->settings = $settings; - } else if (is_string($settings)) { + } elseif (is_string($settings)) { $this->settings = (array)json_decode($settings, true); } @@ -376,7 +375,6 @@ class BaseCircle { * @return array|string */ public function getSettings($json = false) { - if ($json) { return json_encode($this->settings); } @@ -580,7 +578,6 @@ class BaseCircle { * @return integer */ public static function typeInt($type) { - if (is_numeric($type)) { return (int)$type; } diff --git a/lib/Model/BaseMember.php b/lib/Model/BaseMember.php index 2c212cad..146f2af0 100644 --- a/lib/Model/BaseMember.php +++ b/lib/Model/BaseMember.php @@ -33,24 +33,23 @@ use OCA\Circles\Service\MiscService; use OCP\IL10N; class BaseMember implements JsonSerializable { + public const LEVEL_NONE = 0; + public const LEVEL_MEMBER = 1; + public const LEVEL_MODERATOR = 4; + public const LEVEL_ADMIN = 8; + public const LEVEL_OWNER = 9; - const LEVEL_NONE = 0; - const LEVEL_MEMBER = 1; - const LEVEL_MODERATOR = 4; - const LEVEL_ADMIN = 8; - const LEVEL_OWNER = 9; + public const STATUS_NONMEMBER = 'Unknown'; + public const STATUS_INVITED = 'Invited'; + public const STATUS_REQUEST = 'Requesting'; + public const STATUS_MEMBER = 'Member'; + public const STATUS_BLOCKED = 'Blocked'; + public const STATUS_KICKED = 'Removed'; - const STATUS_NONMEMBER = 'Unknown'; - const STATUS_INVITED = 'Invited'; - const STATUS_REQUEST = 'Requesting'; - const STATUS_MEMBER = 'Member'; - const STATUS_BLOCKED = 'Blocked'; - const STATUS_KICKED = 'Removed'; - - const TYPE_USER = 1; - const TYPE_GROUP = 2; - const TYPE_MAIL = 3; - const TYPE_CONTACT = 4; + public const TYPE_USER = 1; + public const TYPE_GROUP = 2; + public const TYPE_MAIL = 3; + public const TYPE_CONTACT = 4; /** @var string */ private $circleUniqueId; @@ -411,18 +410,18 @@ class BaseMember implements JsonSerializable { public function jsonSerialize() { return [ - 'circle_id' => $this->getCircleId(), - 'member_id' => $this->getMemberId(), - 'user_id' => $this->getUserId(), - 'user_type' => $this->getType(), - 'cached_name' => $this->getCachedName(), - 'contact_id' => $this->getContactId(), - 'level' => $this->getLevel(), + 'circle_id' => $this->getCircleId(), + 'member_id' => $this->getMemberId(), + 'user_id' => $this->getUserId(), + 'user_type' => $this->getType(), + 'cached_name' => $this->getCachedName(), + 'contact_id' => $this->getContactId(), + 'level' => $this->getLevel(), 'level_string' => $this->getLevelString(), - 'status' => $this->getStatus(), - 'instance' => $this->getInstance(), - 'note' => $this->getNote(), - 'joined' => $this->getJoined() + 'status' => $this->getStatus(), + 'instance' => $this->getInstance(), + 'note' => $this->getNote(), + 'joined' => $this->getJoined() ]; } diff --git a/lib/Model/Circle.php b/lib/Model/Circle.php index 644680ca..d9b20dc3 100644 --- a/lib/Model/Circle.php +++ b/lib/Model/Circle.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\INC22QueryRow; use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\IDeserializable; @@ -43,7 +42,6 @@ use OCA\Circles\Exceptions\CircleNotFoundException; use OCA\Circles\Exceptions\OwnerNotFoundException; use OCA\Circles\IMemberships; - /** * Class Circle * @@ -73,37 +71,35 @@ use OCA\Circles\IMemberships; * @package OCA\Circles\Model */ class Circle extends ManagedModel implements IMemberships, IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; use TNC22Deserialize; - const FLAGS_SHORT = 1; - const FLAGS_LONG = 2; + public const FLAGS_SHORT = 1; + public const FLAGS_LONG = 2; // specific value - const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default. - const CFG_SINGLE = 1; // Circle with only one single member. - const CFG_PERSONAL = 2; // Personal circle, only the owner can see it. + public const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default. + public const CFG_SINGLE = 1; // Circle with only one single member. + public const CFG_PERSONAL = 2; // Personal circle, only the owner can see it. // bitwise - const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited - const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it - const CFG_OPEN = 16; // Circle is open, people can join - const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted - const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator - const CFG_FRIEND = 128; // Members of the circle can invite their friends - const CFG_PROTECTED = 256; // Password protected to join/request - const CFG_NO_OWNER = 512; // no owner, only members - const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity - const CFG_BACKEND = 2048; // Fully hidden, only backend Circles - const CFG_LOCAL = 4096; // Local even on GlobalScale - const CFG_ROOT = 8192; // Circle cannot be inside another Circle - const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle - const CFG_FEDERATED = 32768; // Federated - const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle + public const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited + public const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it + public const CFG_OPEN = 16; // Circle is open, people can join + public const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted + public const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator + public const CFG_FRIEND = 128; // Members of the circle can invite their friends + public const CFG_PROTECTED = 256; // Password protected to join/request + public const CFG_NO_OWNER = 512; // no owner, only members + public const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity + public const CFG_BACKEND = 2048; // Fully hidden, only backend Circles + public const CFG_LOCAL = 4096; // Local even on GlobalScale + public const CFG_ROOT = 8192; // Circle cannot be inside another Circle + public const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle + public const CFG_FEDERATED = 32768; // Federated + public const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle public static $DEF_CFG_MAX = 131071; @@ -115,20 +111,20 @@ class Circle extends ManagedModel implements IMemberships, IDeserializable, INC2 * @var array */ public static $DEF_CFG = [ - 1 => 'S|Single', - 2 => 'P|Personal', - 4 => 'Y|System', - 8 => 'V|Visible', - 16 => 'O|Open', - 32 => 'I|Invite', - 64 => 'JR|Join Request', - 128 => 'F|Friends', - 256 => 'PP|Password Protected', - 512 => 'NO|No Owner', - 1024 => 'H|Hidden', - 2048 => 'T|Backend', - 4096 => 'L|Local', - 8192 => 'T|Root', + 1 => 'S|Single', + 2 => 'P|Personal', + 4 => 'Y|System', + 8 => 'V|Visible', + 16 => 'O|Open', + 32 => 'I|Invite', + 64 => 'JR|Join Request', + 128 => 'F|Friends', + 256 => 'PP|Password Protected', + 512 => 'NO|No Owner', + 1024 => 'H|Hidden', + 2048 => 'T|Backend', + 4096 => 'L|Local', + 8192 => 'T|Root', 16384 => 'CI|Circle Invite', 32768 => 'F|Federated', 65536 => 'M|Nountpoint' @@ -142,11 +138,11 @@ class Circle extends ManagedModel implements IMemberships, IDeserializable, INC2 * @var array */ public static $DEF_SOURCE = [ - 1 => 'Nextcloud User', - 2 => 'Nextcloud Group', - 4 => 'Email Address', - 8 => 'Contact', - 16 => 'Circle', + 1 => 'Nextcloud User', + 2 => 'Nextcloud Group', + 4 => 'Email Address', + 8 => 'Contact', + 16 => 'Circle', 10001 => 'Circles App', 10002 => 'Admin Command Line' ]; @@ -743,18 +739,18 @@ class Circle extends ManagedModel implements IMemberships, IDeserializable, INC2 */ public function jsonSerialize(): array { $arr = [ - 'id' => $this->getSingleId(), - 'name' => $this->getName(), - 'displayName' => $this->getDisplayName(), + 'id' => $this->getSingleId(), + 'name' => $this->getName(), + 'displayName' => $this->getDisplayName(), 'sanitizedName' => $this->getSanitizedName(), - 'source' => $this->getSource(), - 'population' => $this->getPopulation(), - 'config' => $this->getConfig(), - 'description' => $this->getDescription(), - 'settings' => $this->getSettings(), - 'url' => $this->getUrl(), - 'creation' => $this->getCreation(), - 'initiator' => ($this->hasInitiator()) ? $this->getInitiator() : null + 'source' => $this->getSource(), + 'population' => $this->getPopulation(), + 'config' => $this->getConfig(), + 'description' => $this->getDescription(), + 'settings' => $this->getSettings(), + 'url' => $this->getUrl(), + 'creation' => $this->getCreation(), + 'initiator' => ($this->hasInitiator()) ? $this->getInitiator() : null ]; if ($this->hasOwner()) { @@ -850,7 +846,7 @@ class Circle extends ManagedModel implements IMemberships, IDeserializable, INC2 $config = []; foreach (array_keys(Circle::$DEF_CFG) as $def) { if ($circle->isConfig($def)) { - list($short, $long) = explode('|', Circle::$DEF_CFG[$def]); + [$short, $long] = explode('|', Circle::$DEF_CFG[$def]); switch ($display) { case self::FLAGS_SHORT: @@ -866,6 +862,4 @@ class Circle extends ManagedModel implements IMemberships, IDeserializable, INC2 return $config; } - } - diff --git a/lib/Model/DavCard.php b/lib/Model/DavCard.php index ec92fcb8..112968e5 100644 --- a/lib/Model/DavCard.php +++ b/lib/Model/DavCard.php @@ -29,24 +29,20 @@ namespace OCA\Circles\Model; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use JsonSerializable; - /** * Class DavCard * * @package OCA\Circles\Model */ class DavCard implements JsonSerializable { - - use TArrayTools; - const TYPE_CONTACT = 1; - const TYPE_LOCAL = 2; + public const TYPE_CONTACT = 1; + public const TYPE_LOCAL = 2; // const TYPE_FEDERATED = 3; @@ -334,10 +330,10 @@ class DavCard implements JsonSerializable { */ private function parseDav(string $dav): array { $result = [ - 'UID' => '', - 'FN' => '', - 'EMAILS' => [], - 'CLOUDS' => [], + 'UID' => '', + 'FN' => '', + 'EMAILS' => [], + 'CLOUDS' => [], 'CATEGORIES' => [] ]; @@ -346,11 +342,11 @@ class DavCard implements JsonSerializable { if (trim($entry) === '' || strpos($entry, ':') === false) { continue; } - list($k, $v) = explode(':', $entry, 2); + [$k, $v] = explode(':', $entry, 2); $k = strtoupper($k); if (strpos($entry, ';') !== false) { - list($k) = explode(';', $entry, 2); + [$k] = explode(';', $entry, 2); } switch ($k) { @@ -382,7 +378,6 @@ class DavCard implements JsonSerializable { } return $result; - } @@ -392,16 +387,15 @@ class DavCard implements JsonSerializable { public function jsonSerialize(): array { return [ 'addressBookId' => $this->getAddressBookId(), - 'owner' => $this->getOwner(), - 'cardUri' => $this->getCardUri(), - 'contactId' => $this->getContactId(), - 'uniqueId' => $this->getUniqueId(), - 'fn' => $this->getFn(), - 'emails' => $this->getEmails(), - 'clouds' => $this->getClouds(), - 'groups' => $this->getGroups(), - 'userId' => $this->getUserId() + 'owner' => $this->getOwner(), + 'cardUri' => $this->getCardUri(), + 'contactId' => $this->getContactId(), + 'uniqueId' => $this->getUniqueId(), + 'fn' => $this->getFn(), + 'emails' => $this->getEmails(), + 'clouds' => $this->getClouds(), + 'groups' => $this->getGroups(), + 'userId' => $this->getUserId() ]; } - } diff --git a/lib/Model/DeprecatedCircle.php b/lib/Model/DeprecatedCircle.php index 11301f28..56b530fa 100644 --- a/lib/Model/DeprecatedCircle.php +++ b/lib/Model/DeprecatedCircle.php @@ -32,8 +32,6 @@ use OCA\Circles\Exceptions\CircleTypeNotValidException; use OCA\Circles\Exceptions\FederatedCircleNotAllowedException; class DeprecatedCircle extends BaseCircle implements JsonSerializable { - - use TArrayTools; @@ -85,23 +83,23 @@ class DeprecatedCircle extends BaseCircle implements JsonSerializable { public function jsonSerialize() { $json = [ - 'id' => $this->getId(), - 'name' => $this->getName(true), - 'alt_name' => $this->getAltName(), - 'owner' => $this->getOwner(), - 'user' => $this->getViewer(), - 'group' => $this->getGroupViewer(), - 'viewer' => $this->getHigherViewer(), - 'description' => $this->getDescription(), - 'settings' => $this->getSettings(), - 'type' => $this->getType(), - 'creation' => $this->getCreation(), - 'type_string' => $this->getTypeString(), + 'id' => $this->getId(), + 'name' => $this->getName(true), + 'alt_name' => $this->getAltName(), + 'owner' => $this->getOwner(), + 'user' => $this->getViewer(), + 'group' => $this->getGroupViewer(), + 'viewer' => $this->getHigherViewer(), + 'description' => $this->getDescription(), + 'settings' => $this->getSettings(), + 'type' => $this->getType(), + 'creation' => $this->getCreation(), + 'type_string' => $this->getTypeString(), 'type_long_string' => $this->getTypeLongString(), - 'unique_id' => $this->getUniqueId($this->fullJson), - 'members' => $this->getMembers(), - 'groups' => $this->getGroups(), - 'links' => $this->getLinks() + 'unique_id' => $this->getUniqueId($this->fullJson), + 'members' => $this->getMembers(), + 'groups' => $this->getGroups(), + 'links' => $this->getLinks() ]; if ($this->lightJson) { @@ -194,7 +192,6 @@ class DeprecatedCircle extends BaseCircle implements JsonSerializable { } return null; - } @@ -292,7 +289,7 @@ class DeprecatedCircle extends BaseCircle implements JsonSerializable { * @return int */ public static function convertTypeToConfig(int $type): int { - switch($type) { + switch ($type) { case DeprecatedCircle::CIRCLES_PERSONAL: return 2; case DeprecatedCircle::CIRCLES_SECRET: @@ -305,8 +302,4 @@ class DeprecatedCircle extends BaseCircle implements JsonSerializable { return 0; } - - } - - diff --git a/lib/Model/DeprecatedMember.php b/lib/Model/DeprecatedMember.php index 7965e9cd..a79146d7 100644 --- a/lib/Model/DeprecatedMember.php +++ b/lib/Model/DeprecatedMember.php @@ -31,18 +31,13 @@ use OCA\Circles\Exceptions\MemberAlreadyExistsException; use OCA\Circles\Exceptions\MemberCantJoinCircleException; use OCA\Circles\Exceptions\MemberDoesNotExistException; use OCA\Circles\Exceptions\MemberIsBlockedException; -use OCA\Circles\Exceptions\MemberIsNotAdminException; use OCA\Circles\Exceptions\MemberIsNotModeratorException; -use OCA\Circles\Exceptions\MemberIsNotOwnerException; use OCA\Circles\Exceptions\MemberIsOwnerException; use OCA\Circles\Exceptions\MemberTypeCantEditLevelException; use OCA\Circles\Exceptions\ModeratorIsNotHighEnoughException; class DeprecatedMember extends BaseMember { - - public function inviteToCircle($circleType) { - if ($circleType === 0) { throw new CircleTypeNotValidException('Invalid circle type'); } @@ -61,7 +56,6 @@ class DeprecatedMember extends BaseMember { * @throws MemberCantJoinCircleException */ public function joinCircle($circleType) { - switch ($circleType) { case DeprecatedCircle::CIRCLES_SECRET: case DeprecatedCircle::CIRCLES_PUBLIC: @@ -79,7 +73,6 @@ class DeprecatedMember extends BaseMember { * Update status of member like he joined a public circle. */ public function addMemberToCircle() { - if ($this->getStatus() === DeprecatedMember::STATUS_NONMEMBER || $this->getStatus() === DeprecatedMember::STATUS_KICKED ) { @@ -93,7 +86,6 @@ class DeprecatedMember extends BaseMember { * (invite/request) */ private function joinClosedCircle() { - switch ($this->getStatus()) { case DeprecatedMember::STATUS_NONMEMBER: case DeprecatedMember::STATUS_KICKED: @@ -229,7 +221,6 @@ class DeprecatedMember extends BaseMember { * @throws MemberIsBlockedException */ public function hasToBeAbleToJoinTheCircle() { - if ($this->getLevel() > 0) { throw new MemberAlreadyExistsException( $this->l10n->t("You are already a member of this circle") @@ -248,7 +239,6 @@ class DeprecatedMember extends BaseMember { * @throws MemberAlreadyExistsException */ public function hasToBeInviteAble() { - if ($this->getLevel() > 0) { throw new MemberAlreadyExistsException( $this->l10n->t("The user is already a member of this circle") @@ -261,7 +251,4 @@ class DeprecatedMember extends BaseMember { ); } } - } - - diff --git a/lib/Model/Federated/EventWrapper.php b/lib/Model/Federated/EventWrapper.php index c6f73fb1..798ceb75 100644 --- a/lib/Model/Federated/EventWrapper.php +++ b/lib/Model/Federated/EventWrapper.php @@ -31,29 +31,25 @@ declare(strict_types=1); namespace OCA\Circles\Model\Federated; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\INC22QueryRow; use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use JsonSerializable; - /** * Class EventWrapper * * @package OCA\Circles\Model\Remote */ class EventWrapper implements INC22QueryRow, JsonSerializable { - - use TArrayTools; - const STATUS_INIT = 0; - const STATUS_FAILED = 1; - const STATUS_DONE = 8; - const STATUS_OVER = 9; + public const STATUS_INIT = 0; + public const STATUS_FAILED = 1; + public const STATUS_DONE = 8; + public const STATUS_OVER = 9; /** @var string */ @@ -84,7 +80,7 @@ class EventWrapper implements INC22QueryRow, JsonSerializable { private $creation; - function __construct() { + public function __construct() { $this->result = new SimpleDataStore(); } @@ -293,15 +289,15 @@ class EventWrapper implements INC22QueryRow, JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { return [ - 'token' => $this->getToken(), - 'instance' => $this->getInstance(), + 'token' => $this->getToken(), + 'instance' => $this->getInstance(), 'interface' => $this->getInterface(), - 'event' => $this->getEvent(), - 'result' => $this->getResult(), - 'severity' => $this->getSeverity(), - 'status' => $this->getStatus() + 'event' => $this->getEvent(), + 'result' => $this->getResult(), + 'severity' => $this->getSeverity(), + 'status' => $this->getStatus() // 'creation' => $this->getCreation() ]; } @@ -328,6 +324,4 @@ class EventWrapper implements INC22QueryRow, JsonSerializable { return $this; } - } - diff --git a/lib/Model/Federated/FederatedEvent.php b/lib/Model/Federated/FederatedEvent.php index 441b7bc5..5dcaf6c5 100644 --- a/lib/Model/Federated/FederatedEvent.php +++ b/lib/Model/Federated/FederatedEvent.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model\Federated; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; @@ -39,23 +38,20 @@ use JsonSerializable; use OCA\Circles\Model\Circle; use OCA\Circles\Model\Member; - /** * Class FederatedEvent * * @package OCA\Circles\Model\Federated */ class FederatedEvent implements JsonSerializable { + public const SEVERITY_LOW = 1; + public const SEVERITY_HIGH = 3; - - const SEVERITY_LOW = 1; - const SEVERITY_HIGH = 3; - - const BYPASS_CIRCLE = 1; - const BYPASS_LOCALCIRCLECHECK = 2; - const BYPASS_LOCALMEMBERCHECK = 4; - const BYPASS_INITIATORCHECK = 8; - const BYPASS_INITIATORMEMBERSHIP = 16; + public const BYPASS_CIRCLE = 1; + public const BYPASS_LOCALCIRCLECHECK = 2; + public const BYPASS_LOCALMEMBERCHECK = 4; + public const BYPASS_INITIATORCHECK = 8; + public const BYPASS_INITIATORMEMBERSHIP = 16; use TArrayTools; @@ -121,7 +117,7 @@ class FederatedEvent implements JsonSerializable { * * @param string $class */ - function __construct(string $class = '') { + public function __construct(string $class = '') { $this->class = $class; $this->params = new SimpleDataStore(); $this->data = new SimpleDataStore(); @@ -586,18 +582,18 @@ class FederatedEvent implements JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { $arr = [ - 'class' => $this->getClass(), + 'class' => $this->getClass(), 'severity' => $this->getSeverity(), - 'params' => $this->getParams(), - 'data' => $this->getData(), - 'result' => $this->getResult(), - 'origin' => $this->getOrigin(), - 'sender' => $this->getSender(), - 'itemId' => $this->getItemId(), - 'outcome' => $this->getOutcome(), - 'members' => $this->getMembers() + 'params' => $this->getParams(), + 'data' => $this->getData(), + 'result' => $this->getResult(), + 'origin' => $this->getOrigin(), + 'sender' => $this->getSender(), + 'itemId' => $this->getItemId(), + 'outcome' => $this->getOutcome(), + 'members' => $this->getMembers() ]; if ($this->hasCircle()) { @@ -609,6 +605,4 @@ class FederatedEvent implements JsonSerializable { return $arr; } - } - diff --git a/lib/Model/Federated/FederatedShare.php b/lib/Model/Federated/FederatedShare.php index aebbf5cf..44b52caa 100644 --- a/lib/Model/Federated/FederatedShare.php +++ b/lib/Model/Federated/FederatedShare.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model\Federated; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\INC22QueryRow; use ArtificialOwl\MySmallPhpTools\IDeserializable; use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; @@ -40,15 +39,12 @@ use JsonSerializable; use OCA\Circles\IFederatedModel; use OCA\Circles\Model\ManagedModel; - /** * Class FederatedShare * * @package OCA\Circles\Model\Federated */ class FederatedShare extends ManagedModel implements IFederatedModel, JsonSerializable, INC22QueryRow, IDeserializable { - - use TArrayTools; @@ -74,7 +70,7 @@ class FederatedShare extends ManagedModel implements IFederatedModel, JsonSerial /** * FederatedShare constructor. */ - function __construct() { + public function __construct() { } @@ -220,12 +216,10 @@ class FederatedShare extends ManagedModel implements IFederatedModel, JsonSerial */ public function jsonSerialize(): array { return [ - 'id' => $this->getId(), - 'itemId' => $this->getItemId(), + 'id' => $this->getId(), + 'itemId' => $this->getItemId(), 'circleId' => $this->getCircleId(), 'instance' => $this->getInstance() ]; } - } - diff --git a/lib/Model/Federated/RemoteInstance.php b/lib/Model/Federated/RemoteInstance.php index 95dd0142..f214b430 100644 --- a/lib/Model/Federated/RemoteInstance.php +++ b/lib/Model/Federated/RemoteInstance.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model\Federated; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\INC22QueryRow; use ArtificialOwl\MySmallPhpTools\Model\Nextcloud\nc22\NC22Signatory; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; @@ -39,22 +38,19 @@ use JsonSerializable; use OCA\Circles\Exceptions\RemoteNotFoundException; use OCA\Circles\Exceptions\RemoteUidException; - /** * Class AppService * * @package OCA\Circles\Model */ class RemoteInstance extends NC22Signatory implements INC22QueryRow, JsonSerializable { - - use TArrayTools; - const TYPE_UNKNOWN = 'Unknown'; // not trusted - const TYPE_PASSIVE = 'Passive'; // Minimum information about Federated Circles are broadcasted if a member belongs to the circle. - const TYPE_EXTERNAL = 'External'; // info about Federated Circles and their members are broadcasted if a member belongs to the circle. - const TYPE_TRUSTED = 'Trusted'; // everything about Federated Circles are broadcasted. - const TYPE_GLOBALSCALE = 'GlobalScale'; // every Circle is broadcasted, + public const TYPE_UNKNOWN = 'Unknown'; // not trusted + public const TYPE_PASSIVE = 'Passive'; // Minimum information about Federated Circles are broadcasted if a member belongs to the circle. + public const TYPE_EXTERNAL = 'External'; // info about Federated Circles and their members are broadcasted if a member belongs to the circle. + public const TYPE_TRUSTED = 'Trusted'; // everything about Federated Circles are broadcasted. + public const TYPE_GLOBALSCALE = 'GlobalScale'; // every Circle is broadcasted, public static $LIST_TYPE = [ self::TYPE_UNKNOWN, @@ -64,13 +60,13 @@ class RemoteInstance extends NC22Signatory implements INC22QueryRow, JsonSeriali self::TYPE_GLOBALSCALE ]; - const TEST = 'test'; - const INCOMING = 'incoming'; - const EVENT = 'event'; - const CIRCLES = 'circles'; - const CIRCLE = 'circle'; - const MEMBERS = 'members'; - const MEMBER = 'member'; + public const TEST = 'test'; + public const INCOMING = 'incoming'; + public const EVENT = 'event'; + public const CIRCLES = 'circles'; + public const CIRCLE = 'circle'; + public const MEMBERS = 'members'; + public const MEMBER = 'member'; /** @var int */ @@ -450,7 +446,7 @@ class RemoteInstance extends NC22Signatory implements INC22QueryRow, JsonSeriali $algo = ''; $authSigned = trim($this->get('auth-signed', $data), ':'); if (strpos($authSigned, ':') > 0) { - list($algo, $authSigned) = explode(':', $authSigned); + [$algo, $authSigned] = explode(':', $authSigned); } $this->setAuthSigned($authSigned) @@ -465,15 +461,15 @@ class RemoteInstance extends NC22Signatory implements INC22QueryRow, JsonSeriali */ public function jsonSerialize(): array { $data = [ - 'uid' => $this->getUid(true), - 'root' => $this->getRoot(), - 'event' => $this->getEvent(), + 'uid' => $this->getUid(true), + 'root' => $this->getRoot(), + 'event' => $this->getEvent(), 'incoming' => $this->getIncoming(), - 'test' => $this->getTest(), - 'circles' => $this->getCircles(), - 'circle' => $this->getCircle(), - 'members' => $this->getMembers(), - 'member' => $this->getMember(), + 'test' => $this->getTest(), + 'circles' => $this->getCircles(), + 'circle' => $this->getCircle(), + 'members' => $this->getMembers(), + 'member' => $this->getMember(), ]; if ($this->getAuthSigned() !== '') { @@ -510,6 +506,4 @@ class RemoteInstance extends NC22Signatory implements INC22QueryRow, JsonSeriali return $this; } - } - diff --git a/lib/Model/FederatedLink.php b/lib/Model/FederatedLink.php index 20812e83..da00ce89 100644 --- a/lib/Model/FederatedLink.php +++ b/lib/Model/FederatedLink.php @@ -29,18 +29,16 @@ namespace OCA\Circles\Model; use OCA\Circles\Exceptions\FederatedCircleStatusUpdateException; class FederatedLink implements \JsonSerializable { + public const STATUS_ERROR = -1; + public const STATUS_LINK_REMOVE = 0; + public const STATUS_LINK_DOWN = 1; + public const STATUS_LINK_SETUP = 2; + public const STATUS_REQUEST_DECLINED = 4; + public const STATUS_REQUEST_SENT = 5; + public const STATUS_LINK_REQUESTED = 6; + public const STATUS_LINK_UP = 9; - - const STATUS_ERROR = -1; - const STATUS_LINK_REMOVE = 0; - const STATUS_LINK_DOWN = 1; - const STATUS_LINK_SETUP = 2; - const STATUS_REQUEST_DECLINED = 4; - const STATUS_REQUEST_SENT = 5; - const STATUS_LINK_REQUESTED = 6; - const STATUS_LINK_UP = 9; - - const SHORT_UNIQUE_ID_LENGTH = 12; + public const SHORT_UNIQUE_ID_LENGTH = 12; /** @var int */ private $id; @@ -194,7 +192,6 @@ class FederatedLink implements \JsonSerializable { } return substr($this->circleUniqueId, 0, DeprecatedCircle::SHORT_UNIQUE_ID_LENGTH); - } @@ -309,7 +306,6 @@ class FederatedLink implements \JsonSerializable { $this->hasToBeValidStatusUpdateWhileRequestDeclined($status); $this->hasToBeValidStatusUpdateWhileLinkRequested($status); $this->hasToBeValidStatusUpdateWhileRequestSent($status); - } catch (FederatedCircleStatusUpdateException $e) { throw new FederatedCircleStatusUpdateException('The status could not be updated'); } @@ -322,7 +318,6 @@ class FederatedLink implements \JsonSerializable { * @throws FederatedCircleStatusUpdateException */ private function hasToBeValidStatusUpdateWhileLinkDown($status) { - if ($this->getStatus() === self::STATUS_LINK_DOWN) { return; } @@ -385,15 +380,15 @@ class FederatedLink implements \JsonSerializable { public function jsonSerialize() { - return array( - 'id' => $this->getId(), - 'token' => $this->getToken($this->fullJson), - 'address' => $this->getAddress(), - 'status' => $this->getStatus(), + return [ + 'id' => $this->getId(), + 'token' => $this->getToken($this->fullJson), + 'address' => $this->getAddress(), + 'status' => $this->getStatus(), 'circle_id' => $this->getCircleId(), 'unique_id' => $this->getUniqueId($this->fullJson), - 'creation' => $this->getCreation() - ); + 'creation' => $this->getCreation() + ]; } @@ -428,5 +423,4 @@ class FederatedLink implements \JsonSerializable { public static function fromJSON($json) { return self::fromArray(json_decode($json, true)); } - } diff --git a/lib/Model/FederatedUser.php b/lib/Model/FederatedUser.php index 1fa08a06..5b85945f 100644 --- a/lib/Model/FederatedUser.php +++ b/lib/Model/FederatedUser.php @@ -43,7 +43,6 @@ use OCA\Circles\Exceptions\UnknownInterfaceException; use OCA\Circles\IFederatedUser; use OCA\Circles\IMemberships; - /** * Class FederatedUser * @@ -55,8 +54,6 @@ class FederatedUser extends ManagedModel implements IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; use TNC22Deserialize; @@ -421,11 +418,11 @@ class FederatedUser extends ManagedModel implements */ public function jsonSerialize(): array { $arr = [ - 'id' => $this->getSingleId(), - 'userId' => $this->getUserId(), - 'userType' => $this->getUserType(), + 'id' => $this->getSingleId(), + 'userId' => $this->getUserId(), + 'userType' => $this->getUserType(), 'displayName' => $this->getDisplayName(), - 'instance' => $this->getManager()->fixInstance($this->getInstance()) + 'instance' => $this->getManager()->fixInstance($this->getInstance()) ]; if ($this->hasBasedOn()) { @@ -458,6 +455,4 @@ class FederatedUser extends ManagedModel implements || $this->getUserType() <> $member->getUserType() || (!$local && $this->getInstance() !== $member->getInstance())); } - } - diff --git a/lib/Model/FileCacheWrapper.php b/lib/Model/FileCacheWrapper.php index 3e67833e..535d83ee 100644 --- a/lib/Model/FileCacheWrapper.php +++ b/lib/Model/FileCacheWrapper.php @@ -39,15 +39,12 @@ use JsonSerializable; use OCA\Circles\Db\CoreQueryBuilder; use OCA\Circles\Exceptions\FileCacheNotFoundException; - /** * Class FileCacheWrapper * * @package OCA\Circles\Model */ class FileCacheWrapper extends ManagedModel implements INC22QueryRow, IDeserializable, JsonSerializable { - - use TArrayTools; @@ -427,22 +424,22 @@ class FileCacheWrapper extends ManagedModel implements INC22QueryRow, IDeseriali */ public function toCache(): array { return [ - 'fileid' => $this->getId(), - 'path' => $this->getPath(), - 'permissions' => $this->getPermissions(), - 'storage' => $this->getStorageId(), // strange, it is not !? - 'path_hash' => $this->getPathHash(), - 'parent' => $this->getParent(), - 'name' => $this->getName(), - 'mimetype' => $this->getMimeType(), - 'mimepart' => $this->getMimePart(), - 'size' => $this->getSize(), - 'mtime' => $this->getMTime(), - 'storage_mtime' => $this->getStorageMTime(), - 'encrypted' => $this->isEncrypted(), + 'fileid' => $this->getId(), + 'path' => $this->getPath(), + 'permissions' => $this->getPermissions(), + 'storage' => $this->getStorageId(), // strange, it is not !? + 'path_hash' => $this->getPathHash(), + 'parent' => $this->getParent(), + 'name' => $this->getName(), + 'mimetype' => $this->getMimeType(), + 'mimepart' => $this->getMimePart(), + 'size' => $this->getSize(), + 'mtime' => $this->getMTime(), + 'storage_mtime' => $this->getStorageMTime(), + 'encrypted' => $this->isEncrypted(), 'unencrypted_size' => $this->getUnencryptedSize(), - 'etag' => $this->getEtag(), - 'checksum' => $this->getChecksum() + 'etag' => $this->getEtag(), + 'checksum' => $this->getChecksum() ]; } @@ -537,25 +534,23 @@ class FileCacheWrapper extends ManagedModel implements INC22QueryRow, IDeseriali */ public function jsonSerialize(): array { return [ - 'id' => $this->getId(), - 'path' => $this->getPath(), - 'permissions' => $this->getPermissions(), - 'storage' => $this->getStorage(), - 'storageId' => $this->getStorageId(), - 'pathHash' => $this->getPathHash(), - 'parent' => $this->getParent(), - 'name' => $this->getName(), - 'mimeType' => $this->getMimeType(), - 'mimePart' => $this->getMimePart(), - 'size' => $this->getSize(), - 'mTime' => $this->getMTime(), - 'storageMTime' => $this->getStorageMTime(), - 'encrypted' => $this->isEncrypted(), + 'id' => $this->getId(), + 'path' => $this->getPath(), + 'permissions' => $this->getPermissions(), + 'storage' => $this->getStorage(), + 'storageId' => $this->getStorageId(), + 'pathHash' => $this->getPathHash(), + 'parent' => $this->getParent(), + 'name' => $this->getName(), + 'mimeType' => $this->getMimeType(), + 'mimePart' => $this->getMimePart(), + 'size' => $this->getSize(), + 'mTime' => $this->getMTime(), + 'storageMTime' => $this->getStorageMTime(), + 'encrypted' => $this->isEncrypted(), 'unencryptedSize' => $this->getUnencryptedSize(), - 'etag' => $this->getEtag(), - 'checksum' => $this->getChecksum() + 'etag' => $this->getEtag(), + 'checksum' => $this->getChecksum() ]; } - } - diff --git a/lib/Model/GlobalScale/GSEvent.php b/lib/Model/GlobalScale/GSEvent.php index 6190d441..39a0fce0 100644 --- a/lib/Model/GlobalScale/GSEvent.php +++ b/lib/Model/GlobalScale/GSEvent.php @@ -1,4 +1,6 @@ -type = $type; $this->local = $local; $this->force = $force; @@ -451,16 +449,16 @@ class GSEvent implements JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { $arr = [ - 'type' => $this->getType(), + 'type' => $this->getType(), 'severity' => $this->getSeverity(), - 'data' => $this->getData(), - 'result' => $this->getResult(), - 'key' => $this->getKey(), - 'source' => $this->getSource(), - 'force' => $this->isForced(), - 'async' => $this->isAsync() + 'data' => $this->getData(), + 'result' => $this->getResult(), + 'key' => $this->getKey(), + 'source' => $this->getSource(), + 'force' => $this->isForced(), + 'async' => $this->isAsync() ]; if ($this->hasCircle()) { @@ -474,7 +472,4 @@ class GSEvent implements JsonSerializable { return $arr; } - - } - diff --git a/lib/Model/GlobalScale/GSShare.php b/lib/Model/GlobalScale/GSShare.php index 1ab6bb36..8c2b3da2 100644 --- a/lib/Model/GlobalScale/GSShare.php +++ b/lib/Model/GlobalScale/GSShare.php @@ -1,4 +1,6 @@ - $this->getOwner(), - 'remote' => $protocol . '://' . $this->getInstance(), - 'token' => $this->getToken(), + 'owner' => $this->getOwner(), + 'remote' => $protocol . '://' . $this->getInstance(), + 'token' => $this->getToken(), 'share_token' => $this->getToken(), - 'password' => $this->getPassword(), - 'mountpoint' => $this->getMountPoint($userId) + 'password' => $this->getPassword(), + 'mountpoint' => $this->getMountPoint($userId) ]; } @@ -305,18 +303,16 @@ class GSShare implements JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { return [ - 'id' => $this->getId(), + 'id' => $this->getId(), 'defaultMountPoint' => $this->getDefaultMountPoint(), - 'mountPoint' => $this->getMountPoint(), - 'parent' => $this->getParent(), - 'owner' => $this->getOwner(), - 'instance' => $this->getInstance(), - 'token' => $this->getToken(), - 'password' => $this->getPassword() + 'mountPoint' => $this->getMountPoint(), + 'parent' => $this->getParent(), + 'owner' => $this->getOwner(), + 'instance' => $this->getInstance(), + 'token' => $this->getToken(), + 'password' => $this->getPassword() ]; } - } - diff --git a/lib/Model/GlobalScale/GSShareMountpoint.php b/lib/Model/GlobalScale/GSShareMountpoint.php index 8776f674..2cb146e8 100644 --- a/lib/Model/GlobalScale/GSShareMountpoint.php +++ b/lib/Model/GlobalScale/GSShareMountpoint.php @@ -1,4 +1,6 @@ - $this->getUserId(), - 'shareId' => $this->getShareId(), + 'userId' => $this->getUserId(), + 'shareId' => $this->getShareId(), 'mountPoint' => $this->getMountPoint(), ]; } - } - diff --git a/lib/Model/GlobalScale/GSWrapper.php b/lib/Model/GlobalScale/GSWrapper.php index 65ad5e7a..235b4aa9 100644 --- a/lib/Model/GlobalScale/GSWrapper.php +++ b/lib/Model/GlobalScale/GSWrapper.php @@ -1,4 +1,6 @@ - $this->getToken(), - 'event' => $this->getEvent(), + 'id' => $this->getToken(), + 'event' => $this->getEvent(), 'severity' => $this->getSeverity(), - 'status' => $this->getStatus(), + 'status' => $this->getStatus(), 'creation' => $this->getCreation() ]; @@ -237,6 +235,4 @@ class GSWrapper implements JsonSerializable { return $arr; } - } - diff --git a/lib/Model/Helpers/MemberHelper.php b/lib/Model/Helpers/MemberHelper.php index 6a001228..0ae5fb7b 100644 --- a/lib/Model/Helpers/MemberHelper.php +++ b/lib/Model/Helpers/MemberHelper.php @@ -37,7 +37,6 @@ use OCA\Circles\Exceptions\MemberLevelException; use OCA\Circles\Exceptions\ParseMemberLevelException; use OCA\Circles\Model\Member; - /** * Class MemberHelper * @@ -53,8 +52,6 @@ use OCA\Circles\Model\Member; * @package OCA\Circles\Model\Helpers */ class MemberHelper { - - use TArrayTools; @@ -186,7 +183,4 @@ class MemberHelper { public function mustBeHigherOrSameLevelThan(Member $compare) { $this->mustHaveLevelEqualOrAbove($compare->getLevel()); } - - } - diff --git a/lib/Model/ManagedModel.php b/lib/Model/ManagedModel.php index 2be98215..b2686cc5 100644 --- a/lib/Model/ManagedModel.php +++ b/lib/Model/ManagedModel.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model; - use OC; use OCA\Circles\IFederatedUser; @@ -41,9 +40,7 @@ use OCA\Circles\IFederatedUser; * @package OCA\Circles\Model */ class ManagedModel { - - - const ID_LENGTH = 31; + public const ID_LENGTH = 31; /** @var ModelManager */ @@ -80,6 +77,4 @@ class ManagedModel { $this->setInstance($orig->getInstance()); } - } - diff --git a/lib/Model/Member.php b/lib/Model/Member.php index 92f4287a..7f396190 100644 --- a/lib/Model/Member.php +++ b/lib/Model/Member.php @@ -48,7 +48,6 @@ use OCA\Circles\IFederatedUser; use OCA\Circles\IMemberships; use OCA\Circles\Model\Federated\RemoteInstance; - /** * Class Member * @@ -60,37 +59,35 @@ class Member extends ManagedModel implements IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; use TNC22Deserialize; - const LEVEL_NONE = 0; - const LEVEL_MEMBER = 1; - const LEVEL_MODERATOR = 4; - const LEVEL_ADMIN = 8; - const LEVEL_OWNER = 9; + public const LEVEL_NONE = 0; + public const LEVEL_MEMBER = 1; + public const LEVEL_MODERATOR = 4; + public const LEVEL_ADMIN = 8; + public const LEVEL_OWNER = 9; - const TYPE_SINGLE = 0; - const TYPE_USER = 1; - const TYPE_GROUP = 2; - const TYPE_MAIL = 4; - const TYPE_CONTACT = 8; - const TYPE_CIRCLE = 16; - const TYPE_APP = 10000; + public const TYPE_SINGLE = 0; + public const TYPE_USER = 1; + public const TYPE_GROUP = 2; + public const TYPE_MAIL = 4; + public const TYPE_CONTACT = 8; + public const TYPE_CIRCLE = 16; + public const TYPE_APP = 10000; - const APP_CIRCLES = 10001; - const APP_OCC = 10002; + public const APP_CIRCLES = 10001; + public const APP_OCC = 10002; public static $TYPE = [ - 0 => 'single', - 1 => 'user', - 2 => 'group', - 4 => 'mail', - 8 => 'contact', - 16 => 'circle', + 0 => 'single', + 1 => 'user', + 2 => 'group', + 4 => 'mail', + 8 => 'contact', + 16 => 'circle', 10000 => 'app' ]; @@ -99,10 +96,10 @@ class Member extends ManagedModel implements * * @see Capabilities::generateConstantsMember() */ - const STATUS_INVITED = 'Invited'; - const STATUS_REQUEST = 'Requesting'; - const STATUS_MEMBER = 'Member'; - const STATUS_BLOCKED = 'Blocked'; + public const STATUS_INVITED = 'Invited'; + public const STATUS_REQUEST = 'Requesting'; + public const STATUS_MEMBER = 'Member'; + public const STATUS_BLOCKED = 'Blocked'; /** @@ -891,21 +888,21 @@ class Member extends ManagedModel implements */ public function jsonSerialize(): array { $arr = [ - 'id' => $this->getId(), - 'circleId' => $this->getCircleId(), - 'singleId' => $this->getSingleId(), - 'userId' => $this->getUserId(), - 'userType' => $this->getUserType(), - 'instance' => $this->getManager()->fixInstance($this->getInstance()), - 'local' => $this->isLocal(), - 'level' => $this->getLevel(), - 'status' => $this->getStatus(), - 'displayName' => $this->getDisplayName(), + 'id' => $this->getId(), + 'circleId' => $this->getCircleId(), + 'singleId' => $this->getSingleId(), + 'userId' => $this->getUserId(), + 'userType' => $this->getUserType(), + 'instance' => $this->getManager()->fixInstance($this->getInstance()), + 'local' => $this->isLocal(), + 'level' => $this->getLevel(), + 'status' => $this->getStatus(), + 'displayName' => $this->getDisplayName(), 'displayUpdate' => $this->getDisplayUpdate(), - 'notes' => $this->getNotes(), - 'contactId' => $this->getContactId(), - 'contactMeta' => $this->getContactMeta(), - 'joined' => $this->getJoined() + 'notes' => $this->getNotes(), + 'contactId' => $this->getContactId(), + 'contactMeta' => $this->getContactMeta(), + 'joined' => $this->getJoined() ]; if ($this->hasInvitedBy()) { @@ -994,6 +991,4 @@ class Member extends ManagedModel implements return (int)$type; } - } - diff --git a/lib/Model/Membership.php b/lib/Model/Membership.php index d866470b..77e7c12f 100644 --- a/lib/Model/Membership.php +++ b/lib/Model/Membership.php @@ -38,15 +38,12 @@ use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use JsonSerializable; use OCA\Circles\Exceptions\MembershipNotFoundException; - /** * Class Membership * * @package OCA\Circles\Model */ class Membership extends ManagedModel implements IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; @@ -327,13 +324,13 @@ class Membership extends ManagedModel implements IDeserializable, INC22QueryRow, */ public function jsonSerialize(): array { $result = [ - 'singleId' => $this->getSingleId(), - 'circleId' => $this->getCircleId(), - 'circleConfig' => $this->getCircleConfig(), - 'level' => $this->getLevel(), + 'singleId' => $this->getSingleId(), + 'circleId' => $this->getCircleId(), + 'circleConfig' => $this->getCircleConfig(), + 'level' => $this->getLevel(), 'inheritanceFirst' => $this->getInheritanceFirst(), - 'inheritanceLast' => $this->getInheritanceLast(), - 'inheritancePath' => $this->getInheritancePath(), + 'inheritanceLast' => $this->getInheritanceLast(), + 'inheritancePath' => $this->getInheritancePath(), 'inheritanceDepth' => $this->getInheritanceDepth() ]; @@ -343,6 +340,4 @@ class Membership extends ManagedModel implements IDeserializable, INC22QueryRow, return $result; } - } - diff --git a/lib/Model/ModelManager.php b/lib/Model/ModelManager.php index 8cff0f4f..9a36771e 100644 --- a/lib/Model/ModelManager.php +++ b/lib/Model/ModelManager.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model; - use OCA\Circles\Db\CoreQueryBuilder; use OCA\Circles\Db\MemberRequest; use OCA\Circles\Db\MembershipRequest; @@ -220,7 +219,7 @@ class ModelManager { */ private function importIntoCircle(Circle $circle, array $data, string $path, string $prefix): void { switch ($path) { - case CoreQueryBuilder::OWNER; + case CoreQueryBuilder::OWNER: try { $owner = new Member(); $owner->importFromDatabase($data, $prefix); @@ -229,7 +228,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INITIATOR; + case CoreQueryBuilder::INITIATOR: try { $initiator = new Member(); $initiator->importFromDatabase($data, $prefix); @@ -238,7 +237,7 @@ class ModelManager { } break; - case CoreQueryBuilder::DIRECT_INITIATOR; + case CoreQueryBuilder::DIRECT_INITIATOR: try { $directInitiator = new Member(); $directInitiator->importFromDatabase($data, $prefix); @@ -258,7 +257,7 @@ class ModelManager { */ private function importIntoMember(Member $member, array $data, string $path, string $prefix): void { switch ($path) { - case CoreQueryBuilder::CIRCLE; + case CoreQueryBuilder::CIRCLE: try { $circle = new Circle(); $circle->importFromDatabase($data, $prefix); @@ -267,7 +266,7 @@ class ModelManager { } break; - case CoreQueryBuilder::BASED_ON; + case CoreQueryBuilder::BASED_ON: try { $circle = new Circle(); $circle->importFromDatabase($data, $prefix); @@ -276,7 +275,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INHERITED_BY; + case CoreQueryBuilder::INHERITED_BY: try { $inheritedBy = new FederatedUser(); $inheritedBy->importFromDatabase($data, $prefix); @@ -285,7 +284,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INVITED_BY; + case CoreQueryBuilder::INVITED_BY: try { $invitedByCircle = new Circle(); $invitedByCircle->importFromDatabase($data, $prefix); @@ -296,7 +295,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INHERITANCE_FROM; + case CoreQueryBuilder::INHERITANCE_FROM: try { $inheritanceFrom = new Member(); $inheritanceFrom->importFromDatabase($data, $prefix); @@ -305,7 +304,7 @@ class ModelManager { } break; - case CoreQueryBuilder::REMOTE; + case CoreQueryBuilder::REMOTE: try { $remoteInstance = new RemoteInstance(); $remoteInstance->importFromDatabase($data, $prefix); @@ -330,7 +329,7 @@ class ModelManager { string $prefix ): void { switch ($path) { - case CoreQueryBuilder::MEMBERSHIPS; + case CoreQueryBuilder::MEMBERSHIPS: try { $membership = new Membership(); $membership->importFromDatabase($data, $prefix); @@ -355,7 +354,7 @@ class ModelManager { string $prefix ): void { switch ($path) { - case CoreQueryBuilder::CIRCLE; + case CoreQueryBuilder::CIRCLE: try { $circle = new Circle(); $circle->importFromDatabase($data, $prefix); @@ -364,7 +363,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INITIATOR; + case CoreQueryBuilder::INITIATOR: try { $initiator = new Member(); $initiator->importFromDatabase($data, $prefix); @@ -373,7 +372,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INHERITED_BY; + case CoreQueryBuilder::INHERITED_BY: try { $inheritedBy = new Member(); $inheritedBy->importFromDatabase($data, $prefix); @@ -382,7 +381,7 @@ class ModelManager { } break; - case CoreQueryBuilder::FILE_CACHE; + case CoreQueryBuilder::FILE_CACHE: try { $fileCache = new FileCacheWrapper(); $fileCache->importFromDatabase($data, $prefix); @@ -407,7 +406,7 @@ class ModelManager { string $prefix ): void { switch ($path) { - case CoreQueryBuilder::MEMBER; + case CoreQueryBuilder::MEMBER: try { $member = new Member(); $member->importFromDatabase($data, $prefix); @@ -416,7 +415,7 @@ class ModelManager { } break; - case CoreQueryBuilder::INITIATOR; + case CoreQueryBuilder::INITIATOR: try { $initiator = new Member(); $initiator->importFromDatabase($data, $prefix); @@ -492,6 +491,4 @@ class ModelManager { public function isFullDetails(): bool { return $this->fullDetails; } - } - diff --git a/lib/Model/Mount.php b/lib/Model/Mount.php index 7ca8518f..c32d9a7f 100644 --- a/lib/Model/Mount.php +++ b/lib/Model/Mount.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\INC22QueryRow; use ArtificialOwl\MySmallPhpTools\IDeserializable; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; @@ -41,15 +40,12 @@ use OCA\Circles\MountManager\CircleMountManager; use OCP\Federation\ICloudIdManager; use OCP\Http\Client\IClientService; - /** * Class Mount * * @package OCA\Circles\Model */ class Mount extends ManagedModel implements IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; @@ -410,15 +406,15 @@ class Mount extends ManagedModel implements IDeserializable, INC22QueryRow, Json $member = $this->getOwner(); return [ - 'owner' => $member->getUserId(), - 'remote' => $member->getRemoteInstance()->getRoot(), - 'token' => $this->getToken(), - 'password' => $this->getPassword(), - 'mountpoint' => $this->getMountPoint(false), + 'owner' => $member->getUserId(), + 'remote' => $member->getRemoteInstance()->getRoot(), + 'token' => $this->getToken(), + 'password' => $this->getPassword(), + 'mountpoint' => $this->getMountPoint(false), // 'manager' => $this->getMountManager(), 'HttpClientService' => $this->getHttpClientService(), - 'manager' => $this->getMountManager(), - 'cloudId' => $this->getCloudIdManager()->getCloudId( + 'manager' => $this->getMountManager(), + 'cloudId' => $this->getCloudIdManager()->getCloudId( $member->getUserId(), $member->getRemoteInstance()->getRoot() ) @@ -481,16 +477,16 @@ class Mount extends ManagedModel implements IDeserializable, INC22QueryRow, Json /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { $arr = [ - 'id' => $this->getId(), - 'circleId' => $this->getCircleId(), - 'mountId' => $this->getMountId(), - 'parent' => $this->getParent(), - 'owner' => $this->getOwner(), - 'token' => $this->getToken(), - 'password' => $this->getPassword(), - 'mountPoint' => $this->getMountPoint(), + 'id' => $this->getId(), + 'circleId' => $this->getCircleId(), + 'mountId' => $this->getMountId(), + 'parent' => $this->getParent(), + 'owner' => $this->getOwner(), + 'token' => $this->getToken(), + 'password' => $this->getPassword(), + 'mountPoint' => $this->getMountPoint(), 'mountPointHash' => $this->getMountPointHash(), ]; @@ -501,6 +497,4 @@ class Mount extends ManagedModel implements IDeserializable, INC22QueryRow, Json return $arr; } - } - diff --git a/lib/Model/Mountpoint.php b/lib/Model/Mountpoint.php index 0737be6e..aaee6817 100644 --- a/lib/Model/Mountpoint.php +++ b/lib/Model/Mountpoint.php @@ -1,4 +1,6 @@ - $this->getUserId(), - 'shareId' => $this->getShareId(), + 'userId' => $this->getUserId(), + 'shareId' => $this->getShareId(), 'mountPoint' => $this->getMountPoint(), ]; } - } - diff --git a/lib/Model/Report.php b/lib/Model/Report.php index 8f2b6203..1400dd7d 100644 --- a/lib/Model/Report.php +++ b/lib/Model/Report.php @@ -31,20 +31,16 @@ declare(strict_types=1); namespace OCA\Circles\Model; - use ArtificialOwl\MySmallPhpTools\IDeserializable; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use JsonSerializable; - /** * Class Report * * @package OCA\Circles\Model */ class Report implements IDeserializable, JsonSerializable { - - use TArrayTools; /** @var string */ @@ -138,13 +134,11 @@ class Report implements IDeserializable, JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { return [ - 'source' => $this->getSource(), - 'circles' => $this->getCircles(), + 'source' => $this->getSource(), + 'circles' => $this->getCircles(), 'obfuscated' => $this->getObfuscated() ]; } - } - diff --git a/lib/Model/SearchResult.php b/lib/Model/SearchResult.php index 334e9efb..54fe0ad1 100644 --- a/lib/Model/SearchResult.php +++ b/lib/Model/SearchResult.php @@ -26,7 +26,6 @@ namespace OCA\Circles\Model; - class SearchResult implements \JsonSerializable { /** @var string */ @@ -50,7 +49,7 @@ class SearchResult implements \JsonSerializable { * @param string $instance * @param array $data */ - function __construct($ident = '', $type = 0, $instance = '', $data = []) { + public function __construct($ident = '', $type = 0, $instance = '', $data = []) { $this->setIdent($ident); $this->setType($type); $this->setInstance($instance); @@ -130,14 +129,12 @@ class SearchResult implements \JsonSerializable { * which is a value of any type other than a resource. * @since 5.4.0 */ - function jsonSerialize() { - + public function jsonSerialize() { return [ - 'ident' => $this->getIdent(), + 'ident' => $this->getIdent(), 'instance' => $this->getInstance(), - 'type' => $this->getType(), - 'data' => $this->getData() + 'type' => $this->getType(), + 'data' => $this->getData() ]; - } } diff --git a/lib/Model/ShareToken.php b/lib/Model/ShareToken.php index 47af8051..b532ed11 100644 --- a/lib/Model/ShareToken.php +++ b/lib/Model/ShareToken.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Model; - use ArtificialOwl\MySmallPhpTools\Db\Nextcloud\nc22\INC22QueryRow; use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\IDeserializable; @@ -39,10 +38,7 @@ use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use JsonSerializable; use OCP\Share\IShare; - class ShareToken implements IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; @@ -77,7 +73,7 @@ class ShareToken implements IDeserializable, INC22QueryRow, JsonSerializable { /** * ShareToken constructor. */ - function __construct() { + public function __construct() { } @@ -297,18 +293,16 @@ class ShareToken implements IDeserializable, INC22QueryRow, JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { return [ - 'shareId' => $this->getShareId(), + 'shareId' => $this->getShareId(), 'circleId' => $this->getCircleId(), 'singleId' => $this->getSingleId(), 'memberId' => $this->getMemberId(), - 'token' => $this->getToken(), + 'token' => $this->getToken(), 'password' => $this->getPassword(), 'accepted' => $this->getAccepted(), - 'link' => $this->getLink() + 'link' => $this->getLink() ]; } - } - diff --git a/lib/Model/ShareWrapper.php b/lib/Model/ShareWrapper.php index 2ffb1728..8fd8d3f9 100644 --- a/lib/Model/ShareWrapper.php +++ b/lib/Model/ShareWrapper.php @@ -49,15 +49,12 @@ use OCP\IUserManager; use OCP\Share\Exceptions\IllegalIDChangeException; use OCP\Share\IShare; - /** * Class ShareWrapper * * @package OCA\Circles\Model */ class ShareWrapper extends ManagedModel implements IDeserializable, INC22QueryRow, JsonSerializable { - - use TArrayTools; use TNC22Deserialize; @@ -649,7 +646,7 @@ class ShareWrapper extends ManagedModel implements IDeserializable, INC22QueryRo $share->setNodeCacheEntry( Cache::cacheEntryFromData($this->getFileCache()->toCache(), OC::$server->getMimeTypeLoader()) ); - } else if ($nullOnMissingFileCache) { + } elseif ($nullOnMissingFileCache) { return null; } @@ -824,23 +821,23 @@ class ShareWrapper extends ManagedModel implements IDeserializable, INC22QueryRo */ public function jsonSerialize(): array { $arr = [ - 'id' => $this->getId(), - 'shareType' => $this->getShareType(), - 'providerId' => $this->getProviderId(), - 'permissions' => $this->getPermissions(), - 'itemType' => $this->getItemType(), - 'itemSource' => $this->getItemSource(), - 'itemTarget' => $this->getItemTarget(), - 'fileSource' => $this->getFileSource(), - 'fileTarget' => $this->getFileTarget(), - 'status' => $this->getStatus(), - 'shareTime' => $this->getShareTime()->getTimestamp(), - 'sharedWith' => $this->getSharedWith(), - 'sharedBy' => $this->getSharedBy(), - 'shareOwner' => $this->getShareOwner(), - 'token' => $this->getToken(), - 'childId' => $this->getChildId(), - 'childFileTarget' => $this->getChildFileTarget(), + 'id' => $this->getId(), + 'shareType' => $this->getShareType(), + 'providerId' => $this->getProviderId(), + 'permissions' => $this->getPermissions(), + 'itemType' => $this->getItemType(), + 'itemSource' => $this->getItemSource(), + 'itemTarget' => $this->getItemTarget(), + 'fileSource' => $this->getFileSource(), + 'fileTarget' => $this->getFileTarget(), + 'status' => $this->getStatus(), + 'shareTime' => $this->getShareTime()->getTimestamp(), + 'sharedWith' => $this->getSharedWith(), + 'sharedBy' => $this->getSharedBy(), + 'shareOwner' => $this->getShareOwner(), + 'token' => $this->getToken(), + 'childId' => $this->getChildId(), + 'childFileTarget' => $this->getChildFileTarget(), 'childPermissions' => $this->getChildPermissions() ]; @@ -866,6 +863,4 @@ class ShareWrapper extends ManagedModel implements IDeserializable, INC22QueryRo return $arr; } - } - diff --git a/lib/Model/SharesToken.php b/lib/Model/SharesToken.php index 82193fc4..cd9eb19c 100644 --- a/lib/Model/SharesToken.php +++ b/lib/Model/SharesToken.php @@ -26,20 +26,16 @@ namespace OCA\Circles\Model; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use JsonSerializable; use OCP\Share\IShare; - /** * Class SharesToken * @deprecated * @package OCA\Circles\Model */ class SharesToken implements JsonSerializable { - - use TArrayTools; @@ -65,7 +61,7 @@ class SharesToken implements JsonSerializable { /** * SharesToken constructor. */ - function __construct() { + public function __construct() { } @@ -186,7 +182,7 @@ class SharesToken implements JsonSerializable { /** * @param array $data */ - function import(array $data) { + public function import(array $data) { $this->setCircleId($this->get('circle_id', $data, '')); $this->setMemberId($this->get('member_id', $data, '')); $this->setAccepted($this->getInt('accepted', $data, IShare::STATUS_PENDING)); @@ -199,16 +195,14 @@ class SharesToken implements JsonSerializable { /** * @return array */ - function jsonSerialize(): array { + public function jsonSerialize(): array { return [ 'circleId' => $this->getCircleId(), 'memberId' => $this->getMemberId(), - 'userId' => $this->getUserId(), - 'shareId' => $this->getShareId(), - 'token' => $this->getToken(), + 'userId' => $this->getUserId(), + 'shareId' => $this->getShareId(), + 'token' => $this->getToken(), 'accepted' => $this->getAccepted() ]; } - } - diff --git a/lib/Model/SharingFrame.php b/lib/Model/SharingFrame.php index 4d9f2d12..be21cc45 100644 --- a/lib/Model/SharingFrame.php +++ b/lib/Model/SharingFrame.php @@ -272,22 +272,21 @@ class SharingFrame implements \JsonSerializable { public function jsonSerialize() { - return array( + return [ 'unique_id' => $this->getUniqueId(), - 'circle' => $this->getCircle() + 'circle' => $this->getCircle() ->getArray(false, true), - 'source' => $this->getSource(), - 'type' => $this->getType(), - 'author' => $this->getAuthor(), - 'cloud_id' => $this->getCloudId(), - 'headers' => $this->getHeaders(), - 'payload' => $this->getPayload(), - 'creation' => $this->getCreation(), - ); + 'source' => $this->getSource(), + 'type' => $this->getType(), + 'author' => $this->getAuthor(), + 'cloud_id' => $this->getCloudId(), + 'headers' => $this->getHeaders(), + 'payload' => $this->getPayload(), + 'creation' => $this->getCreation(), + ]; } public static function fromJSON($json) { - $arr = json_decode($json, true); return self::fromArray($arr); @@ -321,7 +320,6 @@ class SharingFrame implements \JsonSerializable { * @return array */ private static function getHeadersFromArray($arr) { - $headers = []; if (key_exists('headers', $arr)) { $headers = $arr['headers']; @@ -340,4 +338,3 @@ class SharingFrame implements \JsonSerializable { return DeprecatedCircle::fromArray(MiscService::get($arr, 'circle', null)); } } - diff --git a/lib/MountManager/CircleMount.php b/lib/MountManager/CircleMount.php index c68a1c5e..29ac827d 100644 --- a/lib/MountManager/CircleMount.php +++ b/lib/MountManager/CircleMount.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\MountManager; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use Exception; use JsonSerializable; @@ -41,15 +40,12 @@ use OCA\Circles\Exceptions\MountPointConstructionException; use OCA\Circles\Model\Mount; use OCP\Files\Storage\IStorageFactory; - /** * Class CircleMount * * @package OCA\Circles\MountManager */ class CircleMount extends MountPoint implements MoveableMount, JsonSerializable { - - use TArrayTools; @@ -134,10 +130,8 @@ class CircleMount extends MountPoint implements MoveableMount, JsonSerializable */ public function jsonSerialize(): array { return [ - 'mount' => $this->mount, + 'mount' => $this->mount, 'storage' => $this->storageClass ]; } - } - diff --git a/lib/MountManager/CircleMountManager.php b/lib/MountManager/CircleMountManager.php index 5d9998a1..fd6915aa 100644 --- a/lib/MountManager/CircleMountManager.php +++ b/lib/MountManager/CircleMountManager.php @@ -1,4 +1,6 @@ -prepareActions($notification); return $notification; - } @@ -216,7 +211,6 @@ class Notifier implements INotifier { } $notification->setParsedSubject($subject); - } @@ -243,6 +237,4 @@ class Notifier implements INotifier { $notification->addParsedAction($action); } } - } - diff --git a/lib/Search/Contacts.php b/lib/Search/Contacts.php index c08fa8dc..8ef53bfd 100644 --- a/lib/Search/Contacts.php +++ b/lib/Search/Contacts.php @@ -37,7 +37,6 @@ class Contacts implements ISearch { * {@inheritdoc} */ public function search($search) { - $result = []; $contactManager = \OC::$server->getContactsManager(); @@ -63,8 +62,8 @@ class Contacts implements ISearch { */ private function generateDataArray($contact) { $data = [ - 'display' => '', - 'email' => '', + 'display' => '', + 'email' => '', 'organization' => '' ]; @@ -75,4 +74,3 @@ class Contacts implements ISearch { return $data; } } - diff --git a/lib/Search/FederatedUsers.php b/lib/Search/FederatedUsers.php index 787aa02f..56cec685 100644 --- a/lib/Search/FederatedUsers.php +++ b/lib/Search/FederatedUsers.php @@ -31,11 +31,9 @@ declare(strict_types=1); namespace OCA\Circles\Search; - use OCA\Circles\Db\MemberRequest; use OCA\Circles\ISearch; - /** * Class FederatedUsers * @@ -66,6 +64,4 @@ class FederatedUsers implements ISearch { public function search(string $needle): array { return $this->memberRequest->searchFederatedUsers($needle); } - } - diff --git a/lib/Search/GlobalScaleUsers.php b/lib/Search/GlobalScaleUsers.php index e751c701..9b59e6f3 100644 --- a/lib/Search/GlobalScaleUsers.php +++ b/lib/Search/GlobalScaleUsers.php @@ -39,15 +39,12 @@ use OCA\Circles\Model\SearchResult; use OCA\Circles\Service\ConfigService; use OCA\Circles\Service\MiscService; - /** * Class GlobalScaleUsers * * @package OCA\Circles\Search */ class GlobalScaleUsers implements ISearch { - - use TNC22Request; use TArrayTools; @@ -102,7 +99,7 @@ class GlobalScaleUsers implements ISearch { $result = []; foreach ($users as $user) { - list(, $instance) = explode('@', $this->get('federationId', $user), 2); + [, $instance] = explode('@', $this->get('federationId', $user), 2); if ($this->configService->isLocalInstance($instance)) { continue; } @@ -117,5 +114,3 @@ class GlobalScaleUsers implements ISearch { return $result; } } - - diff --git a/lib/Search/LocalGroups.php b/lib/Search/LocalGroups.php index 54d17c62..8fdac50a 100644 --- a/lib/Search/LocalGroups.php +++ b/lib/Search/LocalGroups.php @@ -46,5 +46,4 @@ class LocalGroups implements ISearch { return $result; } - } diff --git a/lib/Search/LocalUsers.php b/lib/Search/LocalUsers.php index c2736bc7..44dc2685 100644 --- a/lib/Search/LocalUsers.php +++ b/lib/Search/LocalUsers.php @@ -35,8 +35,6 @@ use OCP\Collaboration\Collaborators\ISearch as ICollaboratorSearch; use OCP\Share\IShare; class LocalUsers implements ISearch { - - use TArrayTools; @@ -88,7 +86,7 @@ class LocalUsers implements ISearch { * @return array */ private function searchFromCollaborator($search): array { - list($temp, $hasMore) = $this->search->search($search, [IShare::TYPE_USER, IShare::TYPE_EMAIL], false, 50, 0); + [$temp, $hasMore] = $this->search->search($search, [IShare::TYPE_USER, IShare::TYPE_EMAIL], false, 50, 0); $result = array_merge($temp['exact']['users'], $temp['users']); $parsed = []; @@ -104,7 +102,4 @@ class LocalUsers implements ISearch { return $parsed; } - } - - diff --git a/lib/Service/CircleService.php b/lib/Service/CircleService.php index 7ec36bdb..6801ee80 100644 --- a/lib/Service/CircleService.php +++ b/lib/Service/CircleService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; @@ -66,15 +65,12 @@ use OCA\Circles\Model\ManagedModel; use OCA\Circles\Model\Member; use OCA\Circles\StatusCode; - /** * Class CircleService * * @package OCA\Circles\Service */ class CircleService { - - use TArrayTools; use TStringTools; use TNC22Logger; @@ -159,7 +155,6 @@ class CircleService { bool $personal = false, bool $local = false ): array { - $this->federatedUserService->mustHaveCurrentUser(); if (is_null($owner)) { $owner = $this->federatedUserService->getCurrentUser(); @@ -465,12 +460,12 @@ class CircleService { } $params->default( [ - 'limit' => -1, - 'offset' => 0, - 'mustBeMember' => false, - 'includeHiddenCircles' => false, - 'includeBackendCircles' => false, - 'includeSystemCircles' => false, + 'limit' => -1, + 'offset' => 0, + 'mustBeMember' => false, + 'includeHiddenCircles' => false, + 'includeBackendCircles' => false, + 'includeSystemCircles' => false, 'includePersonalCircles' => false ] ); @@ -628,6 +623,4 @@ class CircleService { return trim($name); } - } - diff --git a/lib/Service/CirclesService.php b/lib/Service/CirclesService.php index 84ff133b..af5cd8d3 100644 --- a/lib/Service/CirclesService.php +++ b/lib/Service/CirclesService.php @@ -29,7 +29,6 @@ namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use Exception; use OC; @@ -55,7 +54,6 @@ use OCP\IGroupManager; use OCP\IL10N; use OCP\IUserSession; - /** * Class CirclesService * @@ -63,8 +61,6 @@ use OCP\IUserSession; * @package OCA\Circles\Service */ class CirclesService { - - use TArrayTools; @@ -147,7 +143,6 @@ class CirclesService { CircleProviderRequest $circleProviderRequest, MiscService $miscService ) { - if ($userId === null) { $user = $userSession->getUser(); if ($user !== null) { @@ -278,7 +273,6 @@ class CirclesService { * @throws Exception */ public function detailsCircle($circleUniqueId, $forceAll = false) { - try { if (!$forceAll) { $circle = $this->circlesRequest->getCircle( @@ -542,10 +536,10 @@ class CirclesService { public function convertTypeStringToBitValue($type) { $strings = [ 'personal' => DeprecatedCircle::CIRCLES_PERSONAL, - 'secret' => DeprecatedCircle::CIRCLES_SECRET, - 'closed' => DeprecatedCircle::CIRCLES_CLOSED, - 'public' => DeprecatedCircle::CIRCLES_PUBLIC, - 'all' => DeprecatedCircle::CIRCLES_ALL + 'secret' => DeprecatedCircle::CIRCLES_SECRET, + 'closed' => DeprecatedCircle::CIRCLES_CLOSED, + 'public' => DeprecatedCircle::CIRCLES_PUBLIC, + 'all' => DeprecatedCircle::CIRCLES_ALL ]; if (!key_exists(strtolower($type), $strings)) { @@ -567,7 +561,6 @@ class CirclesService { * @return string */ public static function getCircleIcon($type, $png = false) { - $ext = '.svg'; if ($png === true) { $ext = '.png'; @@ -642,7 +635,6 @@ class CirclesService { 'This circle already reach its limit on the number of members' ); } - } /** @@ -689,5 +681,4 @@ class CirclesService { ); } } - } diff --git a/lib/Service/ConfigService.php b/lib/Service/ConfigService.php index c14ad31f..8628292f 100644 --- a/lib/Service/ConfigService.php +++ b/lib/Service/ConfigService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\Nextcloud\nc22\NC22Request; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -44,124 +43,121 @@ use OCA\Circles\Model\Member; use OCP\IConfig; use OCP\IURLGenerator; - /** * Class ConfigService * * @package OCA\Circles\Service */ class ConfigService { - - use TStringTools; use TArrayTools; - const FRONTAL_CLOUD_ID = 'frontal_cloud_id'; - const FRONTAL_CLOUD_SCHEME = 'frontal_cloud_scheme'; - const INTERNAL_CLOUD_ID = 'internal_cloud_id'; - const INTERNAL_CLOUD_SCHEME = 'internal_cloud_scheme'; - const LOOPBACK_CLOUD_ID = 'loopback_cloud_id'; - const LOOPBACK_CLOUD_SCHEME = 'loopback_cloud_scheme'; - const IFACE0_CLOUD_ID = 'iface0_cloud_id'; - const IFACE0_CLOUD_SCHEME = 'iface0_cloud_scheme'; - const IFACE0_INTERNAL = 'iface0_internal'; - const IFACE1_CLOUD_ID = 'iface1_cloud_id'; - const IFACE1_CLOUD_SCHEME = 'iface1_cloud_scheme'; - const IFACE1_INTERNAL = 'iface1_internal'; - const IFACE2_CLOUD_ID = 'iface2_cloud_id'; - const IFACE2_CLOUD_SCHEME = 'iface2_cloud_scheme'; - const IFACE2_INTERNAL = 'iface2_internal'; - const IFACE3_CLOUD_ID = 'iface3_cloud_id'; - const IFACE3_CLOUD_SCHEME = 'iface3_cloud_scheme'; - const IFACE3_INTERNAL = 'iface3_internal'; - const IFACE4_CLOUD_ID = 'iface4_cloud_id'; - const IFACE4_CLOUD_SCHEME = 'iface4_cloud_scheme'; - const IFACE4_INTERNAL = 'iface4_internal'; - const IFACE_TEST_ID = 'iface_test_id'; - const IFACE_TEST_SCHEME = 'iface_test_scheme'; - const IFACE_TEST_TOKEN = 'iface_test_token'; + public const FRONTAL_CLOUD_ID = 'frontal_cloud_id'; + public const FRONTAL_CLOUD_SCHEME = 'frontal_cloud_scheme'; + public const INTERNAL_CLOUD_ID = 'internal_cloud_id'; + public const INTERNAL_CLOUD_SCHEME = 'internal_cloud_scheme'; + public const LOOPBACK_CLOUD_ID = 'loopback_cloud_id'; + public const LOOPBACK_CLOUD_SCHEME = 'loopback_cloud_scheme'; + public const IFACE0_CLOUD_ID = 'iface0_cloud_id'; + public const IFACE0_CLOUD_SCHEME = 'iface0_cloud_scheme'; + public const IFACE0_INTERNAL = 'iface0_internal'; + public const IFACE1_CLOUD_ID = 'iface1_cloud_id'; + public const IFACE1_CLOUD_SCHEME = 'iface1_cloud_scheme'; + public const IFACE1_INTERNAL = 'iface1_internal'; + public const IFACE2_CLOUD_ID = 'iface2_cloud_id'; + public const IFACE2_CLOUD_SCHEME = 'iface2_cloud_scheme'; + public const IFACE2_INTERNAL = 'iface2_internal'; + public const IFACE3_CLOUD_ID = 'iface3_cloud_id'; + public const IFACE3_CLOUD_SCHEME = 'iface3_cloud_scheme'; + public const IFACE3_INTERNAL = 'iface3_internal'; + public const IFACE4_CLOUD_ID = 'iface4_cloud_id'; + public const IFACE4_CLOUD_SCHEME = 'iface4_cloud_scheme'; + public const IFACE4_INTERNAL = 'iface4_internal'; + public const IFACE_TEST_ID = 'iface_test_id'; + public const IFACE_TEST_SCHEME = 'iface_test_scheme'; + public const IFACE_TEST_TOKEN = 'iface_test_token'; - const HARD_MODERATION = 'hard_moderation'; - const FRONTEND_ENABLED = 'frontend_enabled'; - const ROUTE_TO_CIRCLE = 'route_to_circle'; - const EVENT_EXAMPLES = 'event_examples'; + public const HARD_MODERATION = 'hard_moderation'; + public const FRONTEND_ENABLED = 'frontend_enabled'; + public const ROUTE_TO_CIRCLE = 'route_to_circle'; + public const EVENT_EXAMPLES = 'event_examples'; - const SELF_SIGNED_CERT = 'self_signed_cert'; - const MEMBERS_LIMIT = 'members_limit'; - const ACTIVITY_ON_NEW_CIRCLE = 'creation_activity'; + public const SELF_SIGNED_CERT = 'self_signed_cert'; + public const MEMBERS_LIMIT = 'members_limit'; + public const ACTIVITY_ON_NEW_CIRCLE = 'creation_activity'; - const MIGRATION_BYPASS = 'migration_bypass'; - const MIGRATION_22 = 'migration_22'; - const MIGRATION_RUN = 'migration_run'; - const MAINTENANCE_UPDATE = 'maintenance_update'; - const MAINTENANCE_RUN = 'maintenance_run'; + public const MIGRATION_BYPASS = 'migration_bypass'; + public const MIGRATION_22 = 'migration_22'; + public const MIGRATION_RUN = 'migration_run'; + public const MAINTENANCE_UPDATE = 'maintenance_update'; + public const MAINTENANCE_RUN = 'maintenance_run'; - const LOOPBACK_TMP_ID = 'loopback_tmp_id'; - const LOOPBACK_TMP_SCHEME = 'loopback_tmp_scheme'; + public const LOOPBACK_TMP_ID = 'loopback_tmp_id'; + public const LOOPBACK_TMP_SCHEME = 'loopback_tmp_scheme'; - const GS_MODE = 'mode'; - const GS_KEY = 'key'; + public const GS_MODE = 'mode'; + public const GS_KEY = 'key'; - const GS_LOOKUP_INSTANCES = '/instances'; - const GS_LOOKUP_USERS = '/users'; + public const GS_LOOKUP_INSTANCES = '/instances'; + public const GS_LOOKUP_USERS = '/users'; // deprecated -- removing in NC25 - const CIRCLES_CONTACT_BACKEND = 'contact_backend'; - const CIRCLES_ACCOUNTS_ONLY = 'accounts_only'; // only UserType=1 - const CIRCLES_SEARCH_FROM_COLLABORATOR = 'search_from_collaborator'; + public const CIRCLES_CONTACT_BACKEND = 'contact_backend'; + public const CIRCLES_ACCOUNTS_ONLY = 'accounts_only'; // only UserType=1 + public const CIRCLES_SEARCH_FROM_COLLABORATOR = 'search_from_collaborator'; - const FORCE_NC_BASE = 'force_nc_base'; - const TEST_NC_BASE = 'test_nc_base'; + public const FORCE_NC_BASE = 'force_nc_base'; + public const TEST_NC_BASE = 'test_nc_base'; private $defaults = [ - self::FRONTAL_CLOUD_ID => '', - self::FRONTAL_CLOUD_SCHEME => 'https', - self::INTERNAL_CLOUD_ID => '', + self::FRONTAL_CLOUD_ID => '', + self::FRONTAL_CLOUD_SCHEME => 'https', + self::INTERNAL_CLOUD_ID => '', self::INTERNAL_CLOUD_SCHEME => 'https', - self::LOOPBACK_CLOUD_ID => '', + self::LOOPBACK_CLOUD_ID => '', self::LOOPBACK_CLOUD_SCHEME => 'https', - self::LOOPBACK_TMP_ID => '', - self::LOOPBACK_TMP_SCHEME => '', - self::IFACE0_CLOUD_ID => '', - self::IFACE0_CLOUD_SCHEME => 'https', - self::IFACE0_INTERNAL => '0', - self::IFACE1_CLOUD_ID => '', - self::IFACE1_CLOUD_SCHEME => 'https', - self::IFACE1_INTERNAL => '0', - self::IFACE2_CLOUD_ID => '', - self::IFACE2_CLOUD_SCHEME => 'https', - self::IFACE2_INTERNAL => '0', - self::IFACE3_CLOUD_ID => '', - self::IFACE3_CLOUD_SCHEME => 'https', - self::IFACE3_INTERNAL => '0', - self::IFACE4_CLOUD_ID => '', - self::IFACE4_CLOUD_SCHEME => 'https', - self::IFACE4_INTERNAL => '0', - self::IFACE_TEST_ID => '', - self::IFACE_TEST_SCHEME => 'https', - self::IFACE_TEST_TOKEN => '', + self::LOOPBACK_TMP_ID => '', + self::LOOPBACK_TMP_SCHEME => '', + self::IFACE0_CLOUD_ID => '', + self::IFACE0_CLOUD_SCHEME => 'https', + self::IFACE0_INTERNAL => '0', + self::IFACE1_CLOUD_ID => '', + self::IFACE1_CLOUD_SCHEME => 'https', + self::IFACE1_INTERNAL => '0', + self::IFACE2_CLOUD_ID => '', + self::IFACE2_CLOUD_SCHEME => 'https', + self::IFACE2_INTERNAL => '0', + self::IFACE3_CLOUD_ID => '', + self::IFACE3_CLOUD_SCHEME => 'https', + self::IFACE3_INTERNAL => '0', + self::IFACE4_CLOUD_ID => '', + self::IFACE4_CLOUD_SCHEME => 'https', + self::IFACE4_INTERNAL => '0', + self::IFACE_TEST_ID => '', + self::IFACE_TEST_SCHEME => 'https', + self::IFACE_TEST_TOKEN => '', self::FRONTEND_ENABLED => '1', - self::HARD_MODERATION => '0', - self::ROUTE_TO_CIRCLE => 'contacts.contacts.directcircle', - self::EVENT_EXAMPLES => '0', + self::HARD_MODERATION => '0', + self::ROUTE_TO_CIRCLE => 'contacts.contacts.directcircle', + self::EVENT_EXAMPLES => '0', - self::SELF_SIGNED_CERT => '0', - self::MEMBERS_LIMIT => '-1', + self::SELF_SIGNED_CERT => '0', + self::MEMBERS_LIMIT => '-1', self::ACTIVITY_ON_NEW_CIRCLE => '1', - self::MIGRATION_BYPASS => '0', - self::MIGRATION_22 => '0', - self::MIGRATION_RUN => '0', - self::MAINTENANCE_UPDATE => '[]', - self::MAINTENANCE_RUN => '0', + self::MIGRATION_BYPASS => '0', + self::MIGRATION_22 => '0', + self::MIGRATION_RUN => '0', + self::MAINTENANCE_UPDATE => '[]', + self::MAINTENANCE_RUN => '0', - self::FORCE_NC_BASE => '', - self::TEST_NC_BASE => '', - self::CIRCLES_CONTACT_BACKEND => '0', - self::CIRCLES_ACCOUNTS_ONLY => '0', + self::FORCE_NC_BASE => '', + self::TEST_NC_BASE => '', + self::CIRCLES_CONTACT_BACKEND => '0', + self::CIRCLES_ACCOUNTS_ONLY => '0', self::CIRCLES_SEARCH_FROM_COLLABORATOR => '0', ]; @@ -331,10 +327,10 @@ class ConfigService { */ public function getSettings(): array { return [ - 'frontendEnabled' => $this->getAppValueBool(self::FRONTEND_ENABLED), - 'allowedCircles' => Circle::$DEF_CFG_MAX, + 'frontendEnabled' => $this->getAppValueBool(self::FRONTEND_ENABLED), + 'allowedCircles' => Circle::$DEF_CFG_MAX, 'allowedUserTypes' => Member::$DEF_TYPE_MAX, - 'membersLimit' => $this->getAppValueInt(self::MEMBERS_LIMIT) + 'membersLimit' => $this->getAppValueInt(self::MEMBERS_LIMIT) ]; } @@ -402,11 +398,11 @@ class ConfigService { */ public function getGSData(): array { return [ - 'enabled' => $this->isGSAvailable(), - 'lookup' => $this->getGSLookup(), - 'mockup' => $this->getGSSMockup(), + 'enabled' => $this->isGSAvailable(), + 'lookup' => $this->getGSLookup(), + 'mockup' => $this->getGSSMockup(), self::GS_MODE => $this->config->getSystemValue('gss.mode', ''), - self::GS_KEY => $this->config->getSystemValue('gss.jwt.key', ''), + self::GS_KEY => $this->config->getSystemValue('gss.jwt.key', ''), ]; } @@ -416,7 +412,7 @@ class ConfigService { */ public function getTrustedDomains(): array { return array_map( - function(string $address) { + function (string $address) { return strtolower($address); }, $this->config->getSystemValue('trusted_domains', []) ); @@ -634,6 +630,4 @@ class ConfigService { $request->setFollowLocation(true); $request->setTimeout(5); } - } - diff --git a/lib/Service/ContactService.php b/lib/Service/ContactService.php index 2ee75496..110c47e6 100644 --- a/lib/Service/ContactService.php +++ b/lib/Service/ContactService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -44,15 +43,12 @@ use OCP\Contacts\IManager; use OCP\IAddressBook; use OCP\IURLGenerator; - /** * Class ContactService * * @package OCA\Circles\Service */ class ContactService { - - use TArrayTools; use TStringTools; use TNC22Logger; @@ -144,7 +140,7 @@ class ContactService { $contacts = $addressBook->search( $contactId, ['UID'], [ - 'types' => false, + 'types' => false, 'escape_like_param' => false ] ); @@ -191,6 +187,4 @@ class ContactService { throw new ContactAddressBookNotFoundException(); } - } - diff --git a/lib/Service/DavService.php b/lib/Service/DavService.php index 88a9fd74..570e69df 100644 --- a/lib/Service/DavService.php +++ b/lib/Service/DavService.php @@ -29,7 +29,6 @@ namespace OCA\Circles\Service; - use Exception; use OCA\Circles\Circles\FileSharingBroadcaster; use OCA\Circles\Db\DeprecatedCirclesRequest; @@ -48,7 +47,6 @@ use OCP\Federation\ICloudIdManager; use OCP\IUserManager; use Symfony\Component\EventDispatcher\GenericEvent; - /** * Class DavService * @deprecated @@ -236,7 +234,6 @@ class DavService { * @param DavCard $davCard */ private function manageContact(DavCard $davCard) { - $this->manageDeprecatedMembers($davCard); switch ($this->getMemberType($davCard)) { @@ -264,7 +261,7 @@ class DavService { ); $circles = array_map( - function(DeprecatedCircle $circle) { + function (DeprecatedCircle $circle) { return $circle->getUniqueId(); }, $davCard->getCircles() ); @@ -378,7 +375,7 @@ class DavService { throw new NotLocalMemberException(); } - list ($username, $domain) = explode('@', $address); + [$username, $domain] = explode('@', $address); if (in_array($domain, $this->configService->getAvailableHosts())) { $user = $this->userManager->get($username); if ($user !== null) { @@ -396,7 +393,7 @@ class DavService { private function manageCircles(DavCard $davCard) { $fromCard = $davCard->getGroups(); $current = array_map( - function(DeprecatedCircle $circle) { + function (DeprecatedCircle $circle) { return $circle->getContactGroupName(); }, $this->getCirclesFromBook($davCard->getAddressBookId()) ); @@ -584,7 +581,7 @@ class DavService { $this->miscService->log(sizeof($contacts) . ' known members as contacts in Circles DB', 0); foreach ($contacts as $contact) { - list($bookId,) = explode('/', $contact->getContactId(), 2); + [$bookId,] = explode('/', $contact->getContactId(), 2); if (in_array($bookId, $knownBooks)) { continue; } @@ -645,7 +642,7 @@ class DavService { $this->miscService->log('Found ' . sizeof($circles) . ' Circles from book=' . $bookId, 0); $existing = array_unique( array_map( - function(DeprecatedCircle $circle) { + function (DeprecatedCircle $circle) { return $circle->getContactGroupName(); }, $circles ) @@ -666,7 +663,7 @@ class DavService { * @throws MemberDoesNotExistException */ public function getDavCardFromMember(DeprecatedMember $contact): DavCard { - list($bookId, $cardUri) = explode('/', $contact->getContactId(), 2); + [$bookId, $cardUri] = explode('/', $contact->getContactId(), 2); $this->miscService->log('Retrieving DavCard from book:' . $bookId . ', uri:' . $cardUri, 0); $cards = $this->cardDavBackend->getCards($bookId); @@ -710,8 +707,4 @@ class DavService { $this->migratedBooks[] = $bookId; } - - } - - diff --git a/lib/Service/EventService.php b/lib/Service/EventService.php index fa6a73db..d63ab0a0 100644 --- a/lib/Service/EventService.php +++ b/lib/Service/EventService.php @@ -34,7 +34,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use OCA\Circles\AppInfo\Application; @@ -61,15 +60,12 @@ use OCA\Circles\Model\Mount; use OCA\Circles\Model\ShareWrapper; use OCP\EventDispatcher\IEventDispatcher; - /** * Class EventService * * @package OCA\Circles\Service */ class EventService { - - use TNC22Logger; @@ -365,6 +361,4 @@ class EventService { // $event = new SharedItemsSyncRequestedEvent($federatedEvent); // $this->eventDispatcher->dispatchTyped($event); // } - } - diff --git a/lib/Service/EventWrapperService.php b/lib/Service/EventWrapperService.php index 287f097c..fbc71879 100644 --- a/lib/Service/EventWrapperService.php +++ b/lib/Service/EventWrapperService.php @@ -30,7 +30,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\ActivityPub\Nextcloud\nc22\NC22Signature; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Request; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -39,27 +38,24 @@ use OCA\Circles\Db\EventWrapperRequest; use OCA\Circles\Model\Federated\EventWrapper; use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class EventWrapperService * * @package OCA\Circles\Service */ class EventWrapperService extends NC22Signature { - - use TNC22Request; use TStringTools; - const RETRY_ASAP = 'asap'; - const RETRY_HOURLY = 'hourly'; - const RETRY_DAILY = 'daily'; - const RETRY_ERROR = 100; - static $RETRIES = [ - 'asap' => [0, 5], + public const RETRY_ASAP = 'asap'; + public const RETRY_HOURLY = 'hourly'; + public const RETRY_DAILY = 'daily'; + public const RETRY_ERROR = 100; + public static $RETRIES = [ + 'asap' => [0, 5], 'hourly' => [5, 150], - 'daily' => [150, 300] + 'daily' => [150, 300] ]; @@ -178,13 +174,11 @@ class EventWrapperService extends NC22Signature { */ private function getFailedEvents(array $retryRange): array { $token = array_map( - function(EventWrapper $event): string { + function (EventWrapper $event): string { return $event->getToken(); }, $this->eventWrapperRequest->getFailedEvents($retryRange) ); return array_values(array_unique($token)); } - } - diff --git a/lib/Service/EventsService.php b/lib/Service/EventsService.php index e752d431..f4af04d9 100644 --- a/lib/Service/EventsService.php +++ b/lib/Service/EventsService.php @@ -44,7 +44,6 @@ use OCP\Notification\INotification; use Symfony\Component\EventDispatcher\EventDispatcher; use Symfony\Component\EventDispatcher\GenericEvent; - /** * @deprecated * @@ -144,7 +143,7 @@ class EventsService { $event->setSubject('circle_create', ['circle' => json_encode($circle)]); $this->userManager->callForSeenUsers( - function($user) use ($event) { + function ($user) use ($event) { /** @var IUser $user */ $this->publishEvent($event, [$user]); } @@ -237,7 +236,6 @@ class EventsService { * @param DeprecatedMember $member */ private function onMemberAlmost(DeprecatedCircle $circle, DeprecatedMember $member) { - switch ($member->getStatus()) { case DeprecatedMember::STATUS_INVITED: $this->onMemberInvited($circle, $member); @@ -781,7 +779,7 @@ class EventsService { foreach ($users as $user) { if ($user instanceof IUser) { $userId = $user->getUID(); - } else if ($user instanceof DeprecatedMember) { + } elseif ($user instanceof DeprecatedMember) { $userId = $user->getUserId(); } else { continue; @@ -947,5 +945,4 @@ class EventsService { private function dispatch(string $context, $arguments) { $this->eventDispatcher->dispatch($context, new GenericEvent(null, $arguments)); } - } diff --git a/lib/Service/FederatedEventService.php b/lib/Service/FederatedEventService.php index ee1d3685..f94983ab 100644 --- a/lib/Service/FederatedEventService.php +++ b/lib/Service/FederatedEventService.php @@ -30,7 +30,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\ActivityPub\Nextcloud\nc22\NC22Signature; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; use ArtificialOwl\MySmallPhpTools\Model\Nextcloud\nc22\NC22Request; @@ -76,15 +75,12 @@ use OCA\Circles\Model\Member; use ReflectionClass; use ReflectionException; - /** * Class FederatedEventService * * @package OCA\Circles\Service */ class FederatedEventService extends NC22Signature { - - use TNC22Request; use TStringTools; @@ -321,7 +317,7 @@ class FederatedEventService extends NC22Signature { // TODO: enforce IFederatedItemMemberEmpty if no member if ($item instanceof IFederatedItemMemberEmpty) { $event->setMember(null); - } else if ($item instanceof IFederatedItemMemberRequired && !$event->hasMember()) { + } elseif ($item instanceof IFederatedItemMemberRequired && !$event->hasMember()) { throw new FederatedEventException('FederatedEvent has no Member linked'); } @@ -454,7 +450,7 @@ class FederatedEventService extends NC22Signature { $knownInstances = $this->memberRequest->getMemberInstances($circle->getSingleId()); $instances = array_filter( array_map( - function(RemoteInstance $instance) use ($knownInstances) { + function (RemoteInstance $instance) use ($knownInstances) { if (!in_array($instance->getInstance(), $knownInstances)) { return null; } @@ -469,7 +465,7 @@ class FederatedEventService extends NC22Signature { if ($event->hasMember() && !$this->configService->isLocalInstance($event->getMember()->getInstance())) { $currentInstances = array_map( - function(RemoteInstance $instance): string { + function (RemoteInstance $instance): string { return $instance->getInstance(); }, $instances ); @@ -518,6 +514,4 @@ class FederatedEventService extends NC22Signature { } catch (FederatedEventException $e) { } } - } - diff --git a/lib/Service/FederatedShareService.php b/lib/Service/FederatedShareService.php index bf87a303..f55f6b86 100644 --- a/lib/Service/FederatedShareService.php +++ b/lib/Service/FederatedShareService.php @@ -30,7 +30,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\ActivityPub\Nextcloud\nc22\NC22Signature; use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; @@ -51,7 +50,6 @@ use OCA\Circles\FederatedItems\ItemLock; use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Federated\FederatedShare; - /** * Class FederatedShareService * @@ -115,6 +113,4 @@ class FederatedShareService extends NC22Signature { return $share; } - } - diff --git a/lib/Service/FederatedUserService.php b/lib/Service/FederatedUserService.php index 7206fcd8..a90d3d4d 100644 --- a/lib/Service/FederatedUserService.php +++ b/lib/Service/FederatedUserService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -74,25 +73,22 @@ use OCP\IUser; use OCP\IUserManager; use OCP\IUserSession; - /** * Class FederatedUserService * * @package OCA\Circles\Service */ class FederatedUserService { - - use TArrayTools; use TStringTools; use TNC22Logger; - const CONFLICT_001 = 1; - const CONFLICT_002 = 2; - const CONFLICT_003 = 3; - const CONFLICT_004 = 4; - const CONFLICT_005 = 5; + public const CONFLICT_001 = 1; + public const CONFLICT_002 = 2; + public const CONFLICT_003 = 3; + public const CONFLICT_004 = 4; + public const CONFLICT_005 = 5; /** @var IUserSession */ @@ -389,7 +385,7 @@ class FederatedUserService { public function setMemberPatron(Member $member): void { if ($this->isInitiatedByOcc()) { $member->setInvitedBy($this->getAppInitiator('occ', Member::APP_OCC)); - } else if ($this->isInitiatedByAdmin()) { + } elseif ($this->isInitiatedByAdmin()) { $member->setInvitedBy($this->getInitiatedByAdmin()); } else { $member->setInvitedBy($this->getCurrentUser()); @@ -594,7 +590,7 @@ class FederatedUserService { public function getFederatedMember(string $userId, int $level = Member::LEVEL_MEMBER): Member { $userId = trim($userId, ','); if (strpos($userId, ',') !== false) { - list($userId, $level) = explode(',', $userId); + [$userId, $level] = explode(',', $userId); } $federatedUser = $this->getFederatedUser($userId, Member::TYPE_USER); @@ -639,7 +635,7 @@ class FederatedUserService { } } - list($singleId, $instance) = $this->extractIdAndInstance($federatedId); + [$singleId, $instance] = $this->extractIdAndInstance($federatedId); switch ($type) { case Member::TYPE_SINGLE: @@ -679,7 +675,7 @@ class FederatedUserService { } catch (Exception $e) { } - list($userId, $instance) = $this->extractIdAndInstance($federatedId); + [$userId, $instance] = $this->extractIdAndInstance($federatedId); $federatedUser = new FederatedUser(); $federatedUser->set($userId, $instance, $type); @@ -856,7 +852,7 @@ class FederatedUserService { $userId = $federatedId; $instance = $this->interfaceService->getLocalInstance(); } else { - list($userId, $instance) = explode('@', $federatedId); + [$userId, $instance] = explode('@', $federatedId); } return [$userId, $instance]; @@ -1092,7 +1088,7 @@ class FederatedUserService { 3, $message, false, [ 'federatedUser' => $federatedUser, - 'knownMember' => $knownMember + 'knownMember' => $knownMember ] ); @@ -1154,6 +1150,4 @@ class FederatedUserService { return $circle; } - } - diff --git a/lib/Service/GSDownstreamService.php b/lib/Service/GSDownstreamService.php index 8b79df97..b69462fe 100644 --- a/lib/Service/GSDownstreamService.php +++ b/lib/Service/GSDownstreamService.php @@ -1,4 +1,6 @@ -miscService->log('issue onNewEvent: ' . json_encode($event) . ' - ' . $e->getMessage()); } } - } - diff --git a/lib/Service/GSUpstreamService.php b/lib/Service/GSUpstreamService.php index 5df61397..ac7f12ff 100644 --- a/lib/Service/GSUpstreamService.php +++ b/lib/Service/GSUpstreamService.php @@ -1,4 +1,6 @@ -deprecatedEvents(); - } - - } - diff --git a/lib/Service/GlobalScaleService.php b/lib/Service/GlobalScaleService.php index 3241d141..1735562e 100644 --- a/lib/Service/GlobalScaleService.php +++ b/lib/Service/GlobalScaleService.php @@ -1,4 +1,6 @@ -circlesRequest->getCircle($circleUniqueId, $this->userId); $this->circlesService->hasToBeAdmin($circle->getHigherViewer()); @@ -178,7 +176,6 @@ class GroupsService { * @throws GroupDoesNotExistException */ private function getFreshNewMember($circleId, $groupId) { - if (!$this->groupManager->groupExists($groupId)) { throw new GroupDoesNotExistException($this->l10n->t("This group does not exist")); } @@ -211,7 +208,6 @@ class GroupsService { * @throws \Exception */ public function levelGroup($circleUniqueId, $groupId, $level) { - $level = (int)$level; try { $circle = $this->circlesRequest->getCircle($circleUniqueId, $this->userId); @@ -241,7 +237,6 @@ class GroupsService { } catch (\Exception $e) { throw $e; } - } @@ -264,7 +259,6 @@ class GroupsService { $group->setLevel($level); $this->membersRequest->updateGroup($group); - } catch (\Exception $e) { throw $e; } @@ -307,6 +301,4 @@ class GroupsService { public function onGroupRemoved($groupId) { $this->membersRequest->unlinkAllFromGroup($groupId); } - - } diff --git a/lib/Service/InterfaceService.php b/lib/Service/InterfaceService.php index a645bf7a..1cdab371 100644 --- a/lib/Service/InterfaceService.php +++ b/lib/Service/InterfaceService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Db\RemoteRequest; @@ -40,31 +39,29 @@ use OCA\Circles\Exceptions\UnknownInterfaceException; use OCP\IRequest; use OCP\IURLGenerator; - /** * Class InterfaceService * * @package OCA\Circles\Service */ class InterfaceService { - - const IFACE0 = 1; - const IFACE1 = 2; - const IFACE2 = 3; - const IFACE3 = 4; - const IFACE4 = 5; - const IFACE_INTERNAL = 6; - const IFACE_FRONTAL = 7; - const IFACE_TEST = 99; + public const IFACE0 = 1; + public const IFACE1 = 2; + public const IFACE2 = 3; + public const IFACE3 = 4; + public const IFACE4 = 5; + public const IFACE_INTERNAL = 6; + public const IFACE_FRONTAL = 7; + public const IFACE_TEST = 99; public static $LIST_IFACE = [ self::IFACE_INTERNAL => 'internal', - self::IFACE_FRONTAL => 'frontal', - self::IFACE0 => 'iface0', - self::IFACE1 => 'iface1', - self::IFACE2 => 'iface2', - self::IFACE3 => 'iface3', - self::IFACE4 => 'iface4', + self::IFACE_FRONTAL => 'frontal', + self::IFACE0 => 'iface0', + self::IFACE1 => 'iface1', + self::IFACE2 => 'iface2', + self::IFACE3 => 'iface3', + self::IFACE4 => 'iface4', ]; @@ -176,12 +173,12 @@ class InterfaceService { public function setCurrentInterfaceFromRequest(IRequest $request, string $testToken = ''): void { $testing = [ self::IFACE_INTERNAL => $this->configService->getInternalInstance(), - self::IFACE_FRONTAL => $this->configService->getFrontalInstance(), - self::IFACE0 => $this->configService->getIfaceInstance(self::IFACE0), - self::IFACE1 => $this->configService->getIfaceInstance(self::IFACE1), - self::IFACE2 => $this->configService->getIfaceInstance(self::IFACE2), - self::IFACE3 => $this->configService->getIfaceInstance(self::IFACE3), - self::IFACE4 => $this->configService->getIfaceInstance(self::IFACE4), + self::IFACE_FRONTAL => $this->configService->getFrontalInstance(), + self::IFACE0 => $this->configService->getIfaceInstance(self::IFACE0), + self::IFACE1 => $this->configService->getIfaceInstance(self::IFACE1), + self::IFACE2 => $this->configService->getIfaceInstance(self::IFACE2), + self::IFACE3 => $this->configService->getIfaceInstance(self::IFACE3), + self::IFACE4 => $this->configService->getIfaceInstance(self::IFACE4), ]; if ($testToken !== '' @@ -235,12 +232,12 @@ class InterfaceService { public function getInterfaces(bool $useString = false): array { $interfaces = [ self::IFACE_INTERNAL => $this->configService->getInternalInstance(), - self::IFACE_FRONTAL => $this->configService->getFrontalInstance(), - self::IFACE0 => $this->configService->getIfaceInstance(InterfaceService::IFACE0), - self::IFACE1 => $this->configService->getIfaceInstance(InterfaceService::IFACE1), - self::IFACE2 => $this->configService->getIfaceInstance(InterfaceService::IFACE2), - self::IFACE3 => $this->configService->getIfaceInstance(InterfaceService::IFACE3), - self::IFACE4 => $this->configService->getIfaceInstance(InterfaceService::IFACE4) + self::IFACE_FRONTAL => $this->configService->getFrontalInstance(), + self::IFACE0 => $this->configService->getIfaceInstance(InterfaceService::IFACE0), + self::IFACE1 => $this->configService->getIfaceInstance(InterfaceService::IFACE1), + self::IFACE2 => $this->configService->getIfaceInstance(InterfaceService::IFACE2), + self::IFACE3 => $this->configService->getIfaceInstance(InterfaceService::IFACE3), + self::IFACE4 => $this->configService->getIfaceInstance(InterfaceService::IFACE4) ]; if (!$useString) { @@ -380,6 +377,4 @@ class InterfaceService { private function getTestingInstance(): string { return $this->configService->getAppValue(ConfigService::IFACE_TEST_ID); } - } - diff --git a/lib/Service/MaintenanceService.php b/lib/Service/MaintenanceService.php index 46491791..f56bb320 100644 --- a/lib/Service/MaintenanceService.php +++ b/lib/Service/MaintenanceService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use Exception; @@ -45,19 +44,16 @@ use OCA\Circles\Model\Member; use OCP\IUserManager; use Symfony\Component\Console\Output\OutputInterface; - /** * Class MaintenanceService * * @package OCA\Circles\Service */ class MaintenanceService { - - use TNC22Logger; - const TIMEOUT = 18000; + public const TIMEOUT = 18000; /** @var IUserManager */ @@ -258,7 +254,6 @@ class MaintenanceService { // $this->refreshDisplayName(); // } catch (Exception $e) { // } - } @@ -343,6 +338,4 @@ class MaintenanceService { $this->output->writeln('- ' . $message); } } - } - diff --git a/lib/Service/MemberService.php b/lib/Service/MemberService.php index 5de602c0..c6bf0996 100644 --- a/lib/Service/MemberService.php +++ b/lib/Service/MemberService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; @@ -65,15 +64,12 @@ use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; - /** * Class MemberService * * @package OCA\Circles\Service */ class MemberService { - - use TArrayTools; use TStringTools; use TNC22Logger; @@ -255,7 +251,7 @@ class MemberService { } $members = array_map( - function(FederatedUser $federatedUser) use ($patron) { + function (FederatedUser $federatedUser) use ($patron) { $member = new Member(); $member->importFromIFederatedUser($federatedUser); $member->setInvitedBy($patron); @@ -361,6 +357,4 @@ class MemberService { return true; } - } - diff --git a/lib/Service/MembersService.php b/lib/Service/MembersService.php index d479d614..11288df0 100644 --- a/lib/Service/MembersService.php +++ b/lib/Service/MembersService.php @@ -26,7 +26,6 @@ namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestResultNotJsonException; use ArtificialOwl\MySmallPhpTools\Model\Nextcloud\nc22\NC22Request; @@ -58,7 +57,6 @@ use OCA\Circles\Model\GlobalScale\GSEvent; use OCP\IL10N; use OCP\IUserManager; - /** * Class MembersService * @@ -66,8 +64,6 @@ use OCP\IUserManager; * @package OCA\Circles\Service */ class MembersService { - - use TNC22Request; use TArrayTools; @@ -283,7 +279,6 @@ class MembersService { * @throws MemberCantJoinCircleException */ private function addLocalMember(DeprecatedCircle $circle, DeprecatedMember $member) { - if ($member->getType() !== DeprecatedMember::TYPE_USER) { return; } @@ -303,7 +298,6 @@ class MembersService { * @param DeprecatedMember $member */ private function addEmailAddress(DeprecatedMember $member) { - if ($member->getType() !== DeprecatedMember::TYPE_MAIL) { return; } @@ -319,7 +313,6 @@ class MembersService { * @param DeprecatedMember $member */ private function addContact(DeprecatedMember $member) { - if ($member->getType() !== DeprecatedMember::TYPE_CONTACT) { return; } @@ -457,7 +450,6 @@ class MembersService { * @return DeprecatedMember[] */ private function addMassiveMails(DeprecatedCircle $circle, $mails): array { - $mails = trim($mails); if (substr($mails, 0, 6) !== 'mails:') { return []; @@ -584,7 +576,6 @@ class MembersService { } else { return $this->membersRequest->forceGetMembers($circle->getUniqueId()); } - } @@ -605,7 +596,6 @@ class MembersService { public function removeMember( string $circleUniqueId, string $name, int $type, string $instance, bool $force = false ): array { - if ($force === false) { $circle = $this->circlesRequest->getCircle($circleUniqueId, $this->userId); $circle->getHigherViewer() @@ -782,7 +772,4 @@ class MembersService { return array_merge($base, $new); } - - } - diff --git a/lib/Service/MembershipService.php b/lib/Service/MembershipService.php index 69650f6f..dbb07e1a 100644 --- a/lib/Service/MembershipService.php +++ b/lib/Service/MembershipService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Exceptions\ItemNotFoundException; use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; @@ -46,15 +45,12 @@ use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; use OCA\Circles\Model\Membership; - /** * Class MembershipService * * @package OCA\Circles\Service */ class MembershipService { - - use TNC22Logger; @@ -280,7 +276,7 @@ class MembershipService { */ private function getChildrenMembers(string $id, array &$knownIds = []): array { $singleIds = array_map( - function(Member $item): string { + function (Member $item): string { return $item->getSingleId(); }, $this->memberRequest->getMembers($id) ); @@ -304,7 +300,7 @@ class MembershipService { */ private function getChildrenMemberships(string $id, array &$knownIds = []): array { $singleIds = array_map( - function(Membership $item): string { + function (Membership $item): string { return $item->getSingleId(); }, $this->membershipRequest->getInherited($id) ); @@ -350,7 +346,7 @@ class MembershipService { */ private function removeDeprecatedMemberships(array $memberships, array $known): array { $circleIds = array_map( - function(Membership $membership): string { + function (Membership $membership): string { return $membership->getCircleId(); }, $memberships ); @@ -408,6 +404,4 @@ class MembershipService { throw new ItemNotFoundException(); } - } - diff --git a/lib/Service/MigrationService.php b/lib/Service/MigrationService.php index e18f82a0..4b71984a 100644 --- a/lib/Service/MigrationService.php +++ b/lib/Service/MigrationService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -70,15 +69,12 @@ use OCP\IDBConnection; use OCP\IURLGenerator; use OCP\Share\IShare; - /** * Class MigrationService * * @package OCA\Circles\Service */ class MigrationService { - - use TStringTools; use TNC22Logger; @@ -446,7 +442,7 @@ class MigrationService { * @throws ContactAddressBookNotFoundException */ private function fixContactId(Member $member) { - list($userId, $contactId) = explode(':', $member->getUserId()); + [$userId, $contactId] = explode(':', $member->getUserId()); $contactsManager = OC::$server->get(ContactsManager::class); @@ -552,6 +548,4 @@ class MigrationService { } catch (RequestBuilderException $e) { } } - } - diff --git a/lib/Service/MiscService.php b/lib/Service/MiscService.php index 6317bb5e..03d17197 100644 --- a/lib/Service/MiscService.php +++ b/lib/Service/MiscService.php @@ -40,8 +40,6 @@ use OCP\ILogger; use OCP\IUserManager; class MiscService { - - use TArrayTools; @@ -67,10 +65,10 @@ class MiscService { } public function log($message, $level = 4) { - $data = array( - 'app' => $this->appName, + $data = [ + 'app' => $this->appName, 'level' => $level - ); + ]; $this->logger->log($level, $message, $data); } @@ -123,7 +121,7 @@ class MiscService { $this->log(json_encode($data)); return new DataResponse( - array_merge($data, array('status' => 0)), + array_merge($data, ['status' => 0]), Http::STATUS_NON_AUTHORATIVE_INFORMATION ); } @@ -136,7 +134,7 @@ class MiscService { */ public function success($data) { return new DataResponse( - array_merge($data, array('status' => 1)), + array_merge($data, ['status' => 1]), Http::STATUS_CREATED ); } @@ -177,7 +175,7 @@ class MiscService { return ''; } - list($userId, $contactId) = explode(':', $ident); + [$userId, $contactId] = explode(':', $ident); $entries = []; try { /** @var \OCA\DAV\CardDAV\ContactsManager $cManager */ @@ -268,7 +266,7 @@ class MiscService { return []; } - list($userId, $contactId) = explode(':', $ident); + [$userId, $contactId] = explode(':', $ident); try { /** @var \OCA\DAV\CardDAV\ContactsManager $cManager */ @@ -345,8 +343,8 @@ class MiscService { */ public static function generateClientBodyData($options = []) { return [ - 'body' => ['data' => $options], - 'timeout' => Application::CLIENT_TIMEOUT, + 'body' => ['data' => $options], + 'timeout' => Application::CLIENT_TIMEOUT, 'connect_timeout' => Application::CLIENT_TIMEOUT ]; } @@ -406,11 +404,8 @@ class MiscService { return [ 'memberId' => $member->getMemberId(), - 'emails' => $this->getArray('EMAIL', $contact), + 'emails' => $this->getArray('EMAIL', $contact), 'cloudIds' => $this->getArray('CLOUD', $contact) ]; - } - } - diff --git a/lib/Service/NotificationService.php b/lib/Service/NotificationService.php index fc950043..5f14f76c 100644 --- a/lib/Service/NotificationService.php +++ b/lib/Service/NotificationService.php @@ -34,7 +34,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use OCA\Circles\AppInfo\Application; use OCA\Circles\Db\MemberRequest; @@ -44,15 +43,12 @@ use OCP\IURLGenerator; use OCP\Notification\IManager as INotificationManager; use OCP\Notification\INotification; - /** * Class NotificationService * * @package OCA\Circles\Service */ class NotificationService { - - use TNC22Logger; @@ -178,7 +174,6 @@ class NotificationService { $this->notificationManager->notify($notification); } - } @@ -233,6 +228,4 @@ class NotificationService { return parse_url($absolute, PHP_URL_PATH); } - } - diff --git a/lib/Service/OutputService.php b/lib/Service/OutputService.php index 7a9b7fa3..cb6f628e 100644 --- a/lib/Service/OutputService.php +++ b/lib/Service/OutputService.php @@ -31,21 +31,17 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCP\Migration\IOutput; use Symfony\Component\Console\Output\OutputInterface; - /** * Class OutputService * * @package OCA\Circles\Service */ class OutputService { - - use TStringTools; use TNC22Logger; @@ -117,6 +113,4 @@ class OutputService { $this->migrationOutput->finishProgress(); } - } - diff --git a/lib/Service/RemoteDownstreamService.php b/lib/Service/RemoteDownstreamService.php index 339f1e45..b4a9cc55 100644 --- a/lib/Service/RemoteDownstreamService.php +++ b/lib/Service/RemoteDownstreamService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException; @@ -55,15 +54,12 @@ use OCA\Circles\Exceptions\RequestBuilderException; use OCA\Circles\Exceptions\UnknownRemoteException; use OCA\Circles\Model\Federated\FederatedEvent; - /** * Class RemoteDownstreamService * * @package OCA\Circles\Service */ class RemoteDownstreamService { - - use TNC22Logger; use TAsync; @@ -334,6 +330,4 @@ class RemoteDownstreamService { throw new FederatedEventException('invalid origin'); } } - } - diff --git a/lib/Service/RemoteService.php b/lib/Service/RemoteService.php index 3a23dc3f..e372e66c 100644 --- a/lib/Service/RemoteService.php +++ b/lib/Service/RemoteService.php @@ -30,7 +30,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\ActivityPub\Nextcloud\nc22\NC22Signature; use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; @@ -54,7 +53,6 @@ use OCA\Circles\Model\Federated\RemoteInstance; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Model\Member; - /** * Class RemoteService * @@ -233,7 +231,6 @@ class RemoteService extends NC22Signature { * @param Circle $circle */ private function syncLocalCircle(Circle $circle): void { - } @@ -325,7 +322,6 @@ class RemoteService extends NC22Signature { string $instance, int $type = Member::TYPE_USER ): FederatedUser { - $result = $this->remoteStreamService->resultRequestRemoteInstance( $instance, RemoteInstance::MEMBER, @@ -350,6 +346,4 @@ class RemoteService extends NC22Signature { return $federatedUser; } - } - diff --git a/lib/Service/RemoteStreamService.php b/lib/Service/RemoteStreamService.php index 8a9c748b..aea86357 100644 --- a/lib/Service/RemoteStreamService.php +++ b/lib/Service/RemoteStreamService.php @@ -30,7 +30,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\ActivityPub\Nextcloud\nc22\NC22Signature; use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException; use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException; @@ -63,26 +62,23 @@ use OCP\IURLGenerator; use ReflectionClass; use ReflectionException; - /** * Class RemoteStreamService * * @package OCA\Circles\Service */ class RemoteStreamService extends NC22Signature { - - use TNC22Deserialize; use TNC22LocalSignatory; use TStringTools; use TNC22WellKnown; - const UPDATE_DATA = 'data'; - const UPDATE_ITEM = 'item'; - const UPDATE_TYPE = 'type'; - const UPDATE_INSTANCE = 'instance'; - const UPDATE_HREF = 'href'; + public const UPDATE_DATA = 'data'; + public const UPDATE_ITEM = 'item'; + public const UPDATE_TYPE = 'type'; + public const UPDATE_INSTANCE = 'instance'; + public const UPDATE_HREF = 'href'; /** @var IURLGenerator */ @@ -436,7 +432,7 @@ class RemoteStreamService extends NC22Signature { * @throws SignatureException */ private function confirmAuth(RemoteInstance $remote, string $auth): void { - list($algo, $signed) = explode(':', $this->get('auth-signed', $remote->getOrigData())); + [$algo, $signed] = explode(':', $this->get('auth-signed', $remote->getOrigData())); try { if ($signed === null) { throw new SignatureException('invalid auth-signed'); @@ -575,6 +571,4 @@ class RemoteStreamService extends NC22Signature { break; } } - } - diff --git a/lib/Service/RemoteUpstreamService.php b/lib/Service/RemoteUpstreamService.php index 3e075488..e510d8a2 100644 --- a/lib/Service/RemoteUpstreamService.php +++ b/lib/Service/RemoteUpstreamService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Model\Request; use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Request; @@ -46,15 +45,12 @@ use OCA\Circles\Model\Federated\EventWrapper; use OCA\Circles\Model\Federated\FederatedEvent; use OCA\Circles\Model\Federated\RemoteInstance; - /** * Class RemoteUpstreamService * * @package OCA\Circles\Service */ class RemoteUpstreamService { - - use TNC22Request; @@ -314,6 +310,4 @@ class RemoteUpstreamService { //// $this->deprecatedEvents(); // // } - } - diff --git a/lib/Service/SearchService.php b/lib/Service/SearchService.php index a1c018ac..aaddf599 100644 --- a/lib/Service/SearchService.php +++ b/lib/Service/SearchService.php @@ -31,22 +31,18 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use OC; use OCA\Circles\ISearch; use OCA\Circles\Model\FederatedUser; use OCA\Circles\Search\FederatedUsers; - /** * Class SearchService * * @package OCA\Circles\Service */ class SearchService { - - - static $SERVICES = [ + public static $SERVICES = [ FederatedUsers::class ]; @@ -76,6 +72,4 @@ class SearchService { return $result; } - } - diff --git a/lib/Service/ShareService.php b/lib/Service/ShareService.php index d1776e13..1235fd62 100644 --- a/lib/Service/ShareService.php +++ b/lib/Service/ShareService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use OCA\Circles\Model\Circle; use OCA\Circles\Model\Federated\FederatedEvent; @@ -70,5 +69,4 @@ class ShareService { // $event->setCircle($circle); // $this->federatedEventService->newEvent($event); } - } diff --git a/lib/Service/ShareTokenService.php b/lib/Service/ShareTokenService.php index c5e61e62..98edee6b 100644 --- a/lib/Service/ShareTokenService.php +++ b/lib/Service/ShareTokenService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Db\ShareTokenRequest; use OCA\Circles\Exceptions\ShareTokenAlreadyExistException; @@ -42,15 +41,12 @@ use OCA\Circles\Model\ShareWrapper; use OCP\IURLGenerator; use OCP\Share\IShare; - /** * Class ShareTokenService * * @package OCA\Circles\Service */ class ShareTokenService { - - use TStringTools; @@ -133,6 +129,4 @@ class ShareTokenService { public function removeTokens(string $singleId, string $circleId) { $this->shareTokenRequest->removeTokens($singleId, $circleId); } - } - diff --git a/lib/Service/ShareWrapperService.php b/lib/Service/ShareWrapperService.php index a9540d20..b52df30f 100644 --- a/lib/Service/ShareWrapperService.php +++ b/lib/Service/ShareWrapperService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use OCA\Circles\Db\ShareWrapperRequest; use OCA\Circles\Exceptions\RequestBuilderException; @@ -41,15 +40,12 @@ use OCA\Circles\Model\ShareWrapper; use OCP\Files\NotFoundException; use OCP\Share\IShare; - /** * Class ShareWrapperService * * @package OCA\Circles\Service */ class ShareWrapperService { - - use TStringTools; @@ -262,6 +258,4 @@ class ShareWrapperService { return $this->getShareById($childId, $federatedUser); } - } - diff --git a/lib/Service/SyncService.php b/lib/Service/SyncService.php index f242de50..cc8d2659 100644 --- a/lib/Service/SyncService.php +++ b/lib/Service/SyncService.php @@ -31,7 +31,6 @@ declare(strict_types=1); namespace OCA\Circles\Service; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; use Exception; @@ -65,26 +64,23 @@ use OCA\Circles\Model\Member; use OCP\IGroupManager; use OCP\IUserManager; - /** * Class SyncService * * @package OCA\Circles\Service */ class SyncService { - - use TStringTools; use TNC22Logger; - const SYNC_APPS = 1; - const SYNC_USERS = 2; - const SYNC_GROUPS = 4; - const SYNC_GLOBALSCALE = 8; - const SYNC_REMOTES = 16; - const SYNC_CONTACTS = 32; - const SYNC_ALL = 63; + public const SYNC_APPS = 1; + public const SYNC_USERS = 2; + public const SYNC_GROUPS = 4; + public const SYNC_GLOBALSCALE = 8; + public const SYNC_REMOTES = 16; + public const SYNC_CONTACTS = 32; + public const SYNC_ALL = 63; /** @var IUserManager */ @@ -518,6 +514,4 @@ class SyncService { */ public function syncRemoteCircle(string $circleId): void { } - } - diff --git a/lib/Service/TimezoneService.php b/lib/Service/TimezoneService.php index e5776006..cadae2dc 100644 --- a/lib/Service/TimezoneService.php +++ b/lib/Service/TimezoneService.php @@ -26,7 +26,6 @@ namespace OCA\Circles\Service; - use DateTime; use OC\AppFramework\Utility\TimeFactory; @@ -117,5 +116,3 @@ class TimezoneService { return $format; } } - - diff --git a/lib/ShareByCircleProvider.php b/lib/ShareByCircleProvider.php index c6f5520d..11216f97 100644 --- a/lib/ShareByCircleProvider.php +++ b/lib/ShareByCircleProvider.php @@ -34,7 +34,6 @@ declare(strict_types=1); namespace OCA\Circles; - use ArtificialOwl\MySmallPhpTools\Traits\Nextcloud\nc22\TNC22Logger; use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools; use ArtificialOwl\MySmallPhpTools\Traits\TStringTools; @@ -85,21 +84,18 @@ use OCP\Share\Exceptions\ShareNotFound; use OCP\Share\IShare; use OCP\Share\IShareProvider; - /** * Class ShareByCircleProvider * * @package OCA\Circles */ class ShareByCircleProvider implements IShareProvider { - - use TArrayTools; use TStringTools; use TNC22Logger; - const IDENTIFIER = 'ocCircleShare'; + public const IDENTIFIER = 'ocCircleShare'; /** @var IUserManager */ @@ -463,7 +459,7 @@ class ShareByCircleProvider implements IShareProvider { return array_filter( array_map( - function(ShareWrapper $wrapper) { + function (ShareWrapper $wrapper) { return $wrapper->getShare($this->rootFolder, $this->userManager, $this->urlGenerator); }, $wrappedShares ) @@ -515,7 +511,7 @@ class ShareByCircleProvider implements IShareProvider { return array_filter( array_map( - function(ShareWrapper $wrapper) { + function (ShareWrapper $wrapper) { return $wrapper->getShare($this->rootFolder, $this->userManager, $this->urlGenerator); }, $wrappedShares ) @@ -559,7 +555,7 @@ class ShareByCircleProvider implements IShareProvider { return array_filter( array_map( - function(ShareWrapper $wrapper) { + function (ShareWrapper $wrapper) { return $wrapper->getShare( $this->rootFolder, $this->userManager, $this->urlGenerator, true ); @@ -661,6 +657,4 @@ class ShareByCircleProvider implements IShareProvider { // } // $cursor->closeCursor(); } - } - diff --git a/lib/ShareByCircleProviderDeprecated.php b/lib/ShareByCircleProviderDeprecated.php index ae611a0e..b1ad6073 100644 --- a/lib/ShareByCircleProviderDeprecated.php +++ b/lib/ShareByCircleProviderDeprecated.php @@ -30,7 +30,6 @@ namespace OCA\Circles; - use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore; use Exception; use OC; @@ -72,7 +71,6 @@ use OCP\Share\Exceptions\ShareNotFound; use OCP\Share\IShare; use OCP\Share\IShareProvider; - /** * Class ShareByCircleProvider * @@ -215,7 +213,6 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I * @return IShare The share object */ public function update(IShare $share) { - $qb = $this->getBaseUpdateSql(); $this->limitToShare($qb, $share->getId()); $qb->set('permissions', $qb->createNamedParameter($share->getPermissions())) @@ -247,8 +244,8 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I $store = new SimpleDataStore(); $store->sArray( 'share', [ - 'id' => $share->getId() - ] + 'id' => $share->getId() + ] ); $event->setData($store); @@ -288,7 +285,6 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I * */ public function move(IShare $share, $userId) { - $childId = $this->getShareChildId($share, $userId); $qb = $this->getBaseUpdateSql(); @@ -496,7 +492,7 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I /** * Get shares for a given path - + * * @param Node $path * * @return IShare[]|null @@ -554,7 +550,6 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I * @throws NotFoundException */ private function getSharedWithCircleMembers($userId, $shareType, $node, $limit, $offset) { - $qb = $this->getCompleteSelectSql(); $this->linkToFileCache($qb, $userId); $this->limitToPage($qb, $limit, $offset); @@ -753,7 +748,7 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I if (($password = $this->get('personal_password', $data, '')) !== '') { $share->setPassword($this->get('personal_password', $data, '')); - } else if (($password = $this->get('password', $data, '')) !== '') { + } elseif (($password = $this->get('password', $data, '')) !== '') { $share->setPassword($this->get('password', $data, '')); } @@ -835,7 +830,7 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I ->getName(); $message = 'Sharing %s failed, this item is already shared with this circle'; - $message_t = $this->l10n->t($message, array($share_src)); + $message_t = $this->l10n->t($message, [$share_src]); $this->logger->debug( sprintf($message, $share_src, $share->getSharedWith()), ['app' => 'circles'] ); @@ -901,7 +896,6 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I * @return array */ private function parseAccessListResult(IQueryBuilder $qb) { - $cursor = $qb->execute(); $users = []; @@ -910,7 +904,7 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I if (!key_exists($userId, $users)) { $users[$userId] = [ - 'node_id' => $row['file_source'], + 'node_id' => $row['file_source'], 'node_path' => $row['file_target'] ]; } @@ -929,14 +923,14 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I */ private function shareObjectToArray(IShare $share) { return [ - 'id' => $share->getId(), - 'sharedWith' => $share->getSharedWith(), - 'sharedBy' => $share->getSharedBy(), - 'nodeId' => $share->getNodeId(), - 'shareOwner' => $share->getShareOwner(), + 'id' => $share->getId(), + 'sharedWith' => $share->getSharedWith(), + 'sharedBy' => $share->getSharedBy(), + 'nodeId' => $share->getNodeId(), + 'shareOwner' => $share->getShareOwner(), 'permissions' => $share->getPermissions(), - 'token' => $share->getToken(), - 'password' => ($share->getPassword() === null) ? '' : $share->getPassword() + 'token' => $share->getToken(), + 'password' => ($share->getPassword() === null) ? '' : $share->getPassword() ]; } @@ -1025,6 +1019,4 @@ class ShareByCircleProviderDeprecated extends CircleProviderRequest implements I return $str; } - - } diff --git a/lib/StatusCode.php b/lib/StatusCode.php index e115e358..aca51529 100644 --- a/lib/StatusCode.php +++ b/lib/StatusCode.php @@ -31,35 +31,32 @@ declare(strict_types=1); namespace OCA\Circles; - /** * Class StatusCode * * @package OCA\Circles */ class StatusCode { - - - static $CIRCLE_CREATE = [ + public static $CIRCLE_CREATE = [ 120 => 'Duplicate name' ]; - static $CIRCLE_CONFIG = [ + public static $CIRCLE_CONFIG = [ 120 => 'Invalid configuration' ]; - static $CIRCLE_JOIN = [ + public static $CIRCLE_JOIN = [ 121 => 'Circle is full', 122 => 'You are already a member', 123 => 'Already requesting to join the circle', 124 => 'Circle is closed' ]; - static $CIRCLE_LEAVE = [ + public static $CIRCLE_LEAVE = [ 120 => 'You are not a member' ]; - static $MEMBER_ADD = [ + public static $MEMBER_ADD = [ 120 => 'Unknown entity', 121 => 'Circle is full', 122 => 'Already member of the circle', @@ -73,17 +70,16 @@ class StatusCode { 130 => 'Member is invited by an entity that does not belongs to the instance at the origin of the request' ]; - static $MEMBER_LEVEL = [ + public static $MEMBER_LEVEL = [ 120 => 'The designed member\'s level is too high', 121 => 'Incorrect Level' ]; - static $MEMBER_DISPLAY_NAME = [ + public static $MEMBER_DISPLAY_NAME = [ 120 => 'DisplayName cannot be empty' ]; - static $MEMBER_REMOVE = [ + public static $MEMBER_REMOVE = [ 120 => 'The designed member\'s level is too high', ]; - } diff --git a/templates/files/list.php b/templates/files/list.php index 841ce7b5..b2929034 100644 --- a/templates/files/list.php +++ b/templates/files/list.php @@ -18,14 +18,14 @@
- t( 'Name' )); ?> + t('Name')); ?>
t('Size')); ?> - t( 'Modified' )); ?> + t('Modified')); ?> diff --git a/tests/TestSuiteListener.php b/tests/TestSuiteListener.php index 12fbfea8..01bab544 100644 --- a/tests/TestSuiteListener.php +++ b/tests/TestSuiteListener.php @@ -27,31 +27,28 @@ namespace OCA\Circles\Tests; - use OCA\Circles\Model\DeprecatedCircle; class Env implements \PHPUnit_Framework_TestListener { + public const ENV_TEST_OWNER1 = '_test_circles_owner1'; + public const ENV_TEST_OWNER2 = '_test_circles_owner2'; + public const ENV_TEST_OWNER3 = '_test_circles_owner3'; + public const ENV_TEST_ADMIN1 = '_test_circles_admin1'; + public const ENV_TEST_ADMIN2 = '_test_circles_admin2'; + public const ENV_TEST_ADMIN3 = '_test_circles_admin3'; - const ENV_TEST_OWNER1 = '_test_circles_owner1'; - const ENV_TEST_OWNER2 = '_test_circles_owner2'; - const ENV_TEST_OWNER3 = '_test_circles_owner3'; + public const ENV_TEST_MODERATOR1 = '_test_circles_mod1'; + public const ENV_TEST_MODERATOR2 = '_test_circles_mod2'; + public const ENV_TEST_MODERATOR3 = '_test_circles_mod3'; - const ENV_TEST_ADMIN1 = '_test_circles_admin1'; - const ENV_TEST_ADMIN2 = '_test_circles_admin2'; - const ENV_TEST_ADMIN3 = '_test_circles_admin3'; + public const ENV_TEST_MEMBER1 = '_test_circles_member1'; + public const ENV_TEST_MEMBER2 = '_test_circles_member2'; + public const ENV_TEST_MEMBER3 = '_test_circles_member3'; - const ENV_TEST_MODERATOR1 = '_test_circles_mod1'; - const ENV_TEST_MODERATOR2 = '_test_circles_mod2'; - const ENV_TEST_MODERATOR3 = '_test_circles_mod3'; - - const ENV_TEST_MEMBER1 = '_test_circles_member1'; - const ENV_TEST_MEMBER2 = '_test_circles_member2'; - const ENV_TEST_MEMBER3 = '_test_circles_member3'; - - const ENV_TEST_USER1 = '_test_circles_user1'; - const ENV_TEST_USER2 = '_test_circles_user2'; - const ENV_TEST_USER3 = '_test_circles_user3'; + public const ENV_TEST_USER1 = '_test_circles_user1'; + public const ENV_TEST_USER2 = '_test_circles_user2'; + public const ENV_TEST_USER3 = '_test_circles_user3'; /** @var array */ @@ -88,7 +85,7 @@ class Env implements \PHPUnit_Framework_TestListener { $userManager = \OC::$server->getUserManager(); $this->users = self::listUsers(); - foreach ($this->users AS $UID) { + foreach ($this->users as $UID) { if ($userManager->userExists($UID) === false) { $userManager->createUser($UID, $UID); } @@ -100,7 +97,7 @@ class Env implements \PHPUnit_Framework_TestListener { return; } - foreach ($this->users AS $UID) { + foreach ($this->users as $UID) { $user = \OC::$server->getUserManager() ->get($UID); if ($user !== null) { @@ -114,7 +111,6 @@ class Env implements \PHPUnit_Framework_TestListener { } public static function setUser($which) { - $userSession = \OC::$server->getUserSession(); $userSession->setUser( \OC::$server->getUserManager() @@ -165,5 +161,3 @@ class Env implements \PHPUnit_Framework_TestListener { ]; } } - - diff --git a/tests/bootstrap.php b/tests/bootstrap.php index c6a208fe..4d16b4de 100644 --- a/tests/bootstrap.php +++ b/tests/bootstrap.php @@ -1,6 +1,5 @@ circles = array(); + $this->circles = []; try { $this->circles = [ - 'Public' => + 'Public' => Circles::createCircle(DeprecatedCircle::CIRCLES_PUBLIC, self::NAME_PUBLIC_CIRCLE1), - 'Secret' => + 'Secret' => Circles::createCircle(DeprecatedCircle::CIRCLES_SECRET, self::NAME_SECRET_CIRCLE1), - 'Closed' => + 'Closed' => Circles::createCircle(DeprecatedCircle::CIRCLES_CLOSED, self::NAME_CLOSED_CIRCLE1), 'Personal' => Circles::createCircle(DeprecatedCircle::CIRCLES_PERSONAL, self::NAME_PERSONAL_CIRCLE1) ]; - } catch (Exception $e) { throw $e; } @@ -186,7 +183,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { Env::setUser(Env::ENV_TEST_ADMIN1); foreach ($circles as $circle) { - try { Circles::levelMember( $circle->getId(), Env::ENV_TEST_ADMIN3, DeprecatedMember::TYPE_USER, @@ -348,7 +344,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { 'should have returned a MemberIsNotModeratorException - ' . $e->getMessage() ); } - } Env::logout(); @@ -398,7 +393,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { true, false, 'should have returned a CircleAlreadyExistsException' ); } - } else { for ($j = 0; $j < sizeof($circleNames); $j++) { try { @@ -481,7 +475,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { for ($i = 0; $i < 3; $i++) { foreach ($this->circles as $circle) { - try { $member = Circles::getMember( $circle->getId(), Env::ENV_TEST_MEMBER2, DeprecatedMember::TYPE_USER @@ -562,11 +555,9 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { ); } catch (MemberDoesNotExistException $e) { } - } catch (Exception $e) { throw $e; } - } } @@ -584,7 +575,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { for ($i = 0; $i < 3; $i++) { foreach ($this->circles as $circle) { - try { $member = Circles::getMember( $circle->getId(), Env::ENV_TEST_MEMBER3, DeprecatedMember::TYPE_USER @@ -666,7 +656,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { $member->getCircleId() ] ); - } catch (Exception $e) { throw $e; } @@ -709,7 +698,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { throw $e; } Env::setUser(Env::ENV_TEST_MEMBER3); - } } } @@ -760,11 +748,11 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { $this->assertEquals( $result, [ - self::NAME_PUBLIC_CIRCLE1, - self::NAME_SECRET_CIRCLE1, - self::NAME_CLOSED_CIRCLE1, - self::NAME_PERSONAL_CIRCLE1 - ] + self::NAME_PUBLIC_CIRCLE1, + self::NAME_SECRET_CIRCLE1, + self::NAME_CLOSED_CIRCLE1, + self::NAME_PERSONAL_CIRCLE1 + ] ); @@ -781,10 +769,10 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { $this->assertEquals( $result, [ - self::NAME_PUBLIC_CIRCLE1, - self::NAME_SECRET_CIRCLE1, - self::NAME_CLOSED_CIRCLE1 - ] + self::NAME_PUBLIC_CIRCLE1, + self::NAME_SECRET_CIRCLE1, + self::NAME_CLOSED_CIRCLE1 + ] ); @@ -867,7 +855,6 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { * @throws QueryException */ protected function generateSimpleCircleWithAllLevel($circleId, $isClosed = false) { - $curr = Env::currentUser(); Circles::addMember($circleId, Env::ENV_TEST_ADMIN1, DeprecatedMember::TYPE_USER); @@ -901,5 +888,4 @@ class CirclesTest extends \PHPUnit_Framework_TestCase { $circleId, Env::ENV_TEST_MEMBER1, DeprecatedMember::TYPE_USER, DeprecatedMember::LEVEL_MEMBER ); } - }