develop-candymat #7

Merged

christoph.lienhard merged 10 commits from develop-candymat into main

2022-02-02 15:03:48 +01:00

christoph.lienhard commented

2022-02-02 13:45:00 +01:00

Owner

No description provided.

christoph.lienhard added 9 commits 2022-02-02 13:45:01 +01:00

13be951160 Add vue-apollo to user-app

It does not fetch anything yet.
It points to the graphql server on localhost, which is a hardcoded dev-mode.
Added config for GraphQL JS intellij plugin which inspects a "remote" graphql schema for better type hints in graphql queries in code

0347a54ac0 Use backend on theses page

66019ecda9 Use backend on emphasis page

f01d492d95 Fix calculation of scores

With this commit two calculation errors are fixed
 * the score in the case partyPosition = 'negative' while userPosition = 'neutral' shouldn't be MIN_POINTS but rather BASE_POINTS.
 * the totalScoredPoints (now "totalMaxPoints") should be independent of any party-positions which it wasn't.

To minimize errors in this area in the future tests are added
which are based on the official Rechenmodel of the bpb.
To that end the score calculation logic was refactored
 and moved from results.vue to scoring.js, too.

(cherry picked from commit 2d246fefbc4730ca5f7a4224325084a98f1c41f0)

498a02bf1d Use graphql to retrieve parties

5512955af4 Add Note in Readme concerning variable naming

64e6b861b6 Last not Least: Get party details page from backend

Also
* reorder graphQl queries: Always a query constant + update function
* use id instead of token (initials) to identify person in url
* Remove any party logo related sections since currently not needed
* Move "options" from data closer to actual code since it doesn't really belong to data
  (data may be deleted in the future, anyway)
* add nodeId in gql queries wherever possible to avoid problems with the apollo cache
* add note about graphql schema import to README.md

f239bec4ff Merge pull request 'feature/get-data-from-backend' (#6 ) from feature/get-data-from-backend into develop-candymat

Reviewed-on: Netzbegruenung/candymat-user-app#6

d414b95c1c

Fix several smaller problems

* adapt for structure change in gql backend (e.g. id -> rowId)
* display questions not rowId dependent anymore
* fixed calculation error if both, party and user, selected "skipped"
* fixed problems occuring when a candidate hasn't answered all questions (yet)

christoph.lienhard added 1 commit 2022-02-02 15:03:31 +01:00

b898bbe184 Rename candymat -> kandimat everywhere

christoph.lienhard merged commit dc1602b6e8 into main

2022-02-02 15:03:48 +01:00

christoph.lienhard referenced this issue from a commit

2022-02-02 15:03:49 +01:00

Merge pull request 'develop-candymat' (#7) from develop-candymat into main

No reviewers