Basic Cleanup in docker-compose files for convenience and Readme fixing #9

Merged
peter.mueller merged 0 commits from refs/pull/9/head into develop 2020-05-31 10:26:02 +02:00
peter.mueller commented 2020-05-30 19:56:09 +02:00 (Migrated from git.verdigado.com)
  • Changed local ports of services for convenience
  • Took frontend apps into the frontend network
  • updated docker-compose.prod.yml for not exposing the ports of backend services to the local machine
  • some other small changes on docker-compose.*.yml
  • updated readme in the mannaer of changed ports and urls.
* Changed local ports of services for convenience * Took frontend apps into the frontend network * updated docker-compose.prod.yml for not exposing the ports of backend services to the local machine * some other small changes on docker-compose.*.yml * updated readme in the mannaer of changed ports and urls.
christoph.lienhard (Migrated from git.verdigado.com) reviewed 2020-05-31 09:07:11 +02:00
christoph.lienhard (Migrated from git.verdigado.com) commented 2020-05-31 09:07:11 +02:00

I think we should stick with latest

I think we should stick with latest
christoph.lienhard (Migrated from git.verdigado.com) reviewed 2020-05-31 09:09:40 +02:00
christoph.lienhard (Migrated from git.verdigado.com) commented 2020-05-31 09:09:40 +02:00

I think this is the point where it starts being obivous that this file does not render a production ready configuration. Let's delete docker-compose.prod.yml completely for now. It only adds the illusion of a prod-ready setup, which it is not (for example postgraphile should start with completely different parameters in production and there should be a repo independent secret management in place). Let's worry about a prod setup the moment we actually want to go to production. As for the volume thing: Let's add it to the dev yaml.

If you want to use a clean database you can still comment it out or delete the volumes by hand.

I think this is the point where it starts being obivous that this file does not render a production ready configuration. Let's delete docker-compose.prod.yml completely for now. It only adds the illusion of a prod-ready setup, which it is not (for example postgraphile should start with completely different parameters in production and there should be a repo independent secret management in place). Let's worry about a prod setup the moment we actually want to go to production. As for the volume thing: Let's add it to the dev yaml. If you want to use a clean database you can still comment it out or delete the volumes by hand.
christoph.lienhard commented 2020-05-31 09:25:14 +02:00 (Migrated from git.verdigado.com)

Thanks for the very necessary adaptions.

Thanks for the very necessary adaptions.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NB-Public/kandimat#9
No description provided.