Implement Room Workflow #16

Merged

HueHe merged 17 commits from implement-rooms into main 2023-06-14 15:05:24 +02:00

Conversation 3 Commits 17 Files changed 12 +450 -45

HueHe commented 2023-06-05 14:35:44 +02:00

Contributor

Copy link

Implements #3

Implements #3

HueHe added 1 commit 2023-06-05 14:53:55 +02:00

Update run instructions to be clearer 9552660bf9

HueHe force-pushed implement-rooms from 9552660bf9 to 560327d5cd 2023-06-05 14:54:43 +02:00 Compare

HueHe added 1 commit 2023-06-05 15:33:45 +02:00

Update entities to have more options 906f929144

HueHe force-pushed implement-rooms from 906f929144 to ecc4f0db10 2023-06-05 15:34:29 +02:00 Compare

HueHe added 1 commit 2023-06-05 15:46:00 +02:00

--wip-- [skip ci] Add room functions 920cf81e36

HueHe added 1 commit 2023-06-05 15:56:32 +02:00

--wip-- [skip ci] 9d73018cea

HueHe force-pushed implement-rooms from 9d73018cea to 4ef070ed85 2023-06-05 15:57:40 +02:00 Compare

HueHe added 1 commit 2023-06-06 12:00:57 +02:00

--wip-- [skip ci] 32ec96187b

HueHe force-pushed implement-rooms from 32ec96187b to 233df882ae 2023-06-06 12:03:17 +02:00 Compare

HueHe force-pushed implement-rooms from 233df882ae to d45edc95e4 2023-06-06 18:21:44 +02:00 Compare

HueHe added 1 commit 2023-06-06 18:38:19 +02:00

--wip-- [skip ci] 9f68a88750

HueHe added 1 commit 2023-06-06 18:50:21 +02:00

--wip-- [skip ci] cc8fa5838a

HueHe force-pushed implement-rooms from cc8fa5838a to 5f947b5deb 2023-06-06 18:51:39 +02:00 Compare

HueHe force-pushed implement-rooms from 5f947b5deb to 113f061b8e 2023-06-06 18:52:08 +02:00 Compare

HueHe force-pushed implement-rooms from 113f061b8e to dcb231af93 2023-06-06 18:58:39 +02:00 Compare

HueHe force-pushed implement-rooms from dcb231af93 to ad9b6226b7 2023-06-07 14:13:41 +02:00 Compare

HueHe force-pushed implement-rooms from ad9b6226b7 to ba03626051 2023-06-07 14:32:06 +02:00 Compare

HueHe commented 2023-06-07 15:38:59 +02:00

Author

Contributor

Copy link

Synapse overwrites the room owner sent upon creation with the authenticated user sending the request. This causes us a few problems, as we can't create direct chats over the API, for example.

Possible solutions that come to my mind are:

1. Creating rooms directly in SQL. This might inflict consistency problems.
2. Creating rooms via the API, changing the room ownership events via SQL.
3. Saving the access token we get as a response to user creation, then using this to create the rooms a user owns. Consequentially, we can use them to join rooms as well, which will be another upcoming issue.

Any opinions, @sven.seeberg or @TreJo?

Synapse overwrites the room owner sent upon creation with the authenticated user sending the request. This causes us a few problems, as we can't create direct chats over the API, for example. Possible solutions that come to my mind are: 1. Creating rooms directly in SQL. This might inflict consistency problems. 1. Creating rooms via the API, changing the room ownership events via SQL. 1. Saving the access token we get as a response to user creation, then using this to create the rooms a user owns. Consequentially, we can use them to join rooms as well, which will be another upcoming issue. Any opinions, @sven.seeberg or @TreJo?

TreJo commented 2023-06-07 15:46:44 +02:00

Owner

Copy link

I think option 3 is definitely the best option. We will need user acces tokens anyways, because as you already mentioned we can only invite people into rooms over the API, but they still need to accept the invite, which they should not need to do manually.

I think option 3 is definitely the best option. We will need user acces tokens anyways, because as you already mentioned we can only invite people into rooms over the API, but they still need to accept the invite, which they should not need to do manually.

👍 1

HueHe force-pushed implement-rooms from ba03626051 to 08fcca5ed2 2023-06-07 15:46:56 +02:00 Compare

HueHe referenced this pull request 2023-06-07 16:33:48 +02:00

Save user access token #18

HueHe force-pushed implement-rooms from 08fcca5ed2 to 924f606b4d 2023-06-07 16:36:18 +02:00 Compare

HueHe commented 2023-06-07 16:38:17 +02:00

Author

Contributor

Copy link

With #18 the token is saved now, I'll see to use it for room creation now.

With #18 the token is saved now, I'll see to use it for room creation now.

HueHe force-pushed implement-rooms from 924f606b4d to ce5a668f1c 2023-06-07 18:08:58 +02:00 Compare

HueHe added 1 commit 2023-06-07 18:09:06 +02:00

Move helper modules 31b07fbe8d

HueHe force-pushed implement-rooms from 31b07fbe8d to 98fe90264f 2023-06-07 18:10:05 +02:00 Compare

HueHe added 1 commit 2023-06-07 18:11:02 +02:00

Add room handler ae3353c6cb

HueHe added 1 commit 2023-06-07 18:23:28 +02:00

Move handlers and clean up 34670d4459

HueHe force-pushed implement-rooms from 34670d4459 to 07a4f426bf 2023-06-07 18:25:29 +02:00 Compare

HueHe force-pushed implement-rooms from 07a4f426bf to 0b27d5ad28 2023-06-07 18:41:25 +02:00 Compare

HueHe force-pushed implement-rooms from 0b27d5ad28 to 4692c7edea 2023-06-07 18:49:23 +02:00 Compare

HueHe added 1 commit 2023-06-12 14:54:35 +02:00

Make accessTokens nullable in storage 91fa37f82d

HueHe added 1 commit 2023-06-12 14:54:44 +02:00

--wip-- [skip ci] ef86d6e369

HueHe added 1 commit 2023-06-12 15:23:50 +02:00

Add public room visibility to public chats 997ebf3ebb

HueHe added 1 commit 2023-06-12 16:51:32 +02:00

Update reset instructions f4891fdc83

HueHe added 1 commit 2023-06-12 16:52:56 +02:00

Add createMembership function e706451d90

HueHe added 1 commit 2023-06-12 16:53:04 +02:00

Fix promises to be awaited 25f6284d06

HueHe force-pushed implement-rooms from 25f6284d06 to 5d5c751de8 2023-06-12 17:39:37 +02:00 Compare

HueHe added 1 commit 2023-06-13 12:32:21 +02:00

Fix error for duplicate room memberships 4a54b63cc0

HueHe added 1 commit 2023-06-13 14:49:19 +02:00

Add instructions for rate limiting ... f767753bb3

Fixes #19

HueHe added 1 commit 2023-06-13 15:22:34 +02:00

--wip-- [skip ci] 375afc834c

HueHe force-pushed implement-rooms from 375afc834c to 33d37b025c 2023-06-14 12:20:23 +02:00 Compare

HueHe force-pushed implement-rooms from 33d37b025c to a06e379531 2023-06-14 13:08:01 +02:00 Compare

HueHe added 1 commit 2023-06-14 13:38:15 +02:00

Add cleanup script to reset dev environment 8b8b7b290d

HueHe added 1 commit 2023-06-14 15:02:21 +02:00

Add membership handling ab597195da

HueHe changed title from WIP: Implement Room Workflow to Implement Room Workflow 2023-06-14 15:04:56 +02:00

HueHe merged commit 83b830e0fc into main 2023-06-14 15:05:24 +02:00

HueHe deleted branch implement-rooms 2023-06-14 15:05:24 +02:00

HueHe referenced this pull request from a commit 2023-06-14 15:05:25 +02:00

Merge pull request 'Implement Room Workflow' (#16) from implement-rooms into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

  

Effort

High

estimated 24 hours of work

  

Effort

Low

estimated 4 hours of work

  

Effort

Medium

estimated 12 hours of work

  

Prio

High

Mission critical

  

Prio

Low

Nice to have

  

Prio

Medium

Improves function or usability substantially

  

Type

Bug

Prevents existing functionality from being used

  

Type

Feature

Adds new features

No labels

Effort

High

Effort

Low

Effort

Medium

Prio

High

Prio

Low

Prio

Medium

Type

Bug

Type

Feature

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

NB-Public/rocketchat2matrix!16

No description provided.